From patchwork Mon May 24 03:13:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Takashi Sakamoto X-Patchwork-Id: 12275485 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7241CC47080 for ; Mon, 24 May 2021 03:14:57 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D8F0361159 for ; Mon, 24 May 2021 03:14:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8F0361159 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sakamocchi.jp Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 93AC5165D; Mon, 24 May 2021 05:14:03 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 93AC5165D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1621826093; bh=jsl6Ellh0s6iLkZ4xVlyPthUuvIPp9uTCv117yM77qw=; h=From:To:Subject:Date:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=PpgBVEv2FGBqKeXipBeiQ2RPpmjBqN2qV6C0XkkXKyx8PJ40E3oFPt3u4BBHFATpP QsPEWNbiMuJTrvaJvtKu9AAdCjglbyLZM3CD4ScLkDDjBIlGMDdHOfJaSTm69Jfdrm 14BQSHmCRJ1IAu5OdiXezbvTizWrns9hDUG41QOc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id DD4A6F8022D; Mon, 24 May 2021 05:14:02 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6A3DEF8025C; Mon, 24 May 2021 05:14:00 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1812AF800B8 for ; Mon, 24 May 2021 05:13:53 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1812AF800B8 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="EdypJ/It"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="KJWGP6Pv" Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id EFF2D5C0114; Sun, 23 May 2021 23:13:51 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sun, 23 May 2021 23:13:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=fm1; bh=7tsge20L5r5DYB0ePrPly2Hnzm iPVy4eh89kZZvMvco=; b=EdypJ/ItM0+XksXkP8ESYkEX0H2QlXIlUJscs5evNI p1gGyLgovT+dd9nfYLK6EHSbuYSuRj3derKniDgwtkA72vToExPRBZjboEQH2XHg JKMuojm/ed8FtOVxYYwie2rg7dL3jydlS9Krhb28/3TUbGHsY/R8nYE34mnyS3Kt 2Xbsb15LN3hpvg1tO/0SM5gx4GkWOqoYuH9qdqYLuSvuMSqXbPMFIYwN1FvoHPuA P5pB36B6LlgHF/P6sVtEoIeIpNMgqjEHCHqAAJRp2oetxWx/inD12YsH6RDZDXWy p3mnCwuhdDr/wY2porNVm0bSfxvqQUZmpcdSOt7Ltl5A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=7tsge20L5r5DYB0eP rPly2HnzmiPVy4eh89kZZvMvco=; b=KJWGP6Pv8YHFi2HXQFRy2gQQxw8osnZMQ FYjSQfd1zldAczc2UQQyIlpiceQZhJEnee1qVf8m8MIA0g4ZiCgWv724oFOYc/Fj +4C+u9SsdXQPrXp0AcyRn8NJoIQaoMXrUZCWt9d4Vqo7y/UIJ4FZPc8ibTPqYDH/ HefwVtg0CoL1ZZ99ux89E07simVu3NvyTabdAN06Od65he/I30+D/AvCgk430bjE 84b0pM2yQT6dw8vK38gwZ8ymZ0SzFSxoIc+eEQ0ud8aNVTlPRSMKwFWDaFYCkco1 kf8XosnLibVhjdsfu5PqgcCHRR2/6SA+g4VLp4DUmJPEsfXSu7XVQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdejkedgfeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgggfestdekredtre dttdenucfhrhhomhepvfgrkhgrshhhihcuufgrkhgrmhhothhouceoohdqthgrkhgrshhh ihesshgrkhgrmhhotggthhhirdhjpheqnecuggftrfgrthhtvghrnhepteeiuefhjeekke efheetieekvdegfefhgffgvdeiheehhfehiedvhffgjeejuddunecuffhomhgrihhnpehk vghrnhgvlhdrohhrghenucfkphepudegrdefrdeihedrudejheenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehoqdhtrghkrghshhhisehsrghk rghmohgttghhihdrjhhp X-ME-Proxy: Received: from workstation.flets-east.jp (ae065175.dynamic.ppp.asahi-net.or.jp [14.3.65.175]) by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 23 May 2021 23:13:50 -0400 (EDT) From: Takashi Sakamoto To: tiwai@suse.de Subject: [PATCH v2 0/4] ALSA: firewire-lib: drop initial NODATA packets or empty packets Date: Mon, 24 May 2021 12:13:42 +0900 Message-Id: <20210524031346.50539-1-o-takashi@sakamocchi.jp> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Cc: alsa-devel@alsa-project.org, clemens@ladisch.de X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi, This patchset is take 2 of my previous one; * https://lore.kernel.org/alsa-devel/20210523124114.272134-1-o-takashi@sakamocchi.jp/ The devices based on BeBoB ASICs or the devices in Tascam FireWire series transfer a batch of NODATA packet or empty packet in initial step of streaming. To avoid processing them, current implementation uses an option to skip processing content of tx packet during some initial cycles. However, the hard-coded number is not enough useful. In 1st patch, ALSA IEC 61883-1/6 packet streaming engine becomes to drop the initial packets. As a result, The tx_init_skip_cycles argument of amdtp_domain_start() function changes its meaning. In the following patches, ALSA bebob driver is refactored. Changes from v1: * Fix -Wunused-but-set-variable warning reported by 0day-ci * Add 2nd patch to obsolete unused member of structure Takashi Sakamoto (4): ALSA: firewire-lib: drop initial NODATA or empty packet ALSA: firewire-lib: obsolete callbacked member ALSA: bebob: cancel switching connection order ALSA: bebob: distinguish M-Audio ProFire Lightbridge quirk sound/firewire/amdtp-stream.c | 145 +++++++++++++++++++--------- sound/firewire/amdtp-stream.h | 6 +- sound/firewire/bebob/bebob.c | 10 +- sound/firewire/bebob/bebob.h | 1 + sound/firewire/bebob/bebob_stream.c | 25 ++--- 5 files changed, 122 insertions(+), 65 deletions(-)