mbox series

[v2,0/6] ASoC: Intel: bytcr_rt5640: Fix HP ElitePad 1000 G2 audio routing

Message ID 20210802142501.991985-1-hdegoede@redhat.com (mailing list archive)
Headers show
Series ASoC: Intel: bytcr_rt5640: Fix HP ElitePad 1000 G2 audio routing | expand

Message

Hans de Goede Aug. 2, 2021, 2:24 p.m. UTC
Changes in v2:
- Only set lineout_string if BYT_RT5640_LINEOUT is set, since
  BYT_RT5640_LINEOUT_AS_HP2 only works if the lineout is enabled in
  the first place

Original cover-letter:

The HP Elitepad 1000 G2 has 2 headset jacks:

1. on the dock which uses the output of the codecs built-in HP-amp +
the standard IN2 input which is always used with the headset-jack.

2. on the tablet itself, this uses the line-out of the codec, combined
with an external HP-amp + IN1 for the headset-mic.

This series adds support for this, resolving:
https://bugzilla.kernel.org/show_bug.cgi?id=213415

Note this series does not add jack-detect support. I plan to add that
with a follow-up series when I can make some time to implement that.

Regards,

Hans


Hans de Goede (6):
  ASoC: Intel: bytcr_rt5640: Move "Platform Clock" routes to the maps
    for the matching in-/output
  ASoC: Intel: bytcr_rt5640: Add line-out support
  ASoC: Intel: bytcr_rt5640: Add a byt_rt5640_get_codec_dai() helper
  ASoC: Intel: bytcr_rt5640: Add support for a second headphones output
  ASoC: Intel: bytcr_rt5640: Add support for a second headset mic input
  ASoC: Intel: bytcr_rt5640: Fix HP ElitePad 1000 G2 quirk

 sound/soc/intel/boards/bytcr_rt5640.c | 118 ++++++++++++++++++++++----
 1 file changed, 102 insertions(+), 16 deletions(-)

Comments

Pierre-Louis Bossart Aug. 2, 2021, 2:39 p.m. UTC | #1
> Hans de Goede (6):
>   ASoC: Intel: bytcr_rt5640: Move "Platform Clock" routes to the maps
>     for the matching in-/output
>   ASoC: Intel: bytcr_rt5640: Add line-out support
>   ASoC: Intel: bytcr_rt5640: Add a byt_rt5640_get_codec_dai() helper
>   ASoC: Intel: bytcr_rt5640: Add support for a second headphones output
>   ASoC: Intel: bytcr_rt5640: Add support for a second headset mic input
>   ASoC: Intel: bytcr_rt5640: Fix HP ElitePad 1000 G2 quirk

For the series

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

Thanks Hans for your work, this is an interesting hardware setup.
Mark Brown Aug. 2, 2021, 8:44 p.m. UTC | #2
On Mon, 2 Aug 2021 16:24:55 +0200, Hans de Goede wrote:
> Changes in v2:
> - Only set lineout_string if BYT_RT5640_LINEOUT is set, since
>   BYT_RT5640_LINEOUT_AS_HP2 only works if the lineout is enabled in
>   the first place
> 
> Original cover-letter:
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/6] ASoC: Intel: bytcr_rt5640: Move "Platform Clock" routes to the maps for the matching in-/output
      commit: dccd1dfd0770bfd494b68d1135b4547b2c602c42
[2/6] ASoC: Intel: bytcr_rt5640: Add line-out support
      commit: dd3e2025100c08d1fabd116bf5b6646f1589a95e
[3/6] ASoC: Intel: bytcr_rt5640: Add a byt_rt5640_get_codec_dai() helper
      commit: 810711407467667761f7fd6aa1b8884203ecbeca
[4/6] ASoC: Intel: bytcr_rt5640: Add support for a second headphones output
      commit: 044c76571277bb87dd3318e55c7ae46a0c27ab0f
[5/6] ASoC: Intel: bytcr_rt5640: Add support for a second headset mic input
      commit: 79c1123bac3b878874a8d7163f2eab6a7448733b
[6/6] ASoC: Intel: bytcr_rt5640: Fix HP ElitePad 1000 G2 quirk
      commit: 780feaf4ad8848e48aa679c0fb9d98d45f691e4e

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark