mbox series

[00/11] ASoC: Intel: Skylake: Fix and support complex

Message ID 20210818075742.1515155-1-cezary.rojewski@intel.com (mailing list archive)
Headers show
Series ASoC: Intel: Skylake: Fix and support complex | expand

Message

Cezary Rojewski Aug. 18, 2021, 7:57 a.m. UTC
Existing skylake-driver supports very basic scenarios with limited range
of modules and their control. Attached changes first fix code as several
advanced configurations are 'mentioned' throughout the files but are not
actually functional. Follow up are changes adding missing support for
said configurations.

Cezary Rojewski (5):
  ASoC: Intel: kbl_da7219_max98927: Fix format selection for max98373
  ASoC: Intel: Skylake: Leave data as is when invoking TLV IPCs
  ASoC: Intel: Skylake: Fix module resource and format selection
  ASoC: Intel: Skylake: Fix module configuration for KPB and MIXER
  ASoC: Intel: Skylake: Select first entry for singular pipe config
    arrays

Gustaw Lewandowski (2):
  ASoC: Intel: Skylake: Fix passing loadable flag for module
  ASoC: Intel: Skylake: Simplify m_state for loadable modules

Kareem Shaik (1):
  ASoC: Intel: Skylake: Support multiple format configs

Pawel Harlozinski (1):
  ASoC: Intel: Skylake: Properly configure modules with generic
    extension

Piotr Maziarz (1):
  ASoC: Intel: Skylake: Select proper format for NHLT blob

Szymon Mielczarek (1):
  ASoC: Intel: Skylake: Support modules with generic extension

 include/uapi/sound/snd_sst_tokens.h          |   6 +-
 sound/soc/intel/boards/kbl_da7219_max98927.c |  55 +------
 sound/soc/intel/skylake/skl-messages.c       | 155 ++++++++++++-------
 sound/soc/intel/skylake/skl-pcm.c            |  25 ++-
 sound/soc/intel/skylake/skl-topology.c       | 155 +++++++++++--------
 sound/soc/intel/skylake/skl-topology.h       |  26 +++-
 6 files changed, 231 insertions(+), 191 deletions(-)

Comments

Lukasz Majczak Aug. 18, 2021, 11:08 a.m. UTC | #1
śr., 18 sie 2021 o 09:54 Cezary Rojewski <cezary.rojewski@intel.com> napisał(a):
>
> Existing skylake-driver supports very basic scenarios with limited range
> of modules and their control. Attached changes first fix code as several
> advanced configurations are 'mentioned' throughout the files but are not
> actually functional. Follow up are changes adding missing support for
> said configurations.
>
> Cezary Rojewski (5):
>   ASoC: Intel: kbl_da7219_max98927: Fix format selection for max98373
>   ASoC: Intel: Skylake: Leave data as is when invoking TLV IPCs
>   ASoC: Intel: Skylake: Fix module resource and format selection
>   ASoC: Intel: Skylake: Fix module configuration for KPB and MIXER
>   ASoC: Intel: Skylake: Select first entry for singular pipe config
>     arrays
>
> Gustaw Lewandowski (2):
>   ASoC: Intel: Skylake: Fix passing loadable flag for module
>   ASoC: Intel: Skylake: Simplify m_state for loadable modules
>
> Kareem Shaik (1):
>   ASoC: Intel: Skylake: Support multiple format configs
>
> Pawel Harlozinski (1):
>   ASoC: Intel: Skylake: Properly configure modules with generic
>     extension
>
> Piotr Maziarz (1):
>   ASoC: Intel: Skylake: Select proper format for NHLT blob
>
> Szymon Mielczarek (1):
>   ASoC: Intel: Skylake: Support modules with generic extension
>
>  include/uapi/sound/snd_sst_tokens.h          |   6 +-
>  sound/soc/intel/boards/kbl_da7219_max98927.c |  55 +------
>  sound/soc/intel/skylake/skl-messages.c       | 155 ++++++++++++-------
>  sound/soc/intel/skylake/skl-pcm.c            |  25 ++-
>  sound/soc/intel/skylake/skl-topology.c       | 155 +++++++++++--------
>  sound/soc/intel/skylake/skl-topology.h       |  26 +++-
>  6 files changed, 231 insertions(+), 191 deletions(-)
>
> --
> 2.25.1
>
I have checked playback/record with speakers/dmic/headset on the Atlas
chromebook - everything seems to work fine, so:

Tested-by: Lukasz Majczak <lma@semihalf.com>

Best regards,
Lukasz
Mark Brown Aug. 23, 2021, 5:37 p.m. UTC | #2
On Wed, 18 Aug 2021 09:57:31 +0200, Cezary Rojewski wrote:
> Existing skylake-driver supports very basic scenarios with limited range
> of modules and their control. Attached changes first fix code as several
> advanced configurations are 'mentioned' throughout the files but are not
> actually functional. Follow up are changes adding missing support for
> said configurations.
> 
> Cezary Rojewski (5):
>   ASoC: Intel: kbl_da7219_max98927: Fix format selection for max98373
>   ASoC: Intel: Skylake: Leave data as is when invoking TLV IPCs
>   ASoC: Intel: Skylake: Fix module resource and format selection
>   ASoC: Intel: Skylake: Fix module configuration for KPB and MIXER
>   ASoC: Intel: Skylake: Select first entry for singular pipe config
>     arrays
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[01/11] ASoC: Intel: kbl_da7219_max98927: Fix format selection for max98373
        commit: 6d41bbf2fd3615c56dbf2b67f6cbf9e83d14a2e2
[02/11] ASoC: Intel: Skylake: Leave data as is when invoking TLV IPCs
        commit: 126b3422adc80f29d2129db7f61e0113a8a526c6
[03/11] ASoC: Intel: Skylake: Select proper format for NHLT blob
        commit: 87b265260046d4e0ed3f150dac2184b9dbd4bf7c
[04/11] ASoC: Intel: Skylake: Fix module resource and format selection
        commit: e8b374b649afe756c2470e0e6668022e90bf8518
[05/11] ASoC: Intel: Skylake: Fix module configuration for KPB and MIXER
        commit: e4e0633bcadc950b4b4af06c7f1bb7f7e3e86321
[06/11] ASoC: Intel: Skylake: Fix passing loadable flag for module
        commit: c5ed9c547cba1dc1238c6e8a0c290fd62ee6e127
[07/11] ASoC: Intel: Skylake: Simplify m_state for loadable modules
        commit: e4e95d8291831fa63c32e00b59f544f0812dc0b6
[08/11] ASoC: Intel: Skylake: Support multiple format configs
        commit: a4ad42d28618eef83bee02e0a19af0d467bd9722
[09/11] ASoC: Intel: Skylake: Support modules with generic extension
        commit: db5a3f83a241a98d855e2cecc67869d06cb3e135
[10/11] ASoC: Intel: Skylake: Properly configure modules with generic extension
        commit: 5b27a71cbbfe6ffb554c87fde2ad9b71841478c2
[11/11] ASoC: Intel: Skylake: Select first entry for singular pipe config arrays
        commit: b947d2b467c0ea275ac3b468974ebe0dd0c0c3bd

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark