mbox series

[0/6] ASoC: SOF: Clean up the probe support

Message ID 20210916103211.1573-1-peter.ujfalusi@linux.intel.com (mailing list archive)
Headers show
Series ASoC: SOF: Clean up the probe support | expand

Message

Peter Ujfalusi Sept. 16, 2021, 10:32 a.m. UTC
Hi,

The probe debug feature of SOF can be used to extract streams of data from a
given point of a pipeline for analysis.

The support is implemented by using the ALSA/ASoC compress support for the
capture stream, but the code can not be used by/for a normal compressed data
stream. It is a debug feature.

Merge the probe implementation in the core (compress.c/h and probe.c/h) into
one file: sof-probes.c/h

Rename the Intel HDA specific probe implementation from hda-compressc.c to
hda-probes.c

We also need to add IPC logging support for the probes messages and drop the
unused references to SOF compress to have reasonably clean code.

Regards,
Peter
---
Peter Ujfalusi (5):
  ASoC: SOF: ipc: Add probe message logging to ipc_log_header()
  ASoC: SOF: pcm: Remove non existent CONFIG_SND_SOC_SOF_COMPRESS
    reference
  ASoC: SOF: probe: Merge and clean up the probe and compress files
  ASoC: SOF: Intel: Rename hda-compress.c to hda-probes.c
  ASoC: SOF: sof-probes: Correct the function names used for
    snd_soc_cdai_ops

Ranjani Sridharan (1):
  ASoC: SOF: compress: move and export sof_probe_compr_ops

 sound/soc/sof/Makefile                        |   3 +-
 sound/soc/sof/compress.c                      | 147 ---------
 sound/soc/sof/compress.h                      |  32 --
 sound/soc/sof/core.c                          |   2 +-
 sound/soc/sof/debug.c                         |   2 +-
 sound/soc/sof/intel/Makefile                  |   2 +-
 sound/soc/sof/intel/hda-dai.c                 |  16 +-
 .../intel/{hda-compress.c => hda-probes.c}    |   0
 sound/soc/sof/ipc.c                           |  23 ++
 sound/soc/sof/pcm.c                           |   6 +-
 sound/soc/sof/probe.h                         |  85 ------
 sound/soc/sof/sof-priv.h                      |   5 -
 sound/soc/sof/{probe.c => sof-probes.c}       | 280 +++++++++++-------
 sound/soc/sof/sof-probes.h                    |  38 +++
 14 files changed, 248 insertions(+), 393 deletions(-)
 delete mode 100644 sound/soc/sof/compress.c
 delete mode 100644 sound/soc/sof/compress.h
 rename sound/soc/sof/intel/{hda-compress.c => hda-probes.c} (100%)
 delete mode 100644 sound/soc/sof/probe.h
 rename sound/soc/sof/{probe.c => sof-probes.c} (52%)
 create mode 100644 sound/soc/sof/sof-probes.h

Comments

Mark Brown Sept. 16, 2021, 3:14 p.m. UTC | #1
On Thu, 16 Sep 2021 13:32:05 +0300, Peter Ujfalusi wrote:
> The probe debug feature of SOF can be used to extract streams of data from a
> given point of a pipeline for analysis.
> 
> The support is implemented by using the ALSA/ASoC compress support for the
> capture stream, but the code can not be used by/for a normal compressed data
> stream. It is a debug feature.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/6] ASoC: SOF: ipc: Add probe message logging to ipc_log_header()
      commit: 4ba344dc792fc665c6e95d08ac13ba30f908bbf7
[2/6] ASoC: SOF: pcm: Remove non existent CONFIG_SND_SOC_SOF_COMPRESS reference
      commit: 8a720724589e8d782ad3ad4e0f08977de00bea5f
[3/6] ASoC: SOF: compress: move and export sof_probe_compr_ops
      commit: 2dc51106ccc6c64b9ea68ddd9ec533f7e67e081d
[4/6] ASoC: SOF: probe: Merge and clean up the probe and compress files
      commit: 7bbdda8009001d66611314e67a3f498d4b412c64
[5/6] ASoC: SOF: Intel: Rename hda-compress.c to hda-probes.c
      commit: f95b4152ad75274734ed23d0546d24f5e7fc9c3c
[6/6] ASoC: SOF: sof-probes: Correct the function names used for snd_soc_cdai_ops
      commit: 49efed50588547b0f13897b6fc69f155c2e2af50

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark