mbox series

[0/2] ASoC: meson: axg: fix TDM channel order sync

Message ID 20211020114217.133153-1-jbrunet@baylibre.com (mailing list archive)
Headers show
Series ASoC: meson: axg: fix TDM channel order sync | expand

Message

Jerome Brunet Oct. 20, 2021, 11:42 a.m. UTC 
On the Amlogic AXG series, the TODDR FIFO may get out of sync with the TDM
decoder if the decoder is started before the FIFO. The channel appears
shifted in memory in an unpredictable way.

To fix this, the trick is to start the FIFO before the TDM decoder. This
way the FIFO is already waiting when the 1st channel is produced and it is
correctly placed in memory.

Jerome Brunet (2):
  ASoC: meson: axg-card: make links nonatomic
  ASoC: meson: axg-tdm-interface: manage formatters in trigger

 sound/soc/meson/axg-card.c          |  1 +
 sound/soc/meson/axg-tdm-interface.c | 26 +++++++++++++++++++++-----
 2 files changed, 22 insertions(+), 5 deletions(-)

Comments

Mark Brown Oct. 23, 2021, 1:34 p.m. UTC | #1 
On Wed, 20 Oct 2021 13:42:15 +0200, Jerome Brunet wrote:
> On the Amlogic AXG series, the TODDR FIFO may get out of sync with the TDM
> decoder if the decoder is started before the FIFO. The channel appears
> shifted in memory in an unpredictable way.
> 
> To fix this, the trick is to start the FIFO before the TDM decoder. This
> way the FIFO is already waiting when the 1st channel is produced and it is
> correctly placed in memory.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: meson: axg-card: make links nonatomic
      commit: e138233e56e9829e65b6293887063a1a3ccb2d68
[2/2] ASoC: meson: axg-tdm-interface: manage formatters in trigger
      commit: bf5e4887eeddb48480568466536aa08ec7f179a5

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark