| Message ID | 20221111113547.100442-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | ASoC: dt-bindings: Rework Qualcomm APR/GPR Sound nodes for SM8450 | expand |
On 11/11/2022 12:35, Krzysztof Kozlowski wrote: > Adding sound support for Qualcomm SM8450 SoC (and later for SC8280XP) brought > some changes to APR/GPR services bindings. These bindings are part of > qcom,apr.yaml: > > apr-or-gpr-device-node <- qcom,apr.yaml > apr-gpr-service@[0-9] <- qcom,apr.yaml > service-specific-components <- /schemas/sound/qcom,q6*.yaml > > The schema for services (apr-gpr-service@[0-9]) already grows considerably and > is still quite not specific. It allows several incorrect combinations, like > adding a clock-controller to a APM device. Restricting it would complicate the > schema even more. Bringing new support for sound on Qualcomm SM8450 and > SC8280XP SoC would grow it as well. > > Refactor the bindings before extending them for Qualcomm SM8450 SoC. > I forgot to mention that DTS in progress is available here: https://github.com/krzk/linux/blob/wip/sm8450/arch/arm64/boot/dts/qcom/sm8450-hdk.dts#L459 https://github.com/krzk/linux/blob/wip/sm8450/arch/arm64/boot/dts/qcom/sm8450.dtsi#L2345 Best regards, Krzysztof
On 11/11/2022 11:35, Krzysztof Kozlowski wrote: > Adding sound support for Qualcomm SM8450 SoC (and later for SC8280XP) brought > some changes to APR/GPR services bindings. These bindings are part of > qcom,apr.yaml: > > apr-or-gpr-device-node <- qcom,apr.yaml > apr-gpr-service@[0-9] <- qcom,apr.yaml > service-specific-components <- /schemas/sound/qcom,q6*.yaml > > The schema for services (apr-gpr-service@[0-9]) already grows considerably and > is still quite not specific. It allows several incorrect combinations, like > adding a clock-controller to a APM device. Restricting it would complicate the > schema even more. Bringing new support for sound on Qualcomm SM8450 and > SC8280XP SoC would grow it as well. Why would this grow? All the dsp services are static and they will not change per SoC unless there is a total firmware change in DSP. > > Refactor the bindings before extending them for Qualcomm SM8450 SoC. I dont understand this bit, what is SoC audio support to do with DSP bindings. DSP bindings should be totally independent of this. > --srini > Best regards, > Krzysztof > > Krzysztof Kozlowski (10): > ASoC: dt-bindings: qcom,apr: Add GLINK channel name for SM8450 > ASoC: dt-bindings: qcom,apr: Split services to shared schema > ASoC: dt-bindings: qcom,q6afe: Split to separate schema > ASoC: dt-bindings: qcom,q6apm: Split to separate schema > ASoC: dt-bindings: qcom,q6adm: Split to separate schema > ASoC: dt-bindings: qcom,q6asm: Split to separate schema > ASoC: dt-bindings: qcom,q6prm: Split to separate schema > ASoC: dt-bindings: qcom,q6core: Split to separate schema > ASoC: dt-bindings: qcom,q6apm-lpass-dais: Split to separate schema > ASoC: dt-bindings: qcom,q6apm: Add SM8450 bedais node > > .../bindings/soc/qcom/qcom,apr-services.yaml | 54 ++++++++ > .../bindings/soc/qcom/qcom,apr.yaml | 119 ++---------------- > .../bindings/sound/qcom,q6adm-routing.yaml | 22 +--- > .../devicetree/bindings/sound/qcom,q6adm.yaml | 51 ++++++++ > .../devicetree/bindings/sound/qcom,q6afe.yaml | 69 ++++++++++ > .../bindings/sound/qcom,q6apm-dai.yaml | 19 +-- > .../bindings/sound/qcom,q6apm-lpass-dais.yaml | 32 +++++ > .../devicetree/bindings/sound/qcom,q6apm.yaml | 67 ++++++++++ > .../bindings/sound/qcom,q6asm-dais.yaml | 48 +++---- > .../devicetree/bindings/sound/qcom,q6asm.yaml | 68 ++++++++++ > .../bindings/sound/qcom,q6core.yaml | 39 ++++++ > .../sound/qcom,q6dsp-lpass-clocks.yaml | 40 +----- > .../sound/qcom,q6dsp-lpass-ports.yaml | 57 ++------- > .../devicetree/bindings/sound/qcom,q6prm.yaml | 50 ++++++++ > MAINTAINERS | 2 +- > 15 files changed, 477 insertions(+), 260 deletions(-) > create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,apr-services.yaml > create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6adm.yaml > create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6afe.yaml > create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml > create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6apm.yaml > create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6asm.yaml > create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6core.yaml > create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6prm.yaml >
On 11/11/2022 17:15, Srinivas Kandagatla wrote: > > > On 11/11/2022 11:35, Krzysztof Kozlowski wrote: >> Adding sound support for Qualcomm SM8450 SoC (and later for SC8280XP) brought >> some changes to APR/GPR services bindings. These bindings are part of >> qcom,apr.yaml: >> >> apr-or-gpr-device-node <- qcom,apr.yaml >> apr-gpr-service@[0-9] <- qcom,apr.yaml >> service-specific-components <- /schemas/sound/qcom,q6*.yaml >> >> The schema for services (apr-gpr-service@[0-9]) already grows considerably and >> is still quite not specific. It allows several incorrect combinations, like >> adding a clock-controller to a APM device. Restricting it would complicate the >> schema even more. Bringing new support for sound on Qualcomm SM8450 and >> SC8280XP SoC would grow it as well. > > Why would this grow? All the dsp services are static and they will not > change per SoC unless there is a total firmware change in DSP. They grow now with SM8450 which requires changes there. Otherwise DTS does not pass with current bindings. The bindings before my fixing in 2022 were really incomplete. Now they are complete, but: 1. Not for SM8450 - this will bring new things, 2. Very unspecific as they allow multiple invalid configurations. > >> >> Refactor the bindings before extending them for Qualcomm SM8450 SoC. > > I dont understand this bit, what is SoC audio support to do with DSP > bindings. DSP bindings should be totally independent of this. APR/GPR bindings are for SoC audio, so while adding SoC audio the first are affected. If you went through the commits here, you would notice the changes. Best regards, Krzysztof
On 14/11/2022 07:48, Krzysztof Kozlowski wrote: > On 11/11/2022 17:15, Srinivas Kandagatla wrote: >> >> >> On 11/11/2022 11:35, Krzysztof Kozlowski wrote: >>> Adding sound support for Qualcomm SM8450 SoC (and later for SC8280XP) brought >>> some changes to APR/GPR services bindings. These bindings are part of >>> qcom,apr.yaml: >>> >>> apr-or-gpr-device-node <- qcom,apr.yaml >>> apr-gpr-service@[0-9] <- qcom,apr.yaml >>> service-specific-components <- /schemas/sound/qcom,q6*.yaml >>> >>> The schema for services (apr-gpr-service@[0-9]) already grows considerably and >>> is still quite not specific. It allows several incorrect combinations, like >>> adding a clock-controller to a APM device. Restricting it would complicate the >>> schema even more. Bringing new support for sound on Qualcomm SM8450 and >>> SC8280XP SoC would grow it as well. >> >> Why would this grow? All the dsp services are static and they will not >> change per SoC unless there is a total firmware change in DSP. > > They grow now with SM8450 which requires changes there. Otherwise DTS > does not pass with current bindings. The bindings before my fixing in > 2022 were really incomplete. Now they are complete, but: > 1. Not for SM8450 - this will bring new things, > 2. Very unspecific as they allow multiple invalid configurations. > Okay, I looked at all the patches, they are fine as it is, the confusion part is the subject and comments which are misleading and trying to say that these are specific to SM8450 or SC8280XP. Infact this is not true, none of these changes are specific to any SoC, they are part of AudioReach. --srini >> >>> >>> Refactor the bindings before extending them for Qualcomm SM8450 SoC. >> >> I dont understand this bit, what is SoC audio support to do with DSP >> bindings. DSP bindings should be totally independent of this. > > APR/GPR bindings are for SoC audio, so while adding SoC audio the first > are affected. If you went through the commits here, you would notice the > changes. > > Best regards, > Krzysztof >
On 14/11/2022 12:50, Srinivas Kandagatla wrote: > > > On 14/11/2022 07:48, Krzysztof Kozlowski wrote: >> On 11/11/2022 17:15, Srinivas Kandagatla wrote: >>> >>> >>> On 11/11/2022 11:35, Krzysztof Kozlowski wrote: >>>> Adding sound support for Qualcomm SM8450 SoC (and later for SC8280XP) brought >>>> some changes to APR/GPR services bindings. These bindings are part of >>>> qcom,apr.yaml: >>>> >>>> apr-or-gpr-device-node <- qcom,apr.yaml >>>> apr-gpr-service@[0-9] <- qcom,apr.yaml >>>> service-specific-components <- /schemas/sound/qcom,q6*.yaml >>>> >>>> The schema for services (apr-gpr-service@[0-9]) already grows considerably and >>>> is still quite not specific. It allows several incorrect combinations, like >>>> adding a clock-controller to a APM device. Restricting it would complicate the >>>> schema even more. Bringing new support for sound on Qualcomm SM8450 and >>>> SC8280XP SoC would grow it as well. >>> >>> Why would this grow? All the dsp services are static and they will not >>> change per SoC unless there is a total firmware change in DSP. >> >> They grow now with SM8450 which requires changes there. Otherwise DTS >> does not pass with current bindings. The bindings before my fixing in >> 2022 were really incomplete. Now they are complete, but: >> 1. Not for SM8450 - this will bring new things, >> 2. Very unspecific as they allow multiple invalid configurations. >> > Okay, I looked at all the patches, they are fine as it is, the confusion > part is the subject and comments which are misleading and trying to say > that these are specific to SM8450 or SC8280XP. Infact this is not true, > none of these changes are specific to any SoC, they are part of AudioReach. They are part of bringing audio on SM8450, at the end we all are SoC centric... we do not bring support for AudioReach just for itself, right? We bring it because we want to have something working on SM8450 and further... Best regards, Krzysztof
Adding sound support for Qualcomm SM8450 SoC (and later for SC8280XP) brought some changes to APR/GPR services bindings. These bindings are part of qcom,apr.yaml: apr-or-gpr-device-node <- qcom,apr.yaml apr-gpr-service@[0-9] <- qcom,apr.yaml service-specific-components <- /schemas/sound/qcom,q6*.yaml The schema for services (apr-gpr-service@[0-9]) already grows considerably and is still quite not specific. It allows several incorrect combinations, like adding a clock-controller to a APM device. Restricting it would complicate the schema even more. Bringing new support for sound on Qualcomm SM8450 and SC8280XP SoC would grow it as well. Refactor the bindings before extending them for Qualcomm SM8450 SoC. Best regards, Krzysztof Krzysztof Kozlowski (10): ASoC: dt-bindings: qcom,apr: Add GLINK channel name for SM8450 ASoC: dt-bindings: qcom,apr: Split services to shared schema ASoC: dt-bindings: qcom,q6afe: Split to separate schema ASoC: dt-bindings: qcom,q6apm: Split to separate schema ASoC: dt-bindings: qcom,q6adm: Split to separate schema ASoC: dt-bindings: qcom,q6asm: Split to separate schema ASoC: dt-bindings: qcom,q6prm: Split to separate schema ASoC: dt-bindings: qcom,q6core: Split to separate schema ASoC: dt-bindings: qcom,q6apm-lpass-dais: Split to separate schema ASoC: dt-bindings: qcom,q6apm: Add SM8450 bedais node .../bindings/soc/qcom/qcom,apr-services.yaml | 54 ++++++++ .../bindings/soc/qcom/qcom,apr.yaml | 119 ++---------------- .../bindings/sound/qcom,q6adm-routing.yaml | 22 +--- .../devicetree/bindings/sound/qcom,q6adm.yaml | 51 ++++++++ .../devicetree/bindings/sound/qcom,q6afe.yaml | 69 ++++++++++ .../bindings/sound/qcom,q6apm-dai.yaml | 19 +-- .../bindings/sound/qcom,q6apm-lpass-dais.yaml | 32 +++++ .../devicetree/bindings/sound/qcom,q6apm.yaml | 67 ++++++++++ .../bindings/sound/qcom,q6asm-dais.yaml | 48 +++---- .../devicetree/bindings/sound/qcom,q6asm.yaml | 68 ++++++++++ .../bindings/sound/qcom,q6core.yaml | 39 ++++++ .../sound/qcom,q6dsp-lpass-clocks.yaml | 40 +----- .../sound/qcom,q6dsp-lpass-ports.yaml | 57 ++------- .../devicetree/bindings/sound/qcom,q6prm.yaml | 50 ++++++++ MAINTAINERS | 2 +- 15 files changed, 477 insertions(+), 260 deletions(-) create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,apr-services.yaml create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6adm.yaml create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6afe.yaml create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6apm.yaml create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6asm.yaml create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6core.yaml create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6prm.yaml