mbox series

[0/3] ALSA: usb-audio: Fix a few implicit fb sync issues

Message ID 20230102170759.29610-1-tiwai@suse.de (mailing list archive)
Headers show
Series ALSA: usb-audio: Fix a few implicit fb sync issues | expand

Message

Takashi Iwai Jan. 2, 2023, 5:07 p.m. UTC 
Hi,

this is a series of patches for addressing the remaining problem with
the implicit fb sync.  The first one is to cover the left over EP run
state at re-configuring PCM.  The second one is a workaround for a
regression with the hw constraints, and the last one is the
refactoring and fix for the multiple EPs assigned in the format list.


Takashi

===

Takashi Iwai (3):
  ALSA: usb-audio: Make sure to stop endpoints before closing EPs
  ALSA: usb-audio: Relax hw constraints for implicit fb sync
  ALSA: usb-audio: More refactoring of hw constraint rules

 sound/usb/pcm.c | 217 ++++++++++++++++++++++++++++++------------------
 1 file changed, 134 insertions(+), 83 deletions(-)

Comments

Geraldo Nascimento Jan. 2, 2023, 9:15 p.m. UTC | #1 
On Mon, Jan 02, 2023 at 06:07:56PM +0100, Takashi Iwai wrote:
> Hi,

Hi Takashi,

> 
> this is a series of patches for addressing the remaining problem with
> the implicit fb sync.  The first one is to cover the left over EP run
> state at re-configuring PCM.  The second one is a workaround for a
> regression with the hw constraints, and the last one is the
> refactoring and fix for the multiple EPs assigned in the format list.
>

Perhaps it would be wise to include tag
"Reported-by: Ruud van Asseldonk <ruud@veniogames.com>"
in the relevants commits tied to this series, as Ruud did share a small
reproducing C program and went so far as to bisect the regression.

Thanks,
Geraldo Nascimento

> 
> Takashi
> 
> ===
> 
> Takashi Iwai (3):
>   ALSA: usb-audio: Make sure to stop endpoints before closing EPs
>   ALSA: usb-audio: Relax hw constraints for implicit fb sync
>   ALSA: usb-audio: More refactoring of hw constraint rules
> 
>  sound/usb/pcm.c | 217 ++++++++++++++++++++++++++++++------------------
>  1 file changed, 134 insertions(+), 83 deletions(-)
> 
> -- 
> 2.35.3
>
Takashi Iwai Jan. 3, 2023, 2:49 p.m. UTC | #2 
On Mon, 02 Jan 2023 22:15:25 +0100,
Geraldo Nascimento wrote:
> 
> On Mon, Jan 02, 2023 at 06:07:56PM +0100, Takashi Iwai wrote:
> > Hi,
> 
> Hi Takashi,
> 
> > 
> > this is a series of patches for addressing the remaining problem with
> > the implicit fb sync.  The first one is to cover the left over EP run
> > state at re-configuring PCM.  The second one is a workaround for a
> > regression with the hw constraints, and the last one is the
> > refactoring and fix for the multiple EPs assigned in the format list.
> >
> 
> Perhaps it would be wise to include tag
> "Reported-by: Ruud van Asseldonk <ruud@veniogames.com>"
> in the relevants commits tied to this series, as Ruud did share a small
> reproducing C program and went so far as to bisect the regression.

Yes, it makes sense.


Takashi