mbox series

[v2,00/10] Refactor acp legacy driver and add

Message ID 20230626135515.1252063-1-Syed.SabaKareem@amd.com (mailing list archive)
Headers show
Series Refactor acp legacy driver and add | expand

Message

Saba Kareem, Syed June 26, 2023, 1:55 p.m. UTC
This patch series to refactor acp leagacy driver and add pm ops
support for rembrandt platforms.

Changes since V1
   - Fix below kernel test robot errors and warnings

	- ld.lld: error: undefined symbol: acp_enable_interrupts
	- referenced by acp-renoir.c:191 (sound/soc/amd/acp/acp-renoir.c:191)
	- ld.lld: error: undefined symbol: acp_disable_interrupts
	- sound/soc/amd/acp/acp-renoir.o:(renoir_audio_remove) in archive vmlinux.a
 
	- All warnings (new ones prefixed by >>):
	- sound/soc/amd/acp/acp-rembrandt.c:169:5: warning: no previous
	- prototype for 'acp6x_master_clock_generate' [-Wmissing-prototypes]
	- 169 | int acp6x_master_clock_generate(struct device *dev)

Syed Saba Kareem (10):
  ASoC: amd: acp: refactor the acp init and de-init sequence
  ASoC: amd: acp: add acp i2s master clock generation for rembrandt
    platform
  ASoC: amd: acp: remove the redundant acp enable/disable interrupts
    functions
  ASoC: amd: acp: store platform device reference created in pci probe
    call
  ASoC: amd: acp: add pm ops support for acp pci driver
  ASoC: amd: acp: store xfer_resolution of the stream
  ASoC: amd: acp: export config_acp_dma() and config_pte_for_stream()
    symbols
  ASoC: amd: acp: store the pdm stream channel mask
  ASoC: amd: acp: move pdm macros to common header file
  ASoC: amd: acp: add pm ops support for rembrandt platform

 sound/soc/amd/acp/Kconfig             |   5 +
 sound/soc/amd/acp/Makefile            |   2 +
 sound/soc/amd/acp/acp-i2s.c           |   2 +
 sound/soc/amd/acp/acp-legacy-common.c | 347 ++++++++++++++++++++++++++
 sound/soc/amd/acp/acp-pci.c           |  57 ++++-
 sound/soc/amd/acp/acp-pdm.c           |  13 +-
 sound/soc/amd/acp/acp-platform.c      |   6 +-
 sound/soc/amd/acp/acp-rembrandt.c     | 186 +++++---------
 sound/soc/amd/acp/acp-renoir.c        | 115 +--------
 sound/soc/amd/acp/amd.h               |  51 ++++
 10 files changed, 531 insertions(+), 253 deletions(-)
 create mode 100644 sound/soc/amd/acp/acp-legacy-common.c

Comments

Mark Brown July 12, 2023, 11:46 a.m. UTC | #1
On Mon, 26 Jun 2023 19:25:04 +0530, Syed Saba Kareem wrote:
> This patch series to refactor acp leagacy driver and add pm ops
> support for rembrandt platforms.
> 
> Changes since V1
>    - Fix below kernel test robot errors and warnings
> 
> 	- ld.lld: error: undefined symbol: acp_enable_interrupts
> 	- referenced by acp-renoir.c:191 (sound/soc/amd/acp/acp-renoir.c:191)
> 	- ld.lld: error: undefined symbol: acp_disable_interrupts
> 	- sound/soc/amd/acp/acp-renoir.o:(renoir_audio_remove) in archive vmlinux.a
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[01/10] ASoC: amd: acp: refactor the acp init and de-init sequence
        commit: e61b415515d3db57dce3af3e4a0441f08d8d8f15
[02/10] ASoC: amd: acp: add acp i2s master clock generation for rembrandt platform
        commit: 7ad6fb9dd1ca63f9f36e413036f36f075cdaec4a
[03/10] ASoC: amd: acp: remove the redundant acp enable/disable interrupts functions
        commit: fc11d3266dc7ed386efe91c20d09780bbded1f03
[04/10] ASoC: amd: acp: store platform device reference created in pci probe call
        commit: 7a83903022dc3bd5214f6bdde8132c66015ab538
[05/10] ASoC: amd: acp: add pm ops support for acp pci driver
        commit: 088a40980efbc2c449b72f0f2c7ebd82f71d08e2
[06/10] ASoC: amd: acp: store xfer_resolution of the stream
        commit: c8786ac7bb374276b1c2b545b4a6be3b230be7cb
[07/10] ASoC: amd: acp: export config_acp_dma() and config_pte_for_stream() symbols
        commit: a8d1316a264f36c2ffe798e42d6b415dc377851e
[08/10] ASoC: amd: acp: store the pdm stream channel mask
        commit: 7373e6bee60cdac36a134897164885b2257a02ac
[09/10] ASoC: amd: acp: move pdm macros to common header file
        commit: e3a96e441e05bbf599ce70c2a03e7acd55b275ee
[10/10] ASoC: amd: acp: add pm ops support for rembrandt platform
        commit: 5debf4ae138c81321832d41203483696cac1c580

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark