| Message ID | 20230731103419.2536036-1-brent.lu@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Intel: sof_rt5682: remove quirk flag | expand |
On Mon, Jul 31, 2023 at 06:34:18PM +0800, Brent Lu wrote: > We add a helper function to detect amplifier number according to device instance > in ACPI table so the SOF_MAX98390_TWEETER_SPEAKER_PRESENT flag and a dmi quirk > for 4-amplifier configuration could be safely removed. > > Also refactor the max_98390_hw_params() function to use an array to handle the > TDM parameter. > > Amplifier number detection and TDM parameter are tested on two Chromebooks. One > with 2 MAX98390 and one with 4 MAX98390 amplifier. Please don't send cover letters for single patches, if there is anything that needs saying put it in the changelog of the patch or after the --- if it's administrative stuff. This reduces mail volume and ensures that any important information is recorded in the changelog rather than being lost.
On Mon, 31 Jul 2023 18:34:18 +0800, Brent Lu wrote: > We add a helper function to detect amplifier number according to device instance > in ACPI table so the SOF_MAX98390_TWEETER_SPEAKER_PRESENT flag and a dmi quirk > for 4-amplifier configuration could be safely removed. > > Also refactor the max_98390_hw_params() function to use an array to handle the > TDM parameter. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: Intel: maxim-common: get codec number from ACPI table commit: 36eb986845a8ca87c1f7f91976fad53ee249ae8c All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
We add a helper function to detect amplifier number according to device instance in ACPI table so the SOF_MAX98390_TWEETER_SPEAKER_PRESENT flag and a dmi quirk for 4-amplifier configuration could be safely removed. Also refactor the max_98390_hw_params() function to use an array to handle the TDM parameter. Amplifier number detection and TDM parameter are tested on two Chromebooks. One with 2 MAX98390 and one with 4 MAX98390 amplifier. V2 Changes: - fix some typos in cover letter - use for_each_acpi_dev_match() macro to simplify the codec - use 'unsign int' for codec number variable V3 Changes: - replace pr_err() with dev_err() V4 Changes: - merge two patches to avoid build break - remove redundant assignment in max_98390_hw_params() - refactor MAX_98390_DEVX_NAME macros Brent Lu (2): ASoC: Intel: maxim-common: get codec number from ACPI ASoC: Intel: sof_rt5682: remove SOF_MAX98390_TWEETER_SPEAKER_PRESENT flag Brent Lu (1): ASoC: Intel: maxim-common: get codec number from ACPI table sound/soc/intel/boards/sof_maxim_common.c | 170 +++++++++++++--------- sound/soc/intel/boards/sof_maxim_common.h | 21 ++- sound/soc/intel/boards/sof_rt5682.c | 37 +---- 3 files changed, 111 insertions(+), 117 deletions(-)