mbox series

[0/8] ASoC/SOF/Intel/AMD: cleanups for GCC11 -fanalyzer checks

Message ID 20230731213748.440285-1-pierre-louis.bossart@linux.intel.com (mailing list archive)
Headers show
Series ASoC/SOF/Intel/AMD: cleanups for GCC11 -fanalyzer checks | expand

Message

Pierre-Louis Bossart July 31, 2023, 9:37 p.m. UTC
GCC11 provides an '-fanalyzer' static analysis option which does not
provide too many false-positives. This patch cleans-up known
problematic code paths to help enable this capability in CI. We've
used this for about a month already.

Pierre-Louis Bossart (8):
  ASoC: SOF: sof-client-probes-ipc4: add checks to prevent static
    analysis warnings
  ASoC: SOF: ipc3: add checks to prevent static analysis warnings
  ASoC: SOF: topology: simplify code to prevent static analysis warnings
  ASoC: SOF: imx: remove error checks on NULL ipc
  ASoC: SOF: mediatek: remove error checks on NULL ipc
  ASoC: Intel: bdw_rt286: add checks to avoid static analysis warnings
  ASoC: Intel: atom: remove static analysis false positive
  ASoC: amd: acp5x-mach:add checks to avoid static analysis warnings

 include/linux/firmware/imx/dsp.h               |  6 ------
 include/linux/firmware/mediatek/mtk-adsp-ipc.h |  6 ------
 sound/soc/amd/vangogh/acp5x-mach.c             |  3 +++
 sound/soc/intel/atom/sst/sst_stream.c          | 13 +++++++------
 sound/soc/intel/boards/bdw_rt286.c             |  6 ++++++
 sound/soc/sof/ipc3.c                           |  2 +-
 sound/soc/sof/sof-client-probes-ipc4.c         |  9 +++++++++
 sound/soc/sof/topology.c                       |  5 +++--
 8 files changed, 29 insertions(+), 21 deletions(-)

Comments

Mark Brown Aug. 1, 2023, 12:51 p.m. UTC | #1
On Mon, 31 Jul 2023 16:37:40 -0500, Pierre-Louis Bossart wrote:
> GCC11 provides an '-fanalyzer' static analysis option which does not
> provide too many false-positives. This patch cleans-up known
> problematic code paths to help enable this capability in CI. We've
> used this for about a month already.
> 
> Pierre-Louis Bossart (8):
>   ASoC: SOF: sof-client-probes-ipc4: add checks to prevent static
>     analysis warnings
>   ASoC: SOF: ipc3: add checks to prevent static analysis warnings
>   ASoC: SOF: topology: simplify code to prevent static analysis warnings
>   ASoC: SOF: imx: remove error checks on NULL ipc
>   ASoC: SOF: mediatek: remove error checks on NULL ipc
>   ASoC: Intel: bdw_rt286: add checks to avoid static analysis warnings
>   ASoC: Intel: atom: remove static analysis false positive
>   ASoC: amd: acp5x-mach:add checks to avoid static analysis warnings
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/8] ASoC: SOF: sof-client-probes-ipc4: add checks to prevent static analysis warnings
      commit: 390e7066db29b985c5142513955797c1166b623a
[2/8] ASoC: SOF: ipc3: add checks to prevent static analysis warnings
      commit: e44222c213678d6ef646d72cbb9a2eda52f6dc22
[3/8] ASoC: SOF: topology: simplify code to prevent static analysis warnings
      commit: 55cb3dc271d81f1982c949a2ac483a6daf613b92
[4/8] ASoC: SOF: imx: remove error checks on NULL ipc
      commit: e302f8d9f799af57a61a7456451c28f2647e9751
[5/8] ASoC: SOF: mediatek: remove error checks on NULL ipc
      commit: 8cf5286216dcfb942f0e4d7c23ebe06c2ebc1bed
[6/8] ASoC: Intel: bdw_rt286: add checks to avoid static analysis warnings
      commit: 64778b022e629b8ffa97d23a9adbf670aa3bb1d8
[7/8] ASoC: Intel: atom: remove static analysis false positive
      commit: 71d76768fbe72aa70dd61d5714a5579dc4ca61cb
[8/8] ASoC: amd: acp5x-mach:add checks to avoid static analysis warnings
      commit: 871861f6ad6d43b49caade3f42b9d40ca1413e79

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark