| Message ID | 20231123094749.20462-1-johan+linaro@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | ASoC: codecs: wsa883x: fix pops and clicks | expand |
On Thu, Nov 23, 2023 at 10:47:47AM +0100, Johan Hovold wrote: > This is a backport of commits > > 0220575e65a ("ASoC: soc-dai: add flag to mute and unmute stream during trigger") > 805ce81826c8 ("ASoC: codecs: wsa883x: make use of new mute_unmute_on_trigger flag") > > which specifically fix a loud crackling noise when starting a stream on > the Lenovo ThinkPad X13s. > > These backports should apply to any stable tree which already has commit > 3efcb471f871 ("ASoC: soc-pcm.c: Make sure DAI parameters cleared if the > DAI becomes inactive") backported (e.g. 6.6.2 and 6.5.12). > > Note that the interaction of these commits resulted in a bad merge in > mainline which is fixed up here: > > https://lore.kernel.org/lkml/20231123091815.21933-1-johan+linaro@kernel.org/ Thanks, now queued up. greg k-h
This is a backport of commits 0220575e65a ("ASoC: soc-dai: add flag to mute and unmute stream during trigger") 805ce81826c8 ("ASoC: codecs: wsa883x: make use of new mute_unmute_on_trigger flag") which specifically fix a loud crackling noise when starting a stream on the Lenovo ThinkPad X13s. These backports should apply to any stable tree which already has commit 3efcb471f871 ("ASoC: soc-pcm.c: Make sure DAI parameters cleared if the DAI becomes inactive") backported (e.g. 6.6.2 and 6.5.12). Note that the interaction of these commits resulted in a bad merge in mainline which is fixed up here: https://lore.kernel.org/lkml/20231123091815.21933-1-johan+linaro@kernel.org/ Johan Srinivas Kandagatla (2): ASoC: soc-dai: add flag to mute and unmute stream during trigger ASoC: codecs: wsa883x: make use of new mute_unmute_on_trigger flag include/sound/soc-dai.h | 1 + sound/soc/codecs/wsa883x.c | 7 +------ sound/soc/soc-dai.c | 7 +++++++ sound/soc/soc-pcm.c | 12 ++++++++---- 4 files changed, 17 insertions(+), 10 deletions(-)