[v3,0/2] ASoC: SOF: amd: Skip IRAM/DRAM size modification for Steam Deck OLED

Message

Cristian Ciocaltea Feb. 20, 2024, 8:16 p.m. UTC

This patch series restores audio support on Valve's Steam Deck OLED model, which
broke after the recent introduction of ACP/PSP communication for IRAM/DRAM fence
register programming.

Changes in v3:
- Drop a patch file that was sent by mistake in v2

Changes in v2:
- Rebased onto next-20240219
- Added new patch introducing struct acp_quirk_entry
- Reworked v1 patch to make use of a dedicated quirk
- Link to v1:
  https://lore.kernel.org/lkml/[e-mail]/

Cristian Ciocaltea (2):
  ASoC: SOF: amd: Move signed_fw_image to struct acp_quirk_entry
  ASoC: SOF: amd: Skip IRAM/DRAM size modification for Steam Deck OLED

 sound/soc/sof/amd/acp-loader.c |  2 +-
 sound/soc/sof/amd/acp.c        | 50 ++++++++++++++++++----------------
 sound/soc/sof/amd/acp.h        |  7 ++++-
 sound/soc/sof/amd/vangogh.c    |  9 ++++--
 4 files changed, 41 insertions(+), 27 deletions(-)

Comments

Cristian Ciocaltea March 4, 2024, 7:11 p.m. UTC | #1

On 2/20/24 22:16, Cristian Ciocaltea wrote:
> This patch series restores audio support on Valve's Steam Deck OLED model, which
> broke after the recent introduction of ACP/PSP communication for IRAM/DRAM fence
> register programming.

Hi Mark,

Could we get this queued for merging as v6.9 material?

Thanks,
Cristian

Mark Brown March 4, 2024, 7:12 p.m. UTC | #2

On Mon, Mar 04, 2024 at 09:11:06PM +0200, Cristian Ciocaltea wrote:

> Could we get this queued for merging as v6.9 material?

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.

Mark Brown March 15, 2024, 10:04 p.m. UTC | #3

On Tue, 20 Feb 2024 22:16:02 +0200, Cristian Ciocaltea wrote:
> This patch series restores audio support on Valve's Steam Deck OLED model, which
> broke after the recent introduction of ACP/PSP communication for IRAM/DRAM fence
> register programming.
> 
> Changes in v3:
> - Drop a patch file that was sent by mistake in v2
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: SOF: amd: Move signed_fw_image to struct acp_quirk_entry
      commit: 33c3d813330718c403a60d220f03fbece0f4fb5c
[2/2] ASoC: SOF: amd: Skip IRAM/DRAM size modification for Steam Deck OLED
      commit: 094d11768f740f11483dad4efcd9bbcffa4ce146

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark