mbox series

[v2,0/5] Add support for jack detection to codec present in A64 SoC

Message ID 20240223015219.3618111-1-megi@xff.cz (mailing list archive)
Headers show
Series Add support for jack detection to codec present in A64 SoC | expand

Message

Ondřej Jirman Feb. 23, 2024, 1:52 a.m. UTC
From: Ondrej Jirman <megi@xff.cz>

This series adds support for jack detection to this codec. I used
and tested this on Pinephone. It works quite nicely. I tested it
against Android headset mic button resistor specification.

The patches are improved and debugged version of the original
ones from Arnaud Ferraris and Samuel Holland, imrpoved to better
handle headset button presses and with more robust plug-in/out
event debouncing.

Please take a look. :)

v2:
- use set_jack/get_jack_type
- get rid of some custom poking inside card internals to figure
  out what kind of jack port we should setup the codec for
- read jack-type from OF as suggested here: 
  https://elixir.bootlin.com/linux/latest/source/sound/soc/soc-component.c#L288
- add DT bindings

Thank you very much,
	Ondřej Jirman

Arnaud Ferraris (2):
  ASoC: sun50i-codec-analog: Enable jack detection on startup
  ASoC: sun8i-codec: Implement jack and accessory detection

Ondrej Jirman (1):
  dt-bindings: sound: Add jack-type property to sun8i-a33-codec

Samuel Holland (2):
  ASoC: sun50i-codec-analog: Move suspend/resume to set_bias_level
  ASoC: sun8i-codec: Enable bus clock at STANDBY and higher bias

 .../sound/allwinner,sun8i-a33-codec.yaml      |   9 +
 sound/soc/sunxi/sun50i-codec-analog.c         |  73 +++-
 sound/soc/sunxi/sun8i-codec.c                 | 359 +++++++++++++++++-
 3 files changed, 421 insertions(+), 20 deletions(-)

Comments

Mark Brown March 26, 2024, 3:27 p.m. UTC | #1
On Fri, 23 Feb 2024 02:52:10 +0100, Ondřej Jirman wrote:
> This series adds support for jack detection to this codec. I used
> and tested this on Pinephone. It works quite nicely. I tested it
> against Android headset mic button resistor specification.
> 
> The patches are improved and debugged version of the original
> ones from Arnaud Ferraris and Samuel Holland, imrpoved to better
> handle headset button presses and with more robust plug-in/out
> event debouncing.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/5] dt-bindings: sound: Add jack-type property to sun8i-a33-codec
      (no commit info)
[2/5] ASoC: sun50i-codec-analog: Move suspend/resume to set_bias_level
      commit: c0454d31e05062b1c7df7eef21855ba1f56c5158
[3/5] ASoC: sun8i-codec: Enable bus clock at STANDBY and higher bias
      commit: c556814b926c3f16fdca3d18cac793ccf0d14c44
[4/5] ASoC: sun50i-codec-analog: Enable jack detection on startup
      commit: d5961e43b28668088087befbf4f7a043bd0ae65c
[5/5] ASoC: sun8i-codec: Implement jack and accessory detection
      commit: 21fa98f4197bb3365dda1417708b318f403c13c1

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark