| Message ID | 20240308090502.2136760-1-cezary.rojewski@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ASoC: Harden DAPM route checks and Intel fixes | expand |
On Fri, 08 Mar 2024 10:04:57 +0100, Cezary Rojewski wrote: > Set of loosely connected patches. Most impactful change is dropping any > permisiveness when snd_soc_dapm_add_routes() fails in soc-topology.c To > do it safely, disable route checks for all skylake-driver boards. > > Relevant background: > > Since commit daa480bde6b3 ("ASoC: soc-core: tidyup for > snd_soc_dapm_add_routes()") route checks are no longer permissive. Probe > failures for Intel boards have been partially addressed by commit > a22ae72b86a4 ("ASoC: soc-core: isable route checks for legacy devices") > and its follow up but only skl_nau88l25_ssm4567.c is patched. The rest > of the boards still need fixing. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/5] ASoC: Intel: Disable route checks for Skylake boards commit: 0cb3b7fd530b8c107443218ce6db5cb6e7b5dbe1 [2/5] ASoC: topology: Do not ignore route checks when parsing graphs commit: 6974857c2b2c7e2d2db59c0e23cc42b0efc58cd8 [3/5] ASoC: Intel: avs: ssm4567: Do not ignore route checks commit: e6719d48ba6329536c459dcee5a571e535687094 [4/5] ASoC: Intel: avs: ssm4567: Board cleanup commit: 3a2be3f05110fa1a5c682ff72a26681ed4f54cef [5/5] ASoC: Intel: avs: i2s_test: Remove redundant dapm routes commit: 60c10c678b582d41532fefa12667d8adca75811b All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
Set of loosely connected patches. Most impactful change is dropping any permisiveness when snd_soc_dapm_add_routes() fails in soc-topology.c To do it safely, disable route checks for all skylake-driver boards. Relevant background: Since commit daa480bde6b3 ("ASoC: soc-core: tidyup for snd_soc_dapm_add_routes()") route checks are no longer permissive. Probe failures for Intel boards have been partially addressed by commit a22ae72b86a4 ("ASoC: soc-core: isable route checks for legacy devices") and its follow up but only skl_nau88l25_ssm4567.c is patched. The rest of the boards still need fixing. After that, removal of copy-pastas found in ssm4567.c and redundant code in i2s_test.c for avs-boards. Changes in v2: - glk_rt5682_max98357a.c and skl_hda_dsp_generic.c now disable route checks only for the skylake-drvier - asoc now logs failures of snd_soc_dapm_add_routes() in soc-topology.c Amadeusz Sławiński (1): ASoC: Intel: avs: i2s_test: Remove redundant dapm routes Cezary Rojewski (4): ASoC: Intel: Disable route checks for Skylake boards ASoC: topology: Do not ignore route checks when parsing graphs ASoC: Intel: avs: ssm4567: Do not ignore route checks ASoC: Intel: avs: ssm4567: Board cleanup sound/soc/intel/avs/boards/i2s_test.c | 79 ------------------- sound/soc/intel/avs/boards/ssm4567.c | 5 +- sound/soc/intel/boards/bxt_da7219_max98357a.c | 1 + sound/soc/intel/boards/bxt_rt298.c | 1 + sound/soc/intel/boards/glk_rt5682_max98357a.c | 2 + sound/soc/intel/boards/kbl_da7219_max98357a.c | 1 + sound/soc/intel/boards/kbl_da7219_max98927.c | 4 + sound/soc/intel/boards/kbl_rt5660.c | 1 + sound/soc/intel/boards/kbl_rt5663_max98927.c | 2 + .../intel/boards/kbl_rt5663_rt5514_max98927.c | 1 + sound/soc/intel/boards/skl_hda_dsp_generic.c | 2 + .../soc/intel/boards/skl_nau88l25_max98357a.c | 1 + sound/soc/intel/boards/skl_rt286.c | 1 + sound/soc/soc-topology.c | 11 ++- 14 files changed, 27 insertions(+), 85 deletions(-)