mbox series

[0/4] ASoC: SOF: ipc4-pcm: Do not reset ChainDMA if it is not allocated

Message ID 20240409110036.9411-1-peter.ujfalusi@linux.intel.com (mailing list archive)
Headers show
Series ASoC: SOF: ipc4-pcm: Do not reset ChainDMA if it is not allocated | expand

Message

Peter Ujfalusi April 9, 2024, 11 a.m. UTC
Hi,

The current code will reset the ChainDMA on release unconditionally which
can result the following error when the CHainDMA is not allocated:

ipc tx      : 0xe040000|0x0: GLB_CHAIN_DMA
ipc tx reply: 0x2e000007|0x0: GLB_CHAIN_DMA
FW reported error: 7 - Unsupported operation requested
ipc error for msg 0xe040000|0x0
sof_pcm_stream_free: pcm_ops hw_free failed -22

Background:
Pulseaudio and Pipewire on startup opens all available streams and
closes them without triggering a start (after probing it's capabilities).

Regards,
Peter
---
Peter Ujfalusi (4):
  ASoC: SOF: ipc4-pcm: Use consistent name for snd_sof_pcm_stream
    pointer
  ASoC: SOF: ipc4-pcm: Use consistent name for sof_ipc4_timestamp_info
    pointer
  ASoC: SOF: ipc4-pcm: Introduce generic sof_ipc4_pcm_stream_priv
  ASoC: SOF: ipc4-pcm: Do not reset the ChainDMA if it has not been
    allocated

 sound/soc/sof/ipc4-pcm.c | 115 +++++++++++++++++++++++++++------------
 1 file changed, 79 insertions(+), 36 deletions(-)

Comments

Mark Brown April 9, 2024, 11:34 p.m. UTC | #1
On Tue, 09 Apr 2024 14:00:32 +0300, Peter Ujfalusi wrote:
> The current code will reset the ChainDMA on release unconditionally which
> can result the following error when the CHainDMA is not allocated:
> 
> ipc tx      : 0xe040000|0x0: GLB_CHAIN_DMA
> ipc tx reply: 0x2e000007|0x0: GLB_CHAIN_DMA
> FW reported error: 7 - Unsupported operation requested
> ipc error for msg 0xe040000|0x0
> sof_pcm_stream_free: pcm_ops hw_free failed -22
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/4] ASoC: SOF: ipc4-pcm: Use consistent name for snd_sof_pcm_stream pointer
      commit: 965e49cdf8c19f21b8308adeded3a8139cff5c84
[2/4] ASoC: SOF: ipc4-pcm: Use consistent name for sof_ipc4_timestamp_info pointer
      commit: 36e980050b0733829e4e0f97b97f7907ba9f00bb
[3/4] ASoC: SOF: ipc4-pcm: Introduce generic sof_ipc4_pcm_stream_priv
      commit: 551af3280c16166244425bbb1d73028f3a907e1f
[4/4] ASoC: SOF: ipc4-pcm: Do not reset the ChainDMA if it has not been allocated
      commit: 7211814f2adcf376b8db6321447a9725c33b6ae7

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark