[v2,0/6] ALSA: emu10k1: fixes related to uploading firmware to the E-MU dock

Message

Oswald Buddenhagen April 28, 2024, 9:37 a.m. UTC

patches 1, 3 & 5 fix the regression(s), patch 4 fixes a related pre-existing
problem, patch 6 is a speculative fix on top of patch 4, and patch 2 is
logically part of patch 3, just factored out for legibility.

i don't think it really makes sense to revert fbb64eedf5a3 (ALSA: emu10k1: make
E-MU dock monitoring interrupt-driven) and re-do things from scratch, as we'd
also need to revert the unrelated c960b012ec47 (ALSA: emu10k1: track loss of
external clock on E-MU cards) first.

so i'd just fast-track the series as-is, and cherry-pick it to stable.

---

the series (and a bunch of failed experiments) is fully tested by pietro with
both rev1 and rev2 1010 cards, a 0202 cardbus card, and their respective docks.
he'll get permanent testing credits in the card capability table later on, so i
didn't bother adding a tested-by footer to each patch.

---
v2:
- split off non-bugfix part of the series
- add quotes around summaries in Fixes footers

Oswald Buddenhagen (6):
  ALSA: emu10k1: fix E-MU card dock presence monitoring
  ALSA: emu10k1: factor out snd_emu1010_load_dock_firmware()
  ALSA: emu10k1: move the whole GPIO event handling to the workqueue
  ALSA: emu10k1: use mutex for E-MU FPGA access locking
  ALSA: emu10k1: fix E-MU dock initialization
  ALSA: emu10k1: make E-MU FPGA writes potentially more reliable

 include/sound/emu10k1.h          |   7 +-
 sound/pci/emu10k1/emu10k1.c      |   3 +-
 sound/pci/emu10k1/emu10k1_main.c | 158 ++++++++++++++++++-------------
 sound/pci/emu10k1/emumixer.c     |  18 +++-
 sound/pci/emu10k1/emuproc.c      |   9 ++
 sound/pci/emu10k1/io.c           |  51 +++++-----
 6 files changed, 142 insertions(+), 104 deletions(-)

Comments

Takashi Iwai April 28, 2024, 6:15 p.m. UTC | #1

On Sun, 28 Apr 2024 11:37:10 +0200,
Oswald Buddenhagen wrote:
> 
> patches 1, 3 & 5 fix the regression(s), patch 4 fixes a related pre-existing
> problem, patch 6 is a speculative fix on top of patch 4, and patch 2 is
> logically part of patch 3, just factored out for legibility.
> 
> i don't think it really makes sense to revert fbb64eedf5a3 (ALSA: emu10k1: make
> E-MU dock monitoring interrupt-driven) and re-do things from scratch, as we'd
> also need to revert the unrelated c960b012ec47 (ALSA: emu10k1: track loss of
> external clock on E-MU cards) first.
> 
> so i'd just fast-track the series as-is, and cherry-pick it to stable.
> 
> ---
> 
> the series (and a bunch of failed experiments) is fully tested by pietro with
> both rev1 and rev2 1010 cards, a 0202 cardbus card, and their respective docks.
> he'll get permanent testing credits in the card capability table later on, so i
> didn't bother adding a tested-by footer to each patch.
> 
> ---
> v2:
> - split off non-bugfix part of the series
> - add quotes around summaries in Fixes footers

Applied to for-linus branch.  Thanks.


Takashi