| Message ID | 20240507135513.14919-1-tiwai@suse.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | ALSA: Use *-y instead of *-objs in Makefile | expand |
On 07. 05. 24 15:55, Takashi Iwai wrote: > Hi, > > this is a series of trivial cleanup patches for Makefile in sound/* > (modulo ASoC -- which will be submitted later in a separate series). > > As Andy suggested in a patch review, *-objs suffix in Makefile is > basically a mis-use nowadays for kernel driver modules. They should > be replaced with *-y suffix instead. This is a result of systematic > conversions, separated per directory. Reviewed-by: Jaroslav Kysela <perex@perex.cz> Thanks, Jaroslav
On Tue, May 07, 2024 at 03:55:00PM +0200, Takashi Iwai wrote: > Hi, > > this is a series of trivial cleanup patches for Makefile in sound/* > (modulo ASoC -- which will be submitted later in a separate series). > > As Andy suggested in a patch review, *-objs suffix in Makefile is > basically a mis-use nowadays for kernel driver modules. They should > be replaced with *-y suffix instead. This is a result of systematic > conversions, separated per directory. I briefly looked at this and since it's a mechanical conversion I don't see any issues, so Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
On Tue, May 07, 2024 at 07:02:35PM +0300, Andy Shevchenko wrote: > On Tue, May 07, 2024 at 03:55:00PM +0200, Takashi Iwai wrote: > > Hi, > > > > this is a series of trivial cleanup patches for Makefile in sound/* > > (modulo ASoC -- which will be submitted later in a separate series). > > > > As Andy suggested in a patch review, *-objs suffix in Makefile is > > basically a mis-use nowadays for kernel driver modules. They should > > be replaced with *-y suffix instead. This is a result of systematic > > conversions, separated per directory. > > I briefly looked at this and since it's a mechanical conversion I don't see > any issues, so > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Btw, make W=1 nowadays enables modpost checks, which complain about absence of MODULE_DESCRIPTION(). Example: WARNING: modpost: missing MODULE_DESCRIPTION() in sound/core/snd-pcm-dmaengine.o WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-intel-atom.o WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-acpi-intel-byt.o WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-acpi-intel-bdw.o WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/snd-sof-utils.o WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/snd-sof-acpi.o WARNING: modpost: missing MODULE_DESCRIPTION() in sound/ac97_bus.o I'm not sure what the case now for ALSA, just FYI.
On Tue, 07 May 2024 22:53:46 +0200, Andy Shevchenko wrote: > > On Tue, May 07, 2024 at 07:02:35PM +0300, Andy Shevchenko wrote: > > On Tue, May 07, 2024 at 03:55:00PM +0200, Takashi Iwai wrote: > > > Hi, > > > > > > this is a series of trivial cleanup patches for Makefile in sound/* > > > (modulo ASoC -- which will be submitted later in a separate series). > > > > > > As Andy suggested in a patch review, *-objs suffix in Makefile is > > > basically a mis-use nowadays for kernel driver modules. They should > > > be replaced with *-y suffix instead. This is a result of systematic > > > conversions, separated per directory. > > > > I briefly looked at this and since it's a mechanical conversion I don't see > > any issues, so > > > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Btw, make W=1 nowadays enables modpost checks, which complain about absence of > MODULE_DESCRIPTION(). > > Example: > WARNING: modpost: missing MODULE_DESCRIPTION() in sound/core/snd-pcm-dmaengine.o > WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-intel-atom.o > WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-acpi-intel-byt.o > WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-acpi-intel-bdw.o > WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/snd-sof-utils.o > WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/snd-sof-acpi.o > WARNING: modpost: missing MODULE_DESCRIPTION() in sound/ac97_bus.o > > I'm not sure what the case now for ALSA, just FYI. Indeed there are lots of code that miss MODULE_DESCRIPTION(). Through a quick grep, there are: sound/ac97/bus.c sound/ac97_bus.c sound/core/pcm_dmaengine.c sound/core/sound_kunit.c sound/drivers/pcmtest.c sound/oss/dmasound/dmasound_atari.c sound/oss/dmasound/dmasound_core.c sound/oss/dmasound/dmasound_paula.c sound/pci/hda/cirrus_scodec_test.c sound/soc/amd/acp/acp-i2s.c sound/soc/amd/acp/acp-legacy-common.c sound/soc/amd/acp/acp-pci.c sound/soc/amd/acp/acp-pdm.c sound/soc/amd/ps/ps-mach.c sound/soc/amd/renoir/acp3x-rn.c sound/soc/amd/yc/acp6x-mach.c sound/soc/codecs/ab8500-codec.c sound/soc/codecs/sigmadsp.c sound/soc/codecs/wm_adsp.c sound/soc/fsl/imx-pcm-dma.c sound/soc/fsl/imx-pcm-fiq.c sound/soc/mxs/mxs-pcm.c sound/soc/qcom/common.c sound/soc/qcom/qdsp6/q6dsp-common.c sound/soc/qcom/sdw.c sound/soc/soc-generic-dmaengine-pcm.c sound/soc/soc-topology-test.c sound/soc/sof/amd/pci-acp63.c sound/soc/sof/amd/pci-rmb.c sound/soc/sof/amd/pci-rn.c sound/soc/sof/amd/pci-vangogh.c sound/soc/sof/imx/imx-common.c sound/soc/sof/imx/imx8.c sound/soc/sof/imx/imx8m.c sound/soc/sof/imx/imx8ulp.c sound/soc/sof/intel/atom.c sound/soc/sof/intel/bdw.c sound/soc/sof/intel/byt.c sound/soc/sof/intel/hda-codec.c sound/soc/sof/intel/hda-ctrl.c sound/soc/sof/intel/hda-mlink.c sound/soc/sof/intel/hda.c sound/soc/sof/intel/pci-apl.c sound/soc/sof/intel/pci-cnl.c sound/soc/sof/intel/pci-icl.c sound/soc/sof/intel/pci-lnl.c sound/soc/sof/intel/pci-mtl.c sound/soc/sof/intel/pci-skl.c sound/soc/sof/intel/pci-tgl.c sound/soc/sof/intel/pci-tng.c sound/soc/sof/mediatek/mt8186/mt8186.c sound/soc/sof/mediatek/mt8195/mt8195.c sound/soc/sof/mediatek/mtk-adsp-common.c sound/soc/sof/sof-acpi-dev.c sound/soc/sof/sof-of-dev.c sound/soc/sof/sof-pci-dev.c sound/soc/sof/sof-utils.c sound/soc/sof/stream-ipc.c sound/soc/ux500/ux500_msp_dai.c sound/soc/ux500/ux500_msp_i2s.c sound/soc/xilinx/xlnx_formatter_pcm.c sound/soc/xilinx/xlnx_i2s.c There are too many stuff in sound/soc/sof/* and I leave them to SOF people (Cc'ed), while I'm going to submit the fix patches for the rest. thanks, Takashi
On 5/8/24 04:02, Takashi Iwai wrote: > On Tue, 07 May 2024 22:53:46 +0200, > Andy Shevchenko wrote: >> >> On Tue, May 07, 2024 at 07:02:35PM +0300, Andy Shevchenko wrote: >>> On Tue, May 07, 2024 at 03:55:00PM +0200, Takashi Iwai wrote: >>>> Hi, >>>> >>>> this is a series of trivial cleanup patches for Makefile in sound/* >>>> (modulo ASoC -- which will be submitted later in a separate series). >>>> >>>> As Andy suggested in a patch review, *-objs suffix in Makefile is >>>> basically a mis-use nowadays for kernel driver modules. They should >>>> be replaced with *-y suffix instead. This is a result of systematic >>>> conversions, separated per directory. >>> >>> I briefly looked at this and since it's a mechanical conversion I don't see >>> any issues, so >>> >>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >> >> Btw, make W=1 nowadays enables modpost checks, which complain about absence of >> MODULE_DESCRIPTION(). >> >> Example: >> WARNING: modpost: missing MODULE_DESCRIPTION() in sound/core/snd-pcm-dmaengine.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-intel-atom.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-acpi-intel-byt.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-acpi-intel-bdw.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/snd-sof-utils.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/snd-sof-acpi.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in sound/ac97_bus.o >> >> I'm not sure what the case now for ALSA, just FYI. > > Indeed there are lots of code that miss MODULE_DESCRIPTION(). ... > There are too many stuff in sound/soc/sof/* and I leave them to SOF > people (Cc'ed), while I'm going to submit the fix patches for the > rest. ok, I'll take care of it. I wasn't aware this was a requirement.
On Thu, 09 May 2024 18:10:39 +0200, Pierre-Louis Bossart wrote: > > > > On 5/8/24 04:02, Takashi Iwai wrote: > > On Tue, 07 May 2024 22:53:46 +0200, > > Andy Shevchenko wrote: > >> > >> On Tue, May 07, 2024 at 07:02:35PM +0300, Andy Shevchenko wrote: > >>> On Tue, May 07, 2024 at 03:55:00PM +0200, Takashi Iwai wrote: > >>>> Hi, > >>>> > >>>> this is a series of trivial cleanup patches for Makefile in sound/* > >>>> (modulo ASoC -- which will be submitted later in a separate series). > >>>> > >>>> As Andy suggested in a patch review, *-objs suffix in Makefile is > >>>> basically a mis-use nowadays for kernel driver modules. They should > >>>> be replaced with *-y suffix instead. This is a result of systematic > >>>> conversions, separated per directory. > >>> > >>> I briefly looked at this and since it's a mechanical conversion I don't see > >>> any issues, so > >>> > >>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > >> > >> Btw, make W=1 nowadays enables modpost checks, which complain about absence of > >> MODULE_DESCRIPTION(). > >> > >> Example: > >> WARNING: modpost: missing MODULE_DESCRIPTION() in sound/core/snd-pcm-dmaengine.o > >> WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-intel-atom.o > >> WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-acpi-intel-byt.o > >> WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-acpi-intel-bdw.o > >> WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/snd-sof-utils.o > >> WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/snd-sof-acpi.o > >> WARNING: modpost: missing MODULE_DESCRIPTION() in sound/ac97_bus.o > >> > >> I'm not sure what the case now for ALSA, just FYI. > > > > Indeed there are lots of code that miss MODULE_DESCRIPTION(). > ... > > There are too many stuff in sound/soc/sof/* and I leave them to SOF > > people (Cc'ed), while I'm going to submit the fix patches for the > > rest. > > ok, I'll take care of it. I wasn't aware this was a requirement. It wasn't, but now became so :) Takashi
On Thu, May 09, 2024 at 08:28:32PM +0200, Takashi Iwai wrote: > On Thu, 09 May 2024 18:10:39 +0200, > Pierre-Louis Bossart wrote: > > On 5/8/24 04:02, Takashi Iwai wrote: > > > On Tue, 07 May 2024 22:53:46 +0200, > > > Andy Shevchenko wrote: > > >> On Tue, May 07, 2024 at 07:02:35PM +0300, Andy Shevchenko wrote: > > >>> On Tue, May 07, 2024 at 03:55:00PM +0200, Takashi Iwai wrote: > > >>>> this is a series of trivial cleanup patches for Makefile in sound/* > > >>>> (modulo ASoC -- which will be submitted later in a separate series). > > >>>> > > >>>> As Andy suggested in a patch review, *-objs suffix in Makefile is > > >>>> basically a mis-use nowadays for kernel driver modules. They should > > >>>> be replaced with *-y suffix instead. This is a result of systematic > > >>>> conversions, separated per directory. > > >>> > > >>> I briefly looked at this and since it's a mechanical conversion I don't see > > >>> any issues, so > > >>> > > >>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > >> > > >> Btw, make W=1 nowadays enables modpost checks, which complain about absence of > > >> MODULE_DESCRIPTION(). > > >> > > >> Example: > > >> WARNING: modpost: missing MODULE_DESCRIPTION() in sound/core/snd-pcm-dmaengine.o > > >> WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-intel-atom.o > > >> WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-acpi-intel-byt.o > > >> WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-acpi-intel-bdw.o > > >> WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/snd-sof-utils.o > > >> WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/snd-sof-acpi.o > > >> WARNING: modpost: missing MODULE_DESCRIPTION() in sound/ac97_bus.o > > >> > > >> I'm not sure what the case now for ALSA, just FYI. > > > > > > Indeed there are lots of code that miss MODULE_DESCRIPTION(). > > ... > > > There are too many stuff in sound/soc/sof/* and I leave them to SOF > > > people (Cc'ed), while I'm going to submit the fix patches for the > > > rest. > > > > ok, I'll take care of it. I wasn't aware this was a requirement. > > It wasn't, but now became so :) Seems this is the result of fixing... the 2008 bug: https://bugzilla.kernel.org/show_bug.cgi?id=10770
On 5/10/24 07:15, Andy Shevchenko wrote: > On Thu, May 09, 2024 at 08:28:32PM +0200, Takashi Iwai wrote: >> On Thu, 09 May 2024 18:10:39 +0200, >> Pierre-Louis Bossart wrote: >>> On 5/8/24 04:02, Takashi Iwai wrote: >>>> On Tue, 07 May 2024 22:53:46 +0200, >>>> Andy Shevchenko wrote: >>>>> On Tue, May 07, 2024 at 07:02:35PM +0300, Andy Shevchenko wrote: >>>>>> On Tue, May 07, 2024 at 03:55:00PM +0200, Takashi Iwai wrote: > >>>>>>> this is a series of trivial cleanup patches for Makefile in sound/* >>>>>>> (modulo ASoC -- which will be submitted later in a separate series). >>>>>>> >>>>>>> As Andy suggested in a patch review, *-objs suffix in Makefile is >>>>>>> basically a mis-use nowadays for kernel driver modules. They should >>>>>>> be replaced with *-y suffix instead. This is a result of systematic >>>>>>> conversions, separated per directory. >>>>>> >>>>>> I briefly looked at this and since it's a mechanical conversion I don't see >>>>>> any issues, so >>>>>> >>>>>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >>>>> >>>>> Btw, make W=1 nowadays enables modpost checks, which complain about absence of >>>>> MODULE_DESCRIPTION(). >>>>> >>>>> Example: >>>>> WARNING: modpost: missing MODULE_DESCRIPTION() in sound/core/snd-pcm-dmaengine.o >>>>> WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-intel-atom.o >>>>> WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-acpi-intel-byt.o >>>>> WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-acpi-intel-bdw.o >>>>> WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/snd-sof-utils.o >>>>> WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/snd-sof-acpi.o >>>>> WARNING: modpost: missing MODULE_DESCRIPTION() in sound/ac97_bus.o >>>>> >>>>> I'm not sure what the case now for ALSA, just FYI. >>>> >>>> Indeed there are lots of code that miss MODULE_DESCRIPTION(). >>> ... >>>> There are too many stuff in sound/soc/sof/* and I leave them to SOF >>>> people (Cc'ed), while I'm going to submit the fix patches for the >>>> rest. >>> >>> ok, I'll take care of it. I wasn't aware this was a requirement. >> >> It wasn't, but now became so :) > > Seems this is the result of fixing... the 2008 bug: > https://bugzilla.kernel.org/show_bug.cgi?id=10770 I've been slowly cleaning these tree-wide. Will now remove sound/... from my "hit list" :)