| Message ID | 20240607-dapm-graph-v1-0-bb302970d055@bootlin.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ASoC: dapm-graph: add component on/off and route names to graph | expand |
Hi Mark, All, On Fri, 07 Jun 2024 09:41:50 +0200 Luca Ceresoli <luca.ceresoli@bootlin.com> wrote: > This small series adds some improvements to dapm-graph in order to produce > a more correct and informative graph. > > Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com> Gentle ping about this series. It applies and works fine on current master. Luca
On Tue, Aug 20, 2024 at 06:44:06PM +0200, Luca Ceresoli wrote: > On Fri, 07 Jun 2024 09:41:50 +0200 > Luca Ceresoli <luca.ceresoli@bootlin.com> wrote: > > This small series adds some improvements to dapm-graph in order to produce > > a more correct and informative graph. > Gentle ping about this series. > It applies and works fine on current master. Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some reason for urgency (like critical bug fixes) please allow at least a couple of weeks for review. If there have been review comments then people may be waiting for those to be addressed. Sending content free pings adds to the mail volume (if they are seen at all) which is often the problem and since they can't be reviewed directly if something has gone wrong you'll have to resend the patches anyway, so sending again is generally a better approach though there are some other maintainers who like them - if in doubt look at how patches for the subsystem are normally handled.
Hello Mark, On Tue, 20 Aug 2024 18:04:17 +0100 Mark Brown <broonie@kernel.org> wrote: > On Tue, Aug 20, 2024 at 06:44:06PM +0200, Luca Ceresoli wrote: > > On Fri, 07 Jun 2024 09:41:50 +0200 > > Luca Ceresoli <luca.ceresoli@bootlin.com> wrote: > > > > This small series adds some improvements to dapm-graph in order to produce > > > a more correct and informative graph. > > > Gentle ping about this series. > > > It applies and works fine on current master. > > Please don't send content free pings and please allow a reasonable time > for review. People get busy, go on holiday, attend conferences and so > on so unless there is some reason for urgency (like critical bug fixes) > please allow at least a couple of weeks for review. If there have been > review comments then people may be waiting for those to be addressed. I'm sorry about the noise. I thought it was worth in this case because: * this series has been sent 2.5 months ago * there was no reply at all * AFAIK and according to MAINTAINERS there is no patchwork catching tools/sound/ So it was looking much more like something gone into oblivion than being on someone's TODO list. > Sending content free pings adds to the mail volume (if they are seen at > all) which is often the problem and since they can't be reviewed > directly if something has gone wrong you'll have to resend the patches > anyway, so sending again is generally a better approach though there are > some other maintainers who like them - if in doubt look at how patches > for the subsystem are normally handled. Apologies, my fault for not having checked the archives. Note taken. After doing so now however, I must say that while counting the resends is easy, counting the pings in a somewhat reliable way is very time consuming. It would be nice to have this info in a more reachable way (MAINTAINERS?). Luca
On Wed, Aug 21, 2024 at 10:17:48AM +0200, Luca Ceresoli wrote: > Mark Brown <broonie@kernel.org> wrote: > > Please don't send content free pings and please allow a reasonable time > > for review. People get busy, go on holiday, attend conferences and so > > on so unless there is some reason for urgency (like critical bug fixes) > > please allow at least a couple of weeks for review. If there have been > > review comments then people may be waiting for those to be addressed. > I'm sorry about the noise. I thought it was worth in this case because: > * this series has been sent 2.5 months ago > * there was no reply at all > * AFAIK and according to MAINTAINERS there is no patchwork catching > tools/sound/ > So it was looking much more like something gone into oblivion than > being on someone's TODO list. That would be the resend part of the mail - content free pings can't be directly acted on, they're just noise. Note also that you should generally rebase and resend things after the merge window. > After doing so now however, I must say that while counting the resends > is easy, counting the pings in a somewhat reliable way is very time > consuming. It would be nice to have this info in a more reachable way > (MAINTAINERS?). Feel free to take that up with the MAINTAINERS people. It's hard to specify things in a snappy one liner kind of way.
This small series adds some improvements to dapm-graph in order to produce a more correct and informative graph. Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com> --- Luca Ceresoli (3): ASoC: dapm-graph: remove the "ROOT" cluster ASoC: dapm-graph: visualize component On/Off bias level ASoC: dapm-graph: show path name for non-static routes tools/sound/dapm-graph | 44 +++++++++++++++++++++++++++++++++++--------- 1 file changed, 35 insertions(+), 9 deletions(-) --- base-commit: c3f38fa61af77b49866b006939479069cd451173 change-id: 20240603-dapm-graph-8e3f7e3fd692 Best regards,