[v6,0/2] Cirrus Logic Family of ADCs

Message

Paul Handrigan June 21, 2024, 3:17 p.m. UTC

This patchset provides ASoC support for the latest family
of Cirrus Logic multichannel, high performance audio ADCs.
The devices that are supported are CS5302 (2 channel ADC),
CS5304 (4 channel ADC), and CS5308 (8 channel ADC).

v2 changes:
- Use sizeof(*) instead of sizeof(struct cs530x_priv)
- Utilize i2c_get_match_data to simpify code.
- Use unintptr_t instead of enum cs530x_type to typecast
  match->data.
- Use dev_err_probe instead of dev_err in probe.
- Fix gpiod_set_vale for reset to the correct logical value.
- Provided full name for maintainer in DT binding.
- Remove | from after "discription" in DT binding.
- Removed unneeded discription of #sound-dai-cells.
- Changed supply discriptions in DT binding.
- Changeed underscores to dashes for DT property names.
- Added ref for dai-common for DT binding.
- Changed additionalProperties to unevaluatedProperties
  in DT binding.
- Changed the DT example to have the compatible property
  first and the reg second.
- Removed typos and blank lines in DT binding.
- Changed adc to cs5304 in DT example.

v3 changes:
- Changed cs5304 back to adc for device name in DT example.
- Removed dev_info for device id and rev id and added
  revid to dev_dbg along with device id.
- Set ret =  dev_err_probe and passed PTR_ERR value into
  dev_err_probe insead of assigning PTR_ERR to ret and passing
  ret into dev_err_probe.
- Moved dev_dai allocation to the beginning of probe.

v4 changes:
- Remove regmap volatile_reg callback since it is not needed.

v5 changes:
- Add MODULE_LICENSE to cs530x-i2c.c

v6 changes:
- Added missing Reviewed-by for DT Binding.
- Updated changelog.

Paul Handrigan (2):
  ASoC: dt-bindings: cirrus,cs530x: Add initial DT binding
  ASoC: cs530x: Support for cs530x ADCs

 .../bindings/sound/cirrus,cs530x.yaml         |  85 ++
 sound/soc/codecs/Kconfig                      |  14 +
 sound/soc/codecs/Makefile                     |   4 +
 sound/soc/codecs/cs530x-i2c.c                 |  72 ++
 sound/soc/codecs/cs530x.c                     | 966 ++++++++++++++++++
 sound/soc/codecs/cs530x.h                     | 223 ++++
 6 files changed, 1364 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml
 create mode 100644 sound/soc/codecs/cs530x-i2c.c
 create mode 100644 sound/soc/codecs/cs530x.c
 create mode 100644 sound/soc/codecs/cs530x.h

Comments

Mark Brown June 23, 2024, 5:22 p.m. UTC | #1

On Fri, 21 Jun 2024 10:17:55 -0500, Paul Handrigan wrote:
> This patchset provides ASoC support for the latest family
> of Cirrus Logic multichannel, high performance audio ADCs.
> The devices that are supported are CS5302 (2 channel ADC),
> CS5304 (4 channel ADC), and CS5308 (8 channel ADC).
> 
> v2 changes:
> - Use sizeof(*) instead of sizeof(struct cs530x_priv)
> - Utilize i2c_get_match_data to simpify code.
> - Use unintptr_t instead of enum cs530x_type to typecast
>   match->data.
> - Use dev_err_probe instead of dev_err in probe.
> - Fix gpiod_set_vale for reset to the correct logical value.
> - Provided full name for maintainer in DT binding.
> - Remove | from after "discription" in DT binding.
> - Removed unneeded discription of #sound-dai-cells.
> - Changed supply discriptions in DT binding.
> - Changeed underscores to dashes for DT property names.
> - Added ref for dai-common for DT binding.
> - Changed additionalProperties to unevaluatedProperties
>   in DT binding.
> - Changed the DT example to have the compatible property
>   first and the reg second.
> - Removed typos and blank lines in DT binding.
> - Changed adc to cs5304 in DT example.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: dt-bindings: cirrus,cs530x: Add initial DT binding
      commit: 0e2407ae89b340c385afdca1e1c61dd651ae6b35
[2/2] ASoC: cs530x: Support for cs530x ADCs
      commit: 2884c29152c098c32e0041061f8327bcdb4e0697

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark