[v2,0/4] firmware: cs_dsp: Some small coding improvements

Message

Richard Fitzgerald July 10, 2024, 10:36 a.m. UTC

Commit series that makes some small improvements to code and the
kernel log messages.

---
Changes since V1:
- Replaced commit #3 with one that keeps the wmfw format version
  message on its own line instead of merging it into the INFO text
  message.
- Commit #4 rebased onto the new #3

Richard Fitzgerald (4):
  firmware: cs_dsp: Don't allocate temporary buffer for info text
  firmware: cs_dsp: Make wmfw and bin filename arguments const char *
  firmware: cs_dsp: Clarify wmfw format version log message
  firmware: cs_dsp: Rename fw_ver to wmfw_ver

 drivers/firmware/cirrus/cs_dsp.c       | 68 +++++++++-----------------
 include/linux/firmware/cirrus/cs_dsp.h | 10 ++--
 sound/soc/codecs/wm_adsp.c             |  2 +-
 3 files changed, 29 insertions(+), 51 deletions(-)

Comments

Charles Keepax July 10, 2024, 12:20 p.m. UTC | #1

On Wed, Jul 10, 2024 at 11:36:36AM +0100, Richard Fitzgerald wrote:
> Commit series that makes some small improvements to code and the
> kernel log messages.
> 
> ---

Reviewed-by: Charles Keepax <[e-mail]>

Thanks,
Charles

Mark Brown July 11, 2024, 1:10 a.m. UTC | #2

On Wed, 10 Jul 2024 11:36:36 +0100, Richard Fitzgerald wrote:
> Commit series that makes some small improvements to code and the
> kernel log messages.
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/4] firmware: cs_dsp: Don't allocate temporary buffer for info text
      commit: bff92858dfb9897e4c06c11aab0322e1aab822f7
[2/4] firmware: cs_dsp: Make wmfw and bin filename arguments const char *
      commit: 584e86e14c59d36688633002613792923620d8c0
[3/4] firmware: cs_dsp: Clarify wmfw format version log message
      commit: a4939119055d5c97aff2cea040f1af8c4606bfa1
[4/4] firmware: cs_dsp: Rename fw_ver to wmfw_ver
      commit: dc0e5ca8856dc6a97e3b117879dfb2b52bda06b6

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark