mbox series

[v2,0/3] ASoC: tas*: Fix up GPIO usage

Message ID 20240807-asoc-tas-gpios-v2-0-bd0f2705d58b@linaro.org (mailing list archive)
Headers show
Series ASoC: tas*: Fix up GPIO usage | expand

Message

Linus Walleij Aug. 7, 2024, 3:02 p.m. UTC
The TI TAS drivers use some legacy GPIO code and headers,
this series fixes it up.

The TAS2781 is a special case since it adds a handful of
lines of deviating code to reconfigure a GPIO line for
IRQ mode and then never actually use the IRQ obtained in
the code. Is the line used by autonomous hardware? I'm
puzzled by this.

Anyways the patch suggest how to solve this properly by
fixing the parent irqchip and I'm happy to help.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Changes in v2:
- Rebased onto v6.11-rc1
- Link to v1: https://lore.kernel.org/r/20240701-asoc-tas-gpios-v1-0-d69ec5d79939@linaro.org

---
Linus Walleij (3):
      ASoC: tas2781-i2c: Drop weird GPIO code
      ASoC: tas2781-i2c: Get the right GPIO line
      ASoC: tas*: Drop unused GPIO includes

 include/sound/tas2781.h           |  7 +------
 sound/pci/hda/tas2781_hda_i2c.c   |  2 +-
 sound/soc/codecs/tas2552.c        |  1 -
 sound/soc/codecs/tas2764.c        |  1 -
 sound/soc/codecs/tas2770.c        |  1 -
 sound/soc/codecs/tas2780.c        |  1 -
 sound/soc/codecs/tas2781-comlib.c |  3 ---
 sound/soc/codecs/tas2781-fmwlib.c |  1 -
 sound/soc/codecs/tas2781-i2c.c    | 26 ++++----------------------
 9 files changed, 6 insertions(+), 37 deletions(-)
---
base-commit: 8400291e289ee6b2bf9779ff1c83a291501f017b
change-id: 20240701-asoc-tas-gpios-5c051d80d768

Best regards,

Comments

Mark Brown Aug. 8, 2024, 9:46 p.m. UTC | #1
On Wed, 07 Aug 2024 17:02:31 +0200, Linus Walleij wrote:
> The TI TAS drivers use some legacy GPIO code and headers,
> this series fixes it up.
> 
> The TAS2781 is a special case since it adds a handful of
> lines of deviating code to reconfigure a GPIO line for
> IRQ mode and then never actually use the IRQ obtained in
> the code. Is the line used by autonomous hardware? I'm
> puzzled by this.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/3] ASoC: tas2781-i2c: Drop weird GPIO code
      commit: c2c0b67dca3cb3b3cea0dd60075a1c5ba77e2fcd
[2/3] ASoC: tas2781-i2c: Get the right GPIO line
      commit: 1c4b509edad15192bfb64c81d3c305bbae8070db
[3/3] ASoC: tas*: Drop unused GPIO includes
      commit: caab9a1cbb9a9fca24ceabeef57b3764d861ad32

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark