| Message ID | 20240807152725.18948-1-tiwai@suse.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | ALSA/DRM: vmalloc PCM buffer helper cleanup | expand |
On Wed, 07 Aug 2024 17:27:21 +0200, Takashi Iwai wrote: > > Hi, > > we still keep the legacy vmalloc ALSA PCM helper API since there is > only a single user of it, namely, the DRM dw-hdmi bridge driver. > In the past, I attempted to change the buffer management of the > driver, but due to the lack of testing, it failed to get merged: > https://lore.kernel.org/20191210154536.29819-1-tiwai@suse.de > > So, this is a second try after some years of gap: now the relevant > code snippet is moved from ALSA core to dw-hdmi driver itself, and the > API functions are dropped. There should be no functional changes in > the driver. > > If DRM people don't mind and give an ack, I can take the change for > dw-hdmi code together with ALSA core code drop via sound tree for > 6.12. Gentle ping to any DRM reviewers. It's merely a safe clean up, so if you don't mind, I'd like to take for 6.12. thanks, Takashi > > > thanks, > > Takashi > > === > > Takashi Iwai (2): > drm/bridge: dw-hdmi: Move vmalloc PCM buffer management into the > driver > ALSA: pcm: Drop PCM vmalloc buffer helpers > > .../drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 30 ++++++++-- > include/sound/pcm.h | 42 ------------- > sound/core/pcm_memory.c | 59 ------------------- > 3 files changed, 26 insertions(+), 105 deletions(-) > > -- > 2.43.0 >
On Thu, 15 Aug 2024 10:03:40 +0200, Takashi Iwai wrote: > > On Wed, 07 Aug 2024 17:27:21 +0200, > Takashi Iwai wrote: > > > > Hi, > > > > we still keep the legacy vmalloc ALSA PCM helper API since there is > > only a single user of it, namely, the DRM dw-hdmi bridge driver. > > In the past, I attempted to change the buffer management of the > > driver, but due to the lack of testing, it failed to get merged: > > https://lore.kernel.org/20191210154536.29819-1-tiwai@suse.de > > > > So, this is a second try after some years of gap: now the relevant > > code snippet is moved from ALSA core to dw-hdmi driver itself, and the > > API functions are dropped. There should be no functional changes in > > the driver. > > > > If DRM people don't mind and give an ack, I can take the change for > > dw-hdmi code together with ALSA core code drop via sound tree for > > 6.12. > > Gentle ping to any DRM reviewers. It's merely a safe clean up, so if > you don't mind, I'd like to take for 6.12. Now merged to for-next branch of sound.git tree. Takashi
Hi, we still keep the legacy vmalloc ALSA PCM helper API since there is only a single user of it, namely, the DRM dw-hdmi bridge driver. In the past, I attempted to change the buffer management of the driver, but due to the lack of testing, it failed to get merged: https://lore.kernel.org/20191210154536.29819-1-tiwai@suse.de So, this is a second try after some years of gap: now the relevant code snippet is moved from ALSA core to dw-hdmi driver itself, and the API functions are dropped. There should be no functional changes in the driver. If DRM people don't mind and give an ack, I can take the change for dw-hdmi code together with ALSA core code drop via sound tree for 6.12. thanks, Takashi === Takashi Iwai (2): drm/bridge: dw-hdmi: Move vmalloc PCM buffer management into the driver ALSA: pcm: Drop PCM vmalloc buffer helpers .../drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 30 ++++++++-- include/sound/pcm.h | 42 ------------- sound/core/pcm_memory.c | 59 ------------------- 3 files changed, 26 insertions(+), 105 deletions(-)