mbox series

[v2,0/2] Some clean up with helper fucntion

Message ID 20240827070650.11424-1-zhangzekun11@huawei.com (mailing list archive)
Headers show
Series Some clean up with helper fucntion | expand

Message

zhangzekun (A) Aug. 27, 2024, 7:06 a.m. UTC
There are some helper functions which can be used to simplify the code.
So, let's use these functions to make code more simple.

v2: Fix a code logic broken problem and add the comment back.

Zhang Zekun (2):
  ASoC: audio-graph-card: Use for_each_child_of_node_scoped() to
    simplify code
  ASoC: audio-graph-card2: Use helper function of_get_child_count()

 sound/soc/generic/audio-graph-card.c  | 12 ++----------
 sound/soc/generic/audio-graph-card2.c | 11 +----------
 2 files changed, 3 insertions(+), 20 deletions(-)

Comments

Kuninori Morimoto Aug. 28, 2024, 4:36 a.m. UTC | #1
Hi Mark, Zhang

> There are some helper functions which can be used to simplify the code.
> So, let's use these functions to make code more simple.
> 
> v2: Fix a code logic broken problem and add the comment back.
> 
> Zhang Zekun (2):
>   ASoC: audio-graph-card: Use for_each_child_of_node_scoped() to
>     simplify code
>   ASoC: audio-graph-card2: Use helper function of_get_child_count()

Reviewed-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

But I think this patch-set will conflict with my posting Of-Graph patch-set
if Mark apply this patch-set, and Rob (?) apply my patch-set.

	add of_graph_get_next_port/port_endpoint()
	https://lore.kernel.org/r/87cylwqa12.wl-kuninori.morimoto.gx@renesas.com

Thank you for your help !!

Best regards
---
Kuninori Morimoto
Mark Brown Aug. 30, 2024, 2:56 p.m. UTC | #2
On Wed, Aug 28, 2024 at 04:36:15AM +0000, Kuninori Morimoto wrote:

> But I think this patch-set will conflict with my posting Of-Graph patch-set
> if Mark apply this patch-set, and Rob (?) apply my patch-set.

> 	add of_graph_get_next_port/port_endpoint()
> 	https://lore.kernel.org/r/87cylwqa12.wl-kuninori.morimoto.gx@renesas.com

> Thank you for your help !!

It looks like the of_graph patches might not make it into this merge
window anyway so possibly it won't actually be an issue?
Kuninori Morimoto Sept. 1, 2024, 11:44 p.m. UTC | #3
Hi Mark

> > But I think this patch-set will conflict with my posting Of-Graph patch-set
> > if Mark apply this patch-set, and Rob (?) apply my patch-set.
> 
> > 	add of_graph_get_next_port/port_endpoint()
> > 	https://lore.kernel.org/r/87cylwqa12.wl-kuninori.morimoto.gx@renesas.com
> 
> > Thank you for your help !!
> 
> It looks like the of_graph patches might not make it into this merge
> window anyway so possibly it won't actually be an issue?

Yeah, indeed. It seem it will take more long term.
I will explain about this and adjust the code.

Thank you for your help !!

Best regards
---
Kuninori Morimoto
Mark Brown Sept. 5, 2024, 10:50 a.m. UTC | #4
On Tue, 27 Aug 2024 15:06:48 +0800, Zhang Zekun wrote:
> There are some helper functions which can be used to simplify the code.
> So, let's use these functions to make code more simple.
> 
> v2: Fix a code logic broken problem and add the comment back.
> 
> Zhang Zekun (2):
>   ASoC: audio-graph-card: Use for_each_child_of_node_scoped() to
>     simplify code
>   ASoC: audio-graph-card2: Use helper function of_get_child_count()
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: audio-graph-card: Use for_each_child_of_node_scoped() to simplify code
      commit: de849243404e8ce02320a7178d4448e4d0191377
[2/2] ASoC: audio-graph-card2: Use helper function of_get_child_count()
      commit: 815f1fcf2403454904cbbc5cf370df6bc300f392

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
Mark Brown Sept. 6, 2024, 1:06 p.m. UTC | #5
On Tue, 27 Aug 2024 15:06:48 +0800, Zhang Zekun wrote:
> There are some helper functions which can be used to simplify the code.
> So, let's use these functions to make code more simple.
> 
> v2: Fix a code logic broken problem and add the comment back.
> 
> Zhang Zekun (2):
>   ASoC: audio-graph-card: Use for_each_child_of_node_scoped() to
>     simplify code
>   ASoC: audio-graph-card2: Use helper function of_get_child_count()
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: audio-graph-card: Use for_each_child_of_node_scoped() to simplify code
      commit: de849243404e8ce02320a7178d4448e4d0191377
[2/2] ASoC: audio-graph-card2: Use helper function of_get_child_count()
      commit: 815f1fcf2403454904cbbc5cf370df6bc300f392

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark