mbox series

[0/7] ASoC: mt8365: Fix -Werror builds

Message ID 20240907-asoc-fix-mt8365-build-v1-0-7ad0bac20161@kernel.org (mailing list archive)
Headers show
Series ASoC: mt8365: Fix -Werror builds | expand

Message

Mark Brown Sept. 7, 2024, 12:53 a.m. UTC
Nathan reported that the newly added mt8365 drivers were causing a
number of warnings which break -Werror builds, these were only visible
on arm64 since the drivers did not have COMPILE_TEST enabled.  Fix this
and some other minor stuff I noticed while doing so.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
Mark Brown (7):
      ASoC: mt8365: Open code BIT() to avoid spurious warnings
      ASoC: mt8365: Remove spurious unsigned long casts
      ASoC: mt8365: Remove unused prototype for mt8365_afe_clk_group_48k()
      ASoC: mt8365: Make non-exported functions static
      ASoC: mt8365: Remove unused variables
      ASoC: mt8365: Remove unused DMIC IIR coefficient configuration
      ASoC: mt8365: Allow build coverage

 sound/soc/mediatek/Kconfig                    |   2 +-
 sound/soc/mediatek/mt8365/mt8365-afe-clk.c    |   4 +-
 sound/soc/mediatek/mt8365/mt8365-afe-common.h |   1 -
 sound/soc/mediatek/mt8365/mt8365-afe-pcm.c    |  13 +-
 sound/soc/mediatek/mt8365/mt8365-dai-dmic.c   |  30 ----
 sound/soc/mediatek/mt8365/mt8365-dai-i2s.c    |   6 +-
 sound/soc/mediatek/mt8365/mt8365-mt6357.c     |   3 +-
 sound/soc/mediatek/mt8365/mt8365-reg.h        | 214 +++++++++++++-------------
 8 files changed, 120 insertions(+), 153 deletions(-)
---
base-commit: 813751eaec93bfeb6236aaed99607a44c01b3110
change-id: 20240906-asoc-fix-mt8365-build-974117b12f0a

Best regards,

Comments

Alexandre Mergnat Sept. 9, 2024, 12:47 p.m. UTC | #1
I'm embarrassed, my apologies for this oversight...
Thank you for the fixes.
Nathan Chancellor Sept. 9, 2024, 3:48 p.m. UTC | #2
On Sat, Sep 07, 2024 at 01:53:25AM +0100, Mark Brown wrote:
> Nathan reported that the newly added mt8365 drivers were causing a
> number of warnings which break -Werror builds, these were only visible
> on arm64 since the drivers did not have COMPILE_TEST enabled.  Fix this
> and some other minor stuff I noticed while doing so.
> ---
> Mark Brown (7):
>       ASoC: mt8365: Open code BIT() to avoid spurious warnings
>       ASoC: mt8365: Remove spurious unsigned long casts
>       ASoC: mt8365: Remove unused prototype for mt8365_afe_clk_group_48k()
>       ASoC: mt8365: Make non-exported functions static
>       ASoC: mt8365: Remove unused variables
>       ASoC: mt8365: Remove unused DMIC IIR coefficient configuration
>       ASoC: mt8365: Allow build coverage

Thanks for this. It appears to resolve all the issues from a build of
allmodconfig for arm, arm64, and x86.

Tested-by: Nathan Chancellor <nathan@kernel.org> # build

Cheers,
Nathan
Mark Brown Sept. 9, 2024, 9:57 p.m. UTC | #3
On Sat, 07 Sep 2024 01:53:25 +0100, Mark Brown wrote:
> Nathan reported that the newly added mt8365 drivers were causing a
> number of warnings which break -Werror builds, these were only visible
> on arm64 since the drivers did not have COMPILE_TEST enabled.  Fix this
> and some other minor stuff I noticed while doing so.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/7] ASoC: mt8365: Open code BIT() to avoid spurious warnings
      commit: d01c6a398750aae265c17859b57d7409a6d9181d
[2/7] ASoC: mt8365: Remove spurious unsigned long casts
      commit: 1b084d8e3b98ca460b815cff14617719ebe605ad
[3/7] ASoC: mt8365: Remove unused prototype for mt8365_afe_clk_group_48k()
      commit: 3e61df7d2ff67875c770a7f548038054d05a0f15
[4/7] ASoC: mt8365: Make non-exported functions static
      commit: 63157d994025639075b3faa372976a96186322c1
[5/7] ASoC: mt8365: Remove unused variables
      commit: 067d832806225cfaabeec8f5f683b7e2bc508a6d
[6/7] ASoC: mt8365: Remove unused DMIC IIR coefficient configuration
      commit: d70ce6d3105a6bd02b1708c399105631643a550a
[7/7] ASoC: mt8365: Allow build coverage
      commit: 36fa259b214c37bbae3e0b7a47e7fb49cb0ab462

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark