| Message ID | 20241008110936.22534-1-peter.ujfalusi@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ASoC: SOF: ipc4-topology: Rework the module audio format prints | expand |
On Tue, 08 Oct 2024 14:09:28 +0300, Peter Ujfalusi wrote: > When the audio started we print out here and there the Input and Output or only > the Input audio format for the module that is in path of the stream. > This is mostly OK but provides inconsistent an - in my opinion - hard to grasp > information. > > The series reworks how the input/output format is selected and tries to improve > the consistency of the prints by applying universal rules: > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/8] ASoC: SOF: ipc4-topology: Drop the 'index' from 'Pin index' of format print commit: 76733db0f5560efa0c6514329620b9cbc8b1ca42 [2/8] ASoC: SOF: ipc4-topology: Use local variables in sof_ipc4_init_input_audio_fmt() commit: 3b54c1cd69d04bbdafc5542d11c6cab685fc13bd [3/8] ASoC: SOF: ipc4-topology: Remove redundant check in sof_ipc4_init_input_audio_fmt() commit: 2d9635b57b1bbbece2a8d30103fcd1ebfbbe0178 [4/8] ASoC: SOF: ipc4-topology: Simplify match format print in sof_ipc4_init_input_audio_fmt() commit: 0126a659fd517103e8ce4d432fbe9b06f0a20510 [5/8] ASoC: SOF: ipc4-topology: Use local variables in sof_ipc4_init_output_audio_fmt() commit: 7a4c41e4778342b0ceda2e16127fefa808de3c57 [6/8] ASoC: SOF: ipc4-topology: Simplify code to deal with process modules without output commit: fdaf2291524c6a220bb051ad1a8d3c99b177b6f1 [7/8] ASoC: SOF: ipc4-topology: Concentrate prints inside of sof_ipc4_init_output_audio_fmt() commit: 22408b8f625d85b5453fde8627aa6dd49f87c281 [8/8] ASoC: SOF: ipc4-topology: Add helper function to print the module's in/out audio format commit: 47701a85af0c0d655e06dd23f6b8761848147450 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
Hi, When the audio started we print out here and there the Input and Output or only the Input audio format for the module that is in path of the stream. This is mostly OK but provides inconsistent an - in my opinion - hard to grasp information. The series reworks how the input/output format is selected and tries to improve the consistency of the prints by applying universal rules: - Module is not changing the format or it has only input or output and it has single format on in and out side Audio format for gain.1.1: - Module is not changing the format or it has only input or output and it has multiple formats on either in or out side Audio format (in/out format index: 2/0) for host-copier.0.playback: - Module is changing format then we print the input and output ones - Input if it has single format Input audio format for host-copier.0.capture: - Input has multiple formats Input audio format (format index: 0) for host-copier.0.playback: Similar versions for the output format prints. Regards, Peter --- Peter Ujfalusi (8): ASoC: SOF: ipc4-topology: Drop the 'index' from 'Pin index' of format print ASoC: SOF: ipc4-topology: Use local variables in sof_ipc4_init_input_audio_fmt() ASoC: SOF: ipc4-topology: Remove redundant check in sof_ipc4_init_input_audio_fmt() ASoC: SOF: ipc4-topology: Simplify match format print in sof_ipc4_init_input_audio_fmt() ASoC: SOF: ipc4-topology: Use local variables in sof_ipc4_init_output_audio_fmt() ASoC: SOF: ipc4-topology: Simplify code to deal with process modules without output ASoC: SOF: ipc4-topology: Concentrate prints inside of sof_ipc4_init_output_audio_fmt() ASoC: SOF: ipc4-topology: Add helper function to print the module's in/out audio format sound/soc/sof/ipc4-topology.c | 375 ++++++++++++++++++++++------------ 1 file changed, 248 insertions(+), 127 deletions(-)