mbox series

[0/2] ASoC: Intel: Fix Kconfig for ACPI=n

Message ID 20241107100204.24952-1-peter.ujfalusi@linux.intel.com (mailing list archive)
Headers show
Series ASoC: Intel: Fix Kconfig for ACPI=n | expand

Message

Peter Ujfalusi Nov. 7, 2024, 10:02 a.m. UTC
Hi,

A recent attempt to fix a missing symbol when
CONFIG_SND_SOC_SDCA=m and CONFIG_SND_SOC_ACPI_INTEL_SDCA_QUIRKS=y
caused unmet direct dependency warning with randconig.

The reason is that SND_SOC_ACPI_INTEL_MATCH is needed to be compilable
even if ACPI is not selected, modules have dependency on exported
symbols from it.

The only solution for these kconfig dependencies seams to be to
only select SND_SOC_SDCA if ACPI is enabled  from
SND_SOC_ACPI_INTEL_SDCA_QUIRKS.

Regards,
Peter
---
Peter Ujfalusi (2):
  ASoC: Intel: Kconfig: Only select SND_SOC_SDCA if ACPI is enabled
  ASoC: Intel: Kconfig: Revert make SND_SOC_ACPI_INTEL_MATCH depend on
    ACPI

 sound/soc/intel/Kconfig | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Mark Brown Nov. 9, 2024, 3:13 a.m. UTC | #1
On Thu, 07 Nov 2024 12:02:02 +0200, Peter Ujfalusi wrote:
> A recent attempt to fix a missing symbol when
> CONFIG_SND_SOC_SDCA=m and CONFIG_SND_SOC_ACPI_INTEL_SDCA_QUIRKS=y
> caused unmet direct dependency warning with randconig.
> 
> The reason is that SND_SOC_ACPI_INTEL_MATCH is needed to be compilable
> even if ACPI is not selected, modules have dependency on exported
> symbols from it.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: Intel: Kconfig: Only select SND_SOC_SDCA if ACPI is enabled
      commit: c5bbc47f8e094f4489934a244ee1c14947a5075e
[2/2] ASoC: Intel: Kconfig: Revert make SND_SOC_ACPI_INTEL_MATCH depend on ACPI
      commit: 4f1636e7b0384c43856e1442755f48d7c690c2a9

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark