mbox series

[0/1] fix priv->dai_props indexing

Message ID 20250114184314.3583-1-laurentiumihalcea111@gmail.com (mailing list archive)
Headers show
Series fix priv->dai_props indexing | expand

Message

Laurentiu Mihalcea Jan. 14, 2025, 6:43 p.m. UTC
From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>

Fix priv->dai_props indexing in simple-card-utils.c by introducing
a new macro: runtime_simple_priv_to_props() that can be used when
dealing with PCM runtime data as rtd->id may be invalid.

Changes since RFC:
- added comment that should help clarify when the new macro
 should be used
- Link to RFC: https://lore.kernel.org/lkml/20241220151213.2462-1-laurentiumihalcea111@gmail.com/

Laurentiu Mihalcea (1):
  ASoC: simple-card-utils: fix priv->dai_props indexing

 include/sound/simple_card_utils.h     |  7 +++++++
 sound/soc/generic/simple-card-utils.c | 10 +++++-----
 2 files changed, 12 insertions(+), 5 deletions(-)

Comments

Mark Brown Jan. 14, 2025, 7:46 p.m. UTC | #1
On Tue, Jan 14, 2025 at 01:43:13PM -0500, Laurentiu Mihalcea wrote:
> From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
> 
> Fix priv->dai_props indexing in simple-card-utils.c by introducing
> a new macro: runtime_simple_priv_to_props() that can be used when
> dealing with PCM runtime data as rtd->id may be invalid.

Please don't send cover letters for single patches, if there is anything
that needs saying put it in the changelog of the patch or after the ---
if it's administrative stuff.  This reduces mail volume and ensures that 
any important information is recorded in the changelog rather than being
lost.