mbox series

[V4,0/6] soundwire: amd: code improvements and new platform support

Message ID 20250207065841.4718-1-Vijendar.Mukunda@amd.com (mailing list archive)
Headers show
Series soundwire: amd: code improvements and new platform support | expand

Message

Vijendar Mukunda Feb. 7, 2025, 6:58 a.m. UTC
This patch series consists of code improvements and new platform support
for ACP7.0 & ACP7.1 platforms.

Changes since v3:
- Remove extra white line in amd_sdw_manager_start() function.

Changes since v2:
- Rebase the patch series after dropping the patch which adds conditional
  check for SoundWire manager device resume when wake event is asserted.

Changes since v1:
- Drop white line insertion in the code.
- Add a conditional check for SoundWire manager device resume when wake
  event is asserted.
- Add new patch to set ACP_PME_EN during runtime suspend sequence
- Split the existing implementation of host wake interrupt mask
  enablement and setting device power state in to two separate patches
  and refactor set device power state logic.
- Drop PME status clear logic.

Vijendar Mukunda (6):
  soundwire: amd: change the soundwire wake enable/disable sequence
  soundwire: amd: add debug log for soundwire wake event
  soundwire: amd: add support for ACP7.0 & ACP7.1 platforms
  soundwire: amd: set device power state during suspend/resume sequence
  soundwire: amd: set ACP_PME_EN during runtime suspend sequence
  soundwire: amd: add soundwire host wake interrupt enable/disable
    sequence

 drivers/soundwire/amd_manager.c   | 149 +++++++++++++++++++++++++++++-
 drivers/soundwire/amd_manager.h   |  26 ++++++
 include/linux/soundwire/sdw_amd.h |   2 +
 3 files changed, 172 insertions(+), 5 deletions(-)

Comments

Vijendar Mukunda Feb. 13, 2025, 11:58 a.m. UTC | #1
On 07/02/25 12:28, Vijendar Mukunda wrote:
> This patch series consists of code improvements and new platform support
> for ACP7.0 & ACP7.1 platforms.
>
> Changes since v3:
> - Remove extra white line in amd_sdw_manager_start() function.
>
> Changes since v2:
> - Rebase the patch series after dropping the patch which adds conditional
>   check for SoundWire manager device resume when wake event is asserted.
>
> Changes since v1:
> - Drop white line insertion in the code.
> - Add a conditional check for SoundWire manager device resume when wake
>   event is asserted.
> - Add new patch to set ACP_PME_EN during runtime suspend sequence
> - Split the existing implementation of host wake interrupt mask
>   enablement and setting device power state in to two separate patches
>   and refactor set device power state logic.
> - Drop PME status clear logic.

Hi Vinod,

ASoC patches (Which adds support for ACP7.0 & ACP7.1 platforms) got
merged. Could you please help to review the patch series?

Thanks,
Vijendar
>
> Vijendar Mukunda (6):
>   soundwire: amd: change the soundwire wake enable/disable sequence
>   soundwire: amd: add debug log for soundwire wake event
>   soundwire: amd: add support for ACP7.0 & ACP7.1 platforms
>   soundwire: amd: set device power state during suspend/resume sequence
>   soundwire: amd: set ACP_PME_EN during runtime suspend sequence
>   soundwire: amd: add soundwire host wake interrupt enable/disable
>     sequence
>
>  drivers/soundwire/amd_manager.c   | 149 +++++++++++++++++++++++++++++-
>  drivers/soundwire/amd_manager.h   |  26 ++++++
>  include/linux/soundwire/sdw_amd.h |   2 +
>  3 files changed, 172 insertions(+), 5 deletions(-)
>
Vinod Koul Feb. 13, 2025, 4:30 p.m. UTC | #2
On Fri, 07 Feb 2025 12:28:35 +0530, Vijendar Mukunda wrote:
> This patch series consists of code improvements and new platform support
> for ACP7.0 & ACP7.1 platforms.
> 
> Changes since v3:
> - Remove extra white line in amd_sdw_manager_start() function.
> 
> Changes since v2:
> - Rebase the patch series after dropping the patch which adds conditional
>   check for SoundWire manager device resume when wake event is asserted.
> 
> [...]

Applied, thanks!

[1/6] soundwire: amd: change the soundwire wake enable/disable sequence
      commit: dcc48a73eae7f791b1a6856ea1bcc4079282c88d
[2/6] soundwire: amd: add debug log for soundwire wake event
      commit: 19427c08b818c65f579cbfc78062e1ff4c37c768
[3/6] soundwire: amd: add support for ACP7.0 & ACP7.1 platforms
      commit: 2c0ae8ef1e5edfd0e42727fba4617694f3aac2eb
[4/6] soundwire: amd: set device power state during suspend/resume sequence
      commit: 829c3e1cb4a3f60c5cef11963052009ea50d2941
[5/6] soundwire: amd: set ACP_PME_EN during runtime suspend sequence
      commit: 5818ed3636b3c63eddef299223c7369de86eefee
[6/6] soundwire: amd: add soundwire host wake interrupt enable/disable sequence
      commit: 3df75289ddc28b46121d51d2812943b78676497b

Best regards,