mbox series

[v2,00/22] ASoC: codecs: Update device_id tables for Realtek drivers

Message ID 20250226112612.166989-1-cezary.rojewski@intel.com (mailing list archive)
Headers show
Series ASoC: codecs: Update device_id tables for Realtek drivers | expand

Message

Cezary Rojewski Feb. 26, 2025, 11:25 a.m. UTC 
The series aims to streamline the formatting for ACPI IDs so that a
single pattern can be used to identify the device.

Work implicitly suggested by Andy Shevchenko - reading and learning from
number of his reviews on the Linux mailing lists.

Several formats do exists, however, after technical discussion PCI-based
format has been selected as the recommended one. For Realtek devices, it
is going to be 10ECxxxx where 10EC unambiguously identifies Realtek
company whereas the following 4 hexes specify the PART_ID i.e.: the
device.

While at it, there shall be no comma after the terminator entry and
initializing fields with 0 for statically defined structs is redundant.

Patches sorted into two groups:
- fixes, no functional changes
- updates: fix + addition of new ACPI ID entries


Changes in v2:
- dropped 2 conflicting patches for rt1015p and rt5682s as pointed out
  by Choiu and Shuming
- sorted ACPI IDs alphabetically as suggested by Andy. This targets
  numerous patches and is noted by 'While at it, sort the IDs
  alphabetically.' in the commit message
- spacing (whitespaces) should now be cohesive across all patches


Cezary Rojewski (22):
  ASoC: codecs: rt1011: Fix definition of device_id tables
  ASoC: codecs: rt1015: Fix definition of device_id tables
  ASoC: codecs: rt1016: Fix definition of device_id tables
  ASoC: codecs: rt1019: Fix definition of device_id tables
  ASoC: codecs: rt1305: Fix definition of device_id tables
  ASoC: codecs: rt1308: Fix definition of device_id tables
  ASoC: codecs: rt1318: Fix definition of device_id tables
  ASoC: codecs: rt274: Fix definition of device_id tables
  ASoC: codecs: rt5514: Fix definition of device_id tables
  ASoC: codecs: rt5640: Fix definition of device_id tables
  ASoC: codecs: rt5645: Fix definition of device_id tables
  ASoC: codecs: rt5651: Fix definition of device_id tables
  ASoC: codecs: rt5659: Fix definition of device_id tables
  ASoC: codecs: rt5660: Fix definition of device_id tables
  ASoC: codecs: rt5663: Fix definition of device_id tables
  ASoC: codecs: rt5665: Fix definition of device_id tables
  ASoC: codecs: rt5668: Fix definition of device_id tables
  ASoC: codecs: rt5670: Fix definition of device_id tables
  ASoC: codecs: rt5682: Fix definition of device_id tables
  ASoC: codecs: rt286: Update definition of device_id tables
  ASoC: codecs: rt298: Update definition of device_id tables
  ASoC: codecs: rt5677: Update definition of device_id tables

 sound/soc/codecs/rt1011.c     |  6 +++---
 sound/soc/codecs/rt1015.c     |  6 +++---
 sound/soc/codecs/rt1016.c     |  6 +++---
 sound/soc/codecs/rt1019.c     |  6 +++---
 sound/soc/codecs/rt1305.c     |  8 ++++----
 sound/soc/codecs/rt1308.c     |  6 +++---
 sound/soc/codecs/rt1318.c     |  6 +++---
 sound/soc/codecs/rt274.c      |  8 ++++----
 sound/soc/codecs/rt286.c      |  5 +++--
 sound/soc/codecs/rt298.c      |  5 +++--
 sound/soc/codecs/rt5514.c     |  6 +++---
 sound/soc/codecs/rt5640.c     | 14 +++++++-------
 sound/soc/codecs/rt5645.c     | 12 ++++++------
 sound/soc/codecs/rt5651.c     |  8 ++++----
 sound/soc/codecs/rt5659.c     |  8 ++++----
 sound/soc/codecs/rt5660.c     |  8 ++++----
 sound/soc/codecs/rt5663.c     |  6 +++---
 sound/soc/codecs/rt5665.c     |  8 ++++----
 sound/soc/codecs/rt5668.c     |  6 +++---
 sound/soc/codecs/rt5670.c     |  8 ++++----
 sound/soc/codecs/rt5677-spi.c |  3 ++-
 sound/soc/codecs/rt5677.c     |  1 +
 sound/soc/codecs/rt5682-i2c.c |  6 +++---
 23 files changed, 80 insertions(+), 76 deletions(-)

Comments

Andy Shevchenko Feb. 26, 2025, 2:06 p.m. UTC | #1 
On Wed, Feb 26, 2025 at 12:25:50PM +0100, Cezary Rojewski wrote:
> The series aims to streamline the formatting for ACPI IDs so that a
> single pattern can be used to identify the device.
> 
> Work implicitly suggested by Andy Shevchenko - reading and learning from
> number of his reviews on the Linux mailing lists.
> 
> Several formats do exists, however, after technical discussion PCI-based
> format has been selected as the recommended one. For Realtek devices, it
> is going to be 10ECxxxx where 10EC unambiguously identifies Realtek
> company whereas the following 4 hexes specify the PART_ID i.e.: the
> device.
> 
> While at it, there shall be no comma after the terminator entry and
> initializing fields with 0 for statically defined structs is redundant.
> 
> Patches sorted into two groups:
> - fixes, no functional changes
> - updates: fix + addition of new ACPI ID entries

For all
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Mark Brown March 4, 2025, 3:35 p.m. UTC | #2 
On Wed, 26 Feb 2025 12:25:50 +0100, Cezary Rojewski wrote:
> The series aims to streamline the formatting for ACPI IDs so that a
> single pattern can be used to identify the device.
> 
> Work implicitly suggested by Andy Shevchenko - reading and learning from
> number of his reviews on the Linux mailing lists.
> 
> Several formats do exists, however, after technical discussion PCI-based
> format has been selected as the recommended one. For Realtek devices, it
> is going to be 10ECxxxx where 10EC unambiguously identifies Realtek
> company whereas the following 4 hexes specify the PART_ID i.e.: the
> device.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[01/22] ASoC: codecs: rt1011: Fix definition of device_id tables
        commit: b686559772d1baa28e2ad346d5a9932863d9523c
[02/22] ASoC: codecs: rt1015: Fix definition of device_id tables
        commit: a859d2383f66002a442218bf5083faaa674bc4e4
[03/22] ASoC: codecs: rt1016: Fix definition of device_id tables
        commit: e7795c17b82684afb9390b8788f781c07be1a368
[04/22] ASoC: codecs: rt1019: Fix definition of device_id tables
        commit: 689e4d5fd8a76c676f04bc8916d78ca5db3130db
[05/22] ASoC: codecs: rt1305: Fix definition of device_id tables
        commit: 0440f938aacf54a3e7dc67cd898f76bbd371da49
[06/22] ASoC: codecs: rt1308: Fix definition of device_id tables
        commit: 30e03871146129acb75adac48405c203f5bdb3c2
[07/22] ASoC: codecs: rt1318: Fix definition of device_id tables
        commit: acac29fa62a8b738569a99da2f6458bc21aa55ae
[08/22] ASoC: codecs: rt274: Fix definition of device_id tables
        commit: 5a84cbb03094fd903ed79ca6c06e558821a69be4
[09/22] ASoC: codecs: rt5514: Fix definition of device_id tables
        commit: 1c418cf146380031b13b6fde02f944830e5b9155
[10/22] ASoC: codecs: rt5640: Fix definition of device_id tables
        commit: dfc6b8ccb1bb8d591cd26571e554208fc4af7d0c
[11/22] ASoC: codecs: rt5645: Fix definition of device_id tables
        commit: d3a37a664ebe57471bd7ab2486dd3072a9c07378
[12/22] ASoC: codecs: rt5651: Fix definition of device_id tables
        commit: 85188e3bd7cb4141181f24a59f9057c38ffa37bf
[13/22] ASoC: codecs: rt5659: Fix definition of device_id tables
        commit: 24a4302478118ff1caf39fb48809c0127f608664
[14/22] ASoC: codecs: rt5660: Fix definition of device_id tables
        commit: 4d34ea6709894243d55ae6a6b63834851f9c5d6f
[15/22] ASoC: codecs: rt5663: Fix definition of device_id tables
        commit: e9d9a43e3f00b9313013b78d915a1f97dd215bf5
[16/22] ASoC: codecs: rt5665: Fix definition of device_id tables
        commit: b89d9d26fb6cbc9f6e0aae72a2a76b5d8e5f1023
[17/22] ASoC: codecs: rt5668: Fix definition of device_id tables
        commit: a06ef7754b8e6f45d78c0015c3edb2117945adfb
[18/22] ASoC: codecs: rt5670: Fix definition of device_id tables
        commit: 9aa85f433bb1f51b599278b29b3d6224ca5147cf
[19/22] ASoC: codecs: rt5682: Fix definition of device_id tables
        commit: 6de7c4def7a6bf967d6603f7e1abda5231ccc312
[20/22] ASoC: codecs: rt286: Update definition of device_id tables
        commit: 7f15da9a55d3ba9f8c3af545246a4588102a38db
[21/22] ASoC: codecs: rt298: Update definition of device_id tables
        commit: ed4bef1d52ce0d6c96a86b6a470d6777034c564c
[22/22] ASoC: codecs: rt5677: Update definition of device_id tables
        commit: 739db0529c2a3ac5a0dc3e5a76a46ce80735dcfa

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark