[v5,0/8] ASoC: tas27{64,70}: improve support for Apple codec variants

Message

James Calligeros April 5, 2025, 11:15 p.m. UTC

Hi all,

This series introduces a number of changes to the drivers for
the Texas Instruments TAS2764 and TAS2770 amplifiers in order to
introduce (and improve in the case of TAS2770) support for the
variants of these amps found in Apple Silicon Macs.

Apple's variant of TAS2764 is known as SN012776, and as always with
Apple is a subtly incompatible variant with a number of quirks. It
is not publicly available. The TAS2770 variant is known as TAS5770L,
and does not require incompatible handling.

Much as with the Cirrus codec patches, I do not
expect that we will get any official acknowledgement that these parts
exist from TI, however I would be delighted to be proven wrong.

This series has been living in the downstream Asahi kernel tree[1]
for over two years, and has been tested by many thousands of users
by this point[2].

v4 drops the TDM idle TX slot behaviour patches. I experimented with
the API discussed in v3, however this did not work on any of the machines
I tested it with. More tweaking is probably needed.

[1] https://github.com/AsahiLinux/linux/tree/asahi-wip
[2] https://stats.asahilinux.org/

---
Changes in v5:
- Dropped two commits that depended on TX idle stuff (sorry)
- Link to v4: https://lore.kernel.org/r/[e-mail]

Changes in v4:
- Moved remaining changes to the top of the set
- Dropped already merged commits
- hwmon now reads temp from regmap
- Bumped regmap max reg patch above Apple quirks patch
- Dropped TDM idle slot TX behaviour patches
- Link to v3: https://lore.kernel.org/r/[e-mail]

Changes in v3:
- Add Rob's Acked-by to Devicetree compatible additions
- Dropped cherry-picked patches
- Droped abuse of regulator API
- Droped bespoke sysfs interface
- Rationalised temperature reading for hwmon interface
- Set SN012776 device ID with OF match data
- Changed probe ops reliant on device ID to case/switch statement
- Added documentation for new Devicetree properties
- Improved a number of poor quality commit messages
- Documented behaviour of die temperature ADC
- Link to v2: https://lore.kernel.org/r/[e-mail]

Changes in v2:
- Changed author field of patch to match Martin's Signed-off-by
- Added Neal's Reviewed-by to reviewed patches
- Moved fixes to existing code to the top of the series
- Removed tas2764's explicit dependency on OF
- Removed complicated single-use tas2764 quirks macro and replaced with
  if block
- Added hwmon interface for codec die temp
- Fixed a malformed commit message
- Link to v1: https://lore.kernel.org/r/[e-mail]

---
Hector Martin (3):
      ASoC: tas2770: Power cycle amp on ISENSE/VSENSE change
      ASoC: tas2770: Support setting the PDM TX slot
      ASoC: tas2764: Enable main IRQs

James Calligeros (2):
      ASoC: tas2770: expose die temp to hwmon
      ASoC: tas2764: expose die temp to hwmon

Martin Povišer (3):
      ASoC: tas2764: Reinit cache on part reset
      ASoC: tas2764: Raise regmap range maximum
      ASoC: tas2764: Apply Apple quirks

 sound/soc/codecs/tas2764-quirks.h | 180 +++++++++++++++++++++++++
 sound/soc/codecs/tas2764.c        | 137 ++++++++++++++++++-
 sound/soc/codecs/tas2764.h        |   3 +
 sound/soc/codecs/tas2770.c        | 151 ++++++++++++++++++++-
 sound/soc/codecs/tas2770.h        |   6 +
 5 files changed, 472 insertions(+), 5 deletions(-)
---
base-commit: 3a0f0a4355df0240485ed62b6bd6afa5b3e689c5
change-id: 20250214-apple-codec-changes-6e656dc1e24d

Best regards,

Comments

Mark Brown April 14, 2025, 1:56 p.m. UTC | #1

On Sun, 06 Apr 2025 09:15:04 +1000, James Calligeros wrote:
> This series introduces a number of changes to the drivers for
> the Texas Instruments TAS2764 and TAS2770 amplifiers in order to
> introduce (and improve in the case of TAS2770) support for the
> variants of these amps found in Apple Silicon Macs.
> 
> Apple's variant of TAS2764 is known as SN012776, and as always with
> Apple is a subtly incompatible variant with a number of quirks. It
> is not publicly available. The TAS2770 variant is known as TAS5770L,
> and does not require incompatible handling.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/8] ASoC: tas2770: Power cycle amp on ISENSE/VSENSE change
      commit: f529c91be8a34ac12e7599bf87c65b6f4a2c9f5c
[2/8] ASoC: tas2770: Support setting the PDM TX slot
      commit: 7699892ad3cf3a9afc8c63886344f6e2b73166e2
[3/8] ASoC: tas2764: Reinit cache on part reset
      commit: 592ab3936b096da5deb64d4c906edbeb989174d6
[4/8] ASoC: tas2764: Enable main IRQs
      commit: dd50f0e38563f15819059c923bf142200453e003
[5/8] ASoC: tas2764: Raise regmap range maximum
      commit: f0aff451f399d09aaf2a23c4e2ef2077b9857ca5
[6/8] ASoC: tas2764: Apply Apple quirks
      commit: f33b01e0947d81c514bc8ff31ad28cae7ff6d91f
[7/8] ASoC: tas2770: expose die temp to hwmon
      commit: ff73e2780169a43617cc339686f5bd3d74fa8652
[8/8] ASoC: tas2764: expose die temp to hwmon
      commit: 186dfc85f9a824e3f8383322747ca75e988486e9

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark