[v3,0/3] ALSA: hda/realtek: cs35l41: Fix internal speaker support for ASUS UM3402 with missing DSD

Message

Jean-Loïc Charroud Feb. 13, 2024, 11:37 p.m. UTC

This patch set adds the missing DSD properties, to make the internal speaker works for the "ASUS UM3402" and does some cleanup. 

Following feedback, I've divided the initial patch into three independent parts and adjusted the explanations: 
- Patch 1 : Add internal speaker support for ASUS UM3402 with missing DSD 
- Patch 2 : Fix device ID / model name (no functional changes) 
- Patch 3 : Fix order and duplicates entry in quirks table (cleanup, no functional changes) 

Thank you Takashi for your guidance 
I hope everything is in good shape now. 

Regards 
Loïc 

sound/pci/hda/cs35l41_hda_property.c | 2 ++ 
sound/pci/hda/patch_realtek.c | 7 +++---- 
2 files changed, 5 insertions(+), 4 deletions(-)

Comments

Takashi Iwai Feb. 14, 2024, 9:16 a.m. UTC | #1

On Wed, 14 Feb 2024 00:37:23 +0100,
Jean-Loïc Charroud wrote:
> 
> This patch set adds the missing DSD properties, to make the internal speaker works for the "ASUS UM3402" and does some cleanup. 
> 
> Following feedback, I've divided the initial patch into three independent parts and adjusted the explanations: 
> - Patch 1 : Add internal speaker support for ASUS UM3402 with missing DSD 
> - Patch 2 : Fix device ID / model name (no functional changes) 
> - Patch 3 : Fix order and duplicates entry in quirks table (cleanup, no functional changes) 
> 
> Thank you Takashi for your guidance 
> I hope everything is in good shape now. 

Thanks!  It's almost fine and I corrected minor things in my side
(e.g. adding Fixes tags), now applied all to for-linus branch.


Takashi