[v2,00/17] ASoC: soc-dai: add snd_soc_dai_xxx()

Message

Kuninori Morimoto April 23, 2020, 11:14 p.m. UTC

From: Kuninori Morimoto <[e-mail]>

We have soc-dai.c today. DAI related functions
should be implemented in it.
These patches are v2 of doing it.

Link: https://lore.kernel.org/r/[e-mail]

Kuninori Morimoto (17):
  ASoC: soc-dai: add soc_dai_err()
  ASoC: soc-dai: don't overwide dai->driver->ops
  ASoC: soc-dai: add snd_soc_pcm_dai_new()
  ASoC: soc-dai: add snd_soc_pcm_dai_prepare()
  ASoC: soc-dai: add snd_soc_pcm_dai_trigger()
  ASoC: soc-dai: add snd_soc_pcm_dai_bespoke_trigger()
  ASoC: soc-dai: add snd_soc_pcm_dai_probe()
  ASoC: soc-dai: add snd_soc_pcm_dai_remove()
  ASoC: soc-dai: add snd_soc_dai_compr_start()
  ASoC: soc-dai: add snd_soc_dai_compr_shutdown()
  ASoC: soc-dai: add snd_soc_dai_compr_trigger()
  ASoC: soc-dai: add snd_soc_dai_compr_set_params()
  ASoC: soc-dai: add snd_soc_dai_compr_get_params()
  ASoC: soc-dai: add snd_soc_dai_compr_ack()
  ASoC: soc-dai: add snd_soc_dai_compr_pointer()
  ASoC: soc-dai: add snd_soc_dai_compr_set_metadata()
  ASoC: soc-dai: add snd_soc_dai_compr_get_metadata()

 include/sound/soc-dai.h  |  41 +++-
 sound/soc/soc-compress.c | 104 ++++-----
 sound/soc/soc-core.c     |  85 +-------
 sound/soc/soc-dai.c      | 453 +++++++++++++++++++++++++++++----------
 sound/soc/soc-pcm.c      |  50 +----
 5 files changed, 434 insertions(+), 299 deletions(-)

Comments

Ranjani Sridharan April 24, 2020, 2:28 a.m. UTC | #1

On Fri, 2020-04-24 at 08:14 +0900, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <[e-mail]>
> 
> We have soc-dai.c today. DAI related functions
> should be implemented in it.
> These patches are v2 of doing it.
> 
> Link: 
> https://lore.kernel.org/r/[e-mail]
> 
> Kuninori Morimoto (17):
>   ASoC: soc-dai: add soc_dai_err()
>   ASoC: soc-dai: don't overwide dai->driver->ops
>   ASoC: soc-dai: add snd_soc_pcm_dai_new()
>   ASoC: soc-dai: add snd_soc_pcm_dai_prepare()
>   ASoC: soc-dai: add snd_soc_pcm_dai_trigger()
>   ASoC: soc-dai: add snd_soc_pcm_dai_bespoke_trigger()
>   ASoC: soc-dai: add snd_soc_pcm_dai_probe()
>   ASoC: soc-dai: add snd_soc_pcm_dai_remove()
>   ASoC: soc-dai: add snd_soc_dai_compr_start()
>   ASoC: soc-dai: add snd_soc_dai_compr_shutdown()
>   ASoC: soc-dai: add snd_soc_dai_compr_trigger()
>   ASoC: soc-dai: add snd_soc_dai_compr_set_params()
>   ASoC: soc-dai: add snd_soc_dai_compr_get_params()
>   ASoC: soc-dai: add snd_soc_dai_compr_ack()
>   ASoC: soc-dai: add snd_soc_dai_compr_pointer()
>   ASoC: soc-dai: add snd_soc_dai_compr_set_metadata()
>   ASoC: soc-dai: add snd_soc_dai_compr_get_metadata()

LGTM, thanks Morimoto-san, except for the typo in the commit
title/message in the first patch that Pierre pointed out.

Reviewed-By: Ranjani Sridharan <[e-mail]>

Mark Brown April 29, 2020, 4:26 p.m. UTC | #2

On 24 Apr 2020 08:14:12 +0900, Kuninori Morimoto wrote:
> 
> From: Kuninori Morimoto <[e-mail]>
> 
> We have soc-dai.c today. DAI related functions
> should be implemented in it.
> These patches are v2 of doing it.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.8

Thanks!

[01/17] ASoC: soc-dai: add soc_dai_err()
        commit: aa7b8230d4c3d0e691604dc908887904f52f2ab8
[02/17] ASoC: soc-dai: don't overwide dai->driver->ops
        commit: 479914ed779d408273fb3cac4c061dbe695f17cb
[03/17] ASoC: soc-dai: add snd_soc_pcm_dai_new()
        commit: 0b73ba550cdd95b0fdca5da0040c29ae5d25ae5d
[04/17] ASoC: soc-dai: add snd_soc_pcm_dai_prepare()
        commit: d108c7fd0b776d5b48acd15f6f52b1bb8255a69e
[05/17] ASoC: soc-dai: add snd_soc_pcm_dai_trigger()
        commit: 42f2472d4689c00d742b6690aa6579966f0b2f83
[06/17] ASoC: soc-dai: add snd_soc_pcm_dai_bespoke_trigger()
        commit: 30819358ae73326269ba61597be47d5036e05b08
[07/17] ASoC: soc-dai: add snd_soc_pcm_dai_probe()
        commit: 51801aeafdc9c1d55e5e71e58a1bbbd2583328fa
[08/17] ASoC: soc-dai: add snd_soc_pcm_dai_remove()
        commit: 7eaa313bdec3f2326c9cdacec88fd484a36c423b
[09/17] ASoC: soc-dai: add snd_soc_dai_compr_start()
        commit: b5ae4ccea5ab15adcde64f4474b36e4a630434ec
[10/17] ASoC: soc-dai: add snd_soc_dai_compr_shutdown()
        commit: 2b25f81d43b764142699a430da0ca57ffcb33cc2
[11/17] ASoC: soc-dai: add snd_soc_dai_compr_trigger()
        commit: eb08411bdf48cff69f7226c86a97fba1ef5045e6
[12/17] ASoC: soc-dai: add snd_soc_dai_compr_set_params()
        commit: 8dfedafb5c711b5a13c938e06e8143540f773ecf
[13/17] ASoC: soc-dai: add snd_soc_dai_compr_get_params()
        commit: adbef5432666e20616263792d13cab80d57d9d5f
[14/17] ASoC: soc-dai: add snd_soc_dai_compr_ack()
        commit: 53294353a05ceaa6a107e8c1c300af63c89c8e50
[15/17] ASoC: soc-dai: add snd_soc_dai_compr_pointer()
        commit: ed38cc5909e72e30815f72e73cba34a3dbbb5494
[16/17] ASoC: soc-dai: add snd_soc_dai_compr_set_metadata()
        commit: 88b3a7dfe999b3e28f65be69787a1fd97b742b4f
[17/17] ASoC: soc-dai: add snd_soc_dai_compr_get_metadata()
        commit: 94d7281993a7933bf60ea733eeb8a8bad429bf1c

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark