[v5,0/4] ASoC: grace time for DPCM cleanup

Message

Kuninori Morimoto May 30, 2024, 1:17 a.m. UTC

Hi Mark, Pierre-Louis, Jerome
Cc each ASoC driver maintainer

This is v5 of DPCM cleanup

As we discussed in [1], we don't need to use dpcm_playback/capture flag,
so we remove it. But we have been using it for 10 years, some driver might
get damage. The most likely case is that the device/driver can use both
playback/capture, but have only one flag, and not using xxx_only flag.
[1/3] patch indicates warning in such case.

These adds grace time for DPCM cleanup.
I'm not sure when dpcm_xxx will be removed, and Codec check bypass will be
error, but maybe v6.11 or v6.12 ?
Please check each driver by that time.

Previous patch-set try to check both CPU and Codec in DPCM, but we noticed
that there are some special DAI which we can't handle today [2]. So I will
escape it in this patch-set.

[1] https://lore.kernel.org/r/[e-mail]
[2] https://lore.kernel.org/all/[e-mail]/

Link: https://lore.kernel.org/r/[e-mail]
Link: https://lore.kernel.org/r/[e-mail]
Link: https://lore.kernel.org/r/[e-mail]
Link: https://lore.kernel.org/r/[e-mail]

v4 -> v5
	- typo fix: limition -> limitation
	- typo fix: catpure  -> capture
	- include Intel patch

v3 -> v4
	- don't check Codec on DPCM
	- include Jerome's dpcm_xxx update patch

v2 -> v3
	- tidyup typo (reuqsts -> requests)
	- add Tested-by on git-log

v1 -> v2
	- tidyup Codec check warning output condition


Jerome Brunet (1):
  ASoC: amlogic: do not use dpcm_playback/capture flags

Kuninori Morimoto (2):
  ASoC: soc-pcm: Indicate warning if dpcm_playback/capture were used for availability limition
  ASoC: remove snd_soc_dai_link_set_capabilities()

Pierre-Louis Bossart (1):
  ASoC: Intel: sof_sdw: use playback/capture_only flags

 include/sound/soc-dai.h               |  1 -
 include/sound/soc.h                   |  1 +
 sound/soc/fsl/imx-card.c              |  3 --
 sound/soc/generic/audio-graph-card.c  |  2 -
 sound/soc/generic/audio-graph-card2.c |  2 -
 sound/soc/generic/simple-card.c       |  2 -
 sound/soc/intel/boards/sof_sdw.c      |  4 +-
 sound/soc/meson/axg-card.c            | 11 +++--
 sound/soc/meson/gx-card.c             |  1 -
 sound/soc/meson/meson-card-utils.c    |  4 +-
 sound/soc/qcom/common.c               |  1 -
 sound/soc/soc-dai.c                   | 38 ----------------
 sound/soc/soc-pcm.c                   | 65 +++++++++++++++------------
 13 files changed, 47 insertions(+), 88 deletions(-)

Comments

Mark Brown June 18, 2024, 1:20 p.m. UTC | #1

On Thu, May 30, 2024 at 01:17:39AM +0000, Kuninori Morimoto wrote:

> As we discussed in [1], we don't need to use dpcm_playback/capture flag,
> so we remove it. But we have been using it for 10 years, some driver might
> get damage. The most likely case is that the device/driver can use both
> playback/capture, but have only one flag, and not using xxx_only flag.
> [1/3] patch indicates warning in such case.

This doesn't apply against current code, please check and resend (it's
simple-card and audio-graph-card2 that conflict).

Kuninori Morimoto June 19, 2024, 12:07 a.m. UTC | #2

Hi Mark

> > As we discussed in [1], we don't need to use dpcm_playback/capture flag,
> > so we remove it. But we have been using it for 10 years, some driver might
> > get damage. The most likely case is that the device/driver can use both
> > playback/capture, but have only one flag, and not using xxx_only flag.
> > [1/3] patch indicates warning in such case.
> 
> This doesn't apply against current code, please check and resend (it's
> simple-card and audio-graph-card2 that conflict).

Hmm ? I didn't get conflict on latest branch ?
I'm using this commit

	595265c92668cbdbd9f299c49907734d468c12e9
	("ASoC: Constify DAI ops auto_selectable_formats")

Anyway, I will post v6 patch.

Thank you for your help !!
Best regards
---
Kuninori Morimoto

Kuninori Morimoto June 19, 2024, 4:57 a.m. UTC | #3

Hi Mark again

> > As we discussed in [1], we don't need to use dpcm_playback/capture flag,
> > so we remove it. But we have been using it for 10 years, some driver might
> > get damage. The most likely case is that the device/driver can use both
> > playback/capture, but have only one flag, and not using xxx_only flag.
> > [1/3] patch indicates warning in such case.
> 
> This doesn't apply against current code, please check and resend (it's
> simple-card and audio-graph-card2 that conflict).

Ah, I guess you used "v5 original" patch-set.
"v5 resend" patch-set or today's "v6" patch-set should be OK.

Thank you for your help !!
Best regards
---
Kuninori Morimoto

Mark Brown June 19, 2024, 11:01 a.m. UTC | #4

On Wed, Jun 19, 2024 at 04:57:22AM +0000, Kuninori Morimoto wrote:

> > This doesn't apply against current code, please check and resend (it's
> > simple-card and audio-graph-card2 that conflict).

> Ah, I guess you used "v5 original" patch-set.
> "v5 resend" patch-set or today's "v6" patch-set should be OK.

Oh, if you mark something as a resend then it sounds like it should be
exactly the same as it was before, if you've rebased you should increase
the version number.

Kuninori Morimoto June 19, 2024, 11:55 p.m. UTC | #5

Hi Mark

> > > This doesn't apply against current code, please check and resend (it's
> > > simple-card and audio-graph-card2 that conflict).
> 
> > Ah, I guess you used "v5 original" patch-set.
> > "v5 resend" patch-set or today's "v6" patch-set should be OK.
> 
> Oh, if you mark something as a resend then it sounds like it should be
> exactly the same as it was before, if you've rebased you should increase
> the version number.

Thanks, I learned it this time. Will do since next time.
And now I could understand the reason that sometime maintainer get strange
conflict which I don't have :)


Thank you for your help !!
Best regards
---
Kuninori Morimoto