mbox series

[v3,00/25] ASoC: use helper function and cleanup

Message ID 87cz6vfosc.wl-kuninori.morimoto.gx@renesas.com (mailing list archive)
Headers show
Series ASoC: use helper function and cleanup | expand

Message

Kuninori Morimoto Jan. 31, 2023, 1:58 a.m. UTC 
Hi Mark

These are v3 patch-set to use helper function on ASoC.

struct snd_soc_dai need to have info for playback/capture,
but it is using "playback/capture_xxx" or "tx/tx_xxx" or array.
This kind of random definition is very difficult to read.

This patch-set add helper functions and each driver use it.
And cleanup the definition.

v2 -> v3
	- fixup mediatek compile error
	- fixup rt compile error

v1 -> v2
	- added Reviewed-by on each patches if it got
	- fixup soc-dai.c helper bug

Link: https://lore.kernel.org/r/87y1psu1m1.wl-kuninori.morimoto.gx@renesas.com
Link: https://lore.kernel.org/r/87a62dlmmn.wl-kuninori.morimoto.gx@renesas.com

Kuninori Morimoto (25):
  ASoC: soc-dai.h: add missing snd_soc_dai_set_widget()
  ASoC: soc-dai.h: add snd_soc_dai_dma_data_set/get() for low level
  ASoC: soc-dai.h: add snd_soc_dai_tdm_mask_set/get() helper
  ASoC: soc-dai.h: add snd_soc_dai_get/set_widget_playback/capture() helper
  ASoC: soc.h: add snd_soc_card_is_instantiated() helper
  ASoC: hdmi-codec: use helper function
  ASoC: hda: use helper function
  ASoC: max: use helper function
  ASoC: rt: use helper function
  ASoC: cirrus: use helper function
  ASoC: spear: use helper function
  ASoC: sdw-mockup: use helper function
  ASoC: intel: use helper function
  ASoC: mediatek: use helper function
  ASoC: meson: use helper function
  ASoC: rockchip: use helper function
  ASoC: sof: use helper function
  ASoC: tegra: use helper function
  ASoC: ti: use helper function
  ASoC: soc-core.c: use helper function
  ASoC: soc-dapm.c: use helper function
  ASoC: soc-dai.c: use helper function
  ASoC: soc-pcm.c: use helper function
  ASoC: soc-topology.c: use helper function
  ASoC: soc-dai.h: cleanup Playback/Capture data for snd_soc_dai

 include/sound/soc-dai.h                       |  90 ++++++++-------
 include/sound/soc.h                           |   6 +
 sound/soc/cirrus/ep93xx-ac97.c                |   4 +-
 sound/soc/cirrus/ep93xx-i2s.c                 |   4 +-
 sound/soc/codecs/hda.c                        |   7 +-
 sound/soc/codecs/hdmi-codec.c                 |  11 +-
 sound/soc/codecs/max98373-sdw.c               |   5 +-
 sound/soc/codecs/rt1308-sdw.c                 |   5 +-
 sound/soc/codecs/rt1316-sdw.c                 |   5 +-
 sound/soc/codecs/rt1318-sdw.c                 |   5 +-
 sound/soc/codecs/rt5645.c                     |   2 +-
 sound/soc/codecs/rt5665.c                     |   4 +-
 sound/soc/codecs/rt5668.c                     |   4 +-
 sound/soc/codecs/rt5682-sdw.c                 |   5 +-
 sound/soc/codecs/rt5682.c                     |   4 +-
 sound/soc/codecs/rt5682s.c                    |   4 +-
 sound/soc/codecs/rt700.c                      |   7 +-
 sound/soc/codecs/rt711-sdca.c                 |   7 +-
 sound/soc/codecs/rt711.c                      |   7 +-
 sound/soc/codecs/rt715-sdca.c                 |   5 +-
 sound/soc/codecs/rt715.c                      |   5 +-
 sound/soc/codecs/sdw-mockup.c                 |   5 +-
 sound/soc/intel/atom/sst-atom-controls.c      |   9 +-
 sound/soc/intel/avs/boards/nau8825.c          |   5 +-
 sound/soc/intel/avs/pcm.c                     |  15 +--
 sound/soc/intel/skylake/skl-topology.c        |  19 +---
 .../soc/mediatek/common/mtk-dsp-sof-common.c  |  18 ++-
 sound/soc/mediatek/mt6797/mt6797-dai-pcm.c    |   8 +-
 sound/soc/mediatek/mt8183/mt8183-dai-pcm.c    |   7 +-
 sound/soc/mediatek/mt8186/mt8186-dai-pcm.c    |   7 +-
 sound/soc/mediatek/mt8188/mt8188-dai-pcm.c    |   3 +-
 sound/soc/mediatek/mt8192/mt8192-dai-pcm.c    |   8 +-
 sound/soc/mediatek/mt8195/mt8195-dai-pcm.c    |   7 +-
 sound/soc/meson/aiu-fifo-i2s.c                |   4 +-
 sound/soc/meson/aiu-fifo-spdif.c              |   2 +-
 sound/soc/meson/aiu-fifo.c                    |  21 ++--
 sound/soc/meson/axg-tdm-interface.c           |  34 +++---
 sound/soc/meson/axg-tdmin.c                   |   2 +-
 sound/soc/meson/axg-tdmout.c                  |   2 +-
 sound/soc/meson/meson-codec-glue.c            |   8 +-
 sound/soc/rockchip/rockchip_i2s_tdm.c         |   4 +-
 sound/soc/rockchip/rockchip_pdm.c             |   2 +-
 sound/soc/rockchip/rockchip_spdif.c           |   2 +-
 sound/soc/soc-core.c                          |   8 +-
 sound/soc/soc-dai.c                           |  13 ++-
 sound/soc/soc-dapm.c                          |  26 ++---
 sound/soc/soc-pcm.c                           |  12 +-
 sound/soc/soc-topology.c                      |   4 +-
 sound/soc/sof/topology.c                      | 104 +++++++-----------
 sound/soc/spear/spdif_out.c                   |   3 +-
 sound/soc/tegra/tegra20_ac97.c                |   4 +-
 sound/soc/tegra/tegra20_i2s.c                 |   4 +-
 sound/soc/tegra/tegra20_spdif.c               |   3 +-
 sound/soc/tegra/tegra210_admaif.c             |   4 +-
 sound/soc/tegra/tegra30_i2s.c                 |   4 +-
 sound/soc/ti/davinci-i2s.c                    |   5 +-
 sound/soc/ti/davinci-mcasp.c                  |   5 +-
 sound/soc/ti/davinci-vcif.c                   |   5 +-
 58 files changed, 276 insertions(+), 316 deletions(-)

Comments

Mark Brown Jan. 31, 2023, 10:18 p.m. UTC | #1 
On Tue, 31 Jan 2023 01:58:27 +0000, Kuninori Morimoto wrote:
> These are v3 patch-set to use helper function on ASoC.
> 
> struct snd_soc_dai need to have info for playback/capture,
> but it is using "playback/capture_xxx" or "tx/tx_xxx" or array.
> This kind of random definition is very difficult to read.
> 
> This patch-set add helper functions and each driver use it.
> And cleanup the definition.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[01/25] ASoC: soc-dai.h: add missing snd_soc_dai_set_widget()
        commit: 37ed123689968fa7f733598d9a6966e8a2db66fb
[02/25] ASoC: soc-dai.h: add snd_soc_dai_dma_data_set/get() for low level
        commit: 60df5935c27e19cc6595bd1740479a60f1880a32
[03/25] ASoC: soc-dai.h: add snd_soc_dai_tdm_mask_set/get() helper
        commit: d4c0326e6ea038cf99fde6f22296e4e68de4f2b5
[04/25] ASoC: soc-dai.h: add snd_soc_dai_get/set_widget_playback/capture() helper
        commit: 944d721ee5defb376410c7054a7db0a0ef5ff584
[05/25] ASoC: soc.h: add snd_soc_card_is_instantiated() helper
        commit: 2e5f86174e31cc1eda92b308f23f3b29684b339e
[06/25] ASoC: hdmi-codec: use helper function
        commit: c59331b39045fcc9ed3c66cb5c80a8ef3ade820f
[07/25] ASoC: hda: use helper function
        commit: 5bf13408fd06068aeef751597748c9d0569c3708
[08/25] ASoC: max: use helper function
        commit: 812c2852c59f1f532ea9b53d9bbe86231dd83fea
[09/25] ASoC: rt: use helper function
        commit: 8ec352362848d8cc9500ccfb051810597c0abf8a
[10/25] ASoC: cirrus: use helper function
        commit: 0e478b88b257049e1e22077b880419a431595645
[11/25] ASoC: spear: use helper function
        commit: c4d78c4127f9371dcfc77e71417addddcc5a9533
[12/25] ASoC: sdw-mockup: use helper function
        commit: e87abb83fc24a481ba490d8596969e1de3a16384
[13/25] ASoC: intel: use helper function
        commit: ec4b2099c6e01342e5c3289a906615c3abef85b8
[14/25] ASoC: mediatek: use helper function
        commit: 0df2ec8e4706a6adc36d12cc5cf8e1fa7485fbf5
[15/25] ASoC: meson: use helper function
        commit: c765ceda78f0bd9df1217f9beaefea58ecf3865c
[16/25] ASoC: rockchip: use helper function
        commit: 67cc242679b106909be52f8476e372dbb03c0a88
[17/25] ASoC: sof: use helper function
        commit: 323f09a61d43da2aff9b71e8a4764f4c9a88a5e0
[18/25] ASoC: tegra: use helper function
        commit: 1c1a778401b8ad04ae618eb8baa9a34a8b7e3d50
[19/25] ASoC: ti: use helper function
        commit: 2abde57fb82b4259b790212135b2194f2fd4dc7c
[20/25] ASoC: soc-core.c: use helper function
        commit: 9024bae4bb229c38522bb8c5dc45b82f9c27e0fc
[21/25] ASoC: soc-dapm.c: use helper function
        commit: 6855ec72102921814aaa43eab305b541af3e9757
[22/25] ASoC: soc-dai.c: use helper function
        commit: 8ede4b7109f618b3267a9577083b38984857a267
[23/25] ASoC: soc-pcm.c: use helper function
        commit: e15ff262e212387a05316dc465d754c0a62d9691
[24/25] ASoC: soc-topology.c: use helper function
        commit: 2b34c1359cca4812d7c8253ff70c394871c22590
[25/25] ASoC: soc-dai.h: cleanup Playback/Capture data for snd_soc_dai
        commit: 3653480c68120dc16ebfeb80e529200dbbd98f92

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark