mbox series

[v3,00/21] ASoC: cleanup DAI/Component activity

Message ID 87d0766n64.wl-kuninori.morimoto.gx@renesas.com (mailing list archive)
Headers show
Series ASoC: cleanup DAI/Component activity | expand

Message

Kuninori Morimoto May 15, 2020, 12:45 a.m. UTC 
Hi Mark

These are v3 of DAI/Component activity cleanup.

This patch-set exchanges soc-dapm.c :: snd_soc_dai_link_event_xxx()
behavior which updates dai->active but not cares other actives.
But I think original code was wrong.
So, I believe these works correctly, but maybe need some tests or deep review.

v1 -> v2
	- function naming "activity" -> "active"

v2 -> v3
	- macro -> inline function
	- added Reviewed-by from Ranjani, Acked-by from Peter

Link: https://lore.kernel.org/r/875zd39frp.wl-kuninori.morimoto.gx@renesas.com
Link: https://lore.kernel.org/r/87blmq9alx.wl-kuninori.morimoto.gx@renesas.com

Kuninori Morimoto (21):
  ASoC: soc-pcm: replace snd_soc_runtime_activate()/deactivate() to macro
  ASoC: soc-dai: add snd_soc_dai_action()
  ASoC: soc-dapm: use snd_soc_dai_activate()/deactivate()
  ASoC: soc-dai: add snd_soc_dai_active()
  ASoC: soc-component: add snd_soc_component_active()
  ASoC: soc-dai: add snd_soc_dai_stream_active()
  ASoC: use snd_soc_xxx_active()
  ASoC: atomel: use snd_soc_xxx_active()
  ASoC: bcm: use snd_soc_xxx_active()
  ASoC: cirrus: use snd_soc_xxx_active()
  ASoC: codecs: use snd_soc_xxx_active()
  ASoC: fsl: use snd_soc_xxx_active()
  ASoC: intel: use snd_soc_xxx_active()
  ASoC: jz4740: use snd_soc_xxx_active()
  ASoC: mediatek: use snd_soc_xxx_active()
  ASoC: meson: use snd_soc_xxx_active()
  ASoC: pxa: use snd_soc_xxx_active()
  ASoC: ti: use snd_soc_xxx_active()
  ASoC: uniphier: use snd_soc_xxx_active()
  ASoC: dwc: use snd_soc_xxx_active()
  ASoC: cleanup dai / component active code

 include/sound/soc-component.h                |  6 +-
 include/sound/soc-dai.h                      | 21 +++++-
 include/sound/soc.h                          | 15 ++++-
 sound/soc/atmel/atmel_ssc_dai.c              |  4 +-
 sound/soc/bcm/bcm2835-i2s.c                  |  6 +-
 sound/soc/bcm/cygnus-ssp.c                   |  4 +-
 sound/soc/cirrus/ep93xx-i2s.c                |  4 +-
 sound/soc/codecs/adav80x.c                   |  4 +-
 sound/soc/codecs/arizona.c                   |  2 +-
 sound/soc/codecs/cs4271.c                    |  4 +-
 sound/soc/codecs/madera.c                    |  2 +-
 sound/soc/codecs/max98090.c                  |  6 +-
 sound/soc/codecs/tlv320aic23.c               |  2 +-
 sound/soc/codecs/tlv320dac33.c               |  2 +-
 sound/soc/codecs/uda1380.c                   |  2 +-
 sound/soc/codecs/wl1273.c                    |  2 +-
 sound/soc/codecs/wm8711.c                    |  2 +-
 sound/soc/codecs/wm8753.c                    |  4 +-
 sound/soc/dwc/dwc-i2s.c                      |  2 +-
 sound/soc/fsl/fsl_esai.c                     |  2 +-
 sound/soc/fsl/fsl_spdif.c                    |  4 +-
 sound/soc/intel/atom/sst-mfld-platform-pcm.c | 14 ++--
 sound/soc/jz4740/jz4740-i2s.c                |  8 +--
 sound/soc/mediatek/mt8173/mt8173-afe-pcm.c   |  8 +--
 sound/soc/meson/axg-tdm-interface.c          |  2 +-
 sound/soc/pxa/pxa-ssp.c                      |  8 +--
 sound/soc/pxa/pxa2xx-i2s.c                   |  2 +-
 sound/soc/soc-compress.c                     |  4 +-
 sound/soc/soc-core.c                         | 11 +--
 sound/soc/soc-dai.c                          | 23 +++++++
 sound/soc/soc-dapm.c                         |  8 +--
 sound/soc/soc-pcm.c                          | 70 +++++++-------------
 sound/soc/ti/davinci-mcasp.c                 |  2 +-
 sound/soc/ti/omap-dmic.c                     |  4 +-
 sound/soc/ti/omap-mcbsp.c                    |  4 +-
 sound/soc/ti/omap-mcpdm.c                    |  8 +--
 sound/soc/uniphier/aio-cpu.c                 |  4 +-
 37 files changed, 155 insertions(+), 125 deletions(-)

Comments

Mark Brown May 18, 2020, 4:41 p.m. UTC | #1 
On 15 May 2020 09:45:39 +0900, Kuninori Morimoto wrote:
> These are v3 of DAI/Component activity cleanup.
> 
> This patch-set exchanges soc-dapm.c :: snd_soc_dai_link_event_xxx()
> behavior which updates dai->active but not cares other actives.
> But I think original code was wrong.
> So, I believe these works correctly, but maybe need some tests or deep review.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.8

Thanks!

[01/21] ASoC: soc-pcm: replace snd_soc_runtime_activate()/deactivate() to macro
        commit: d9051d86ad30ca1ef1fc99e29854daeeb3944f8f
[02/21] ASoC: soc-dai: add snd_soc_dai_action()
        commit: dc82910682ef06d5e5a81b4b359945b6f669ee3b
[03/21] ASoC: soc-dapm: use snd_soc_dai_activate()/deactivate()
        commit: 45eb8666e52d2d1733fda7353e48906d34a71e5d
[04/21] ASoC: soc-dai: add snd_soc_dai_active()
        commit: efffd9b344adbf813e3ae6f6136df80000bf2833
[05/21] ASoC: soc-component: add snd_soc_component_active()
        commit: 488b2ca599f96d46d4a4d730845a247328cb6a28
[06/21] ASoC: soc-dai: add snd_soc_dai_stream_active()
        commit: 5552f8d72893cea29a0074a3ea0a1a5766858fcd
[07/21] ASoC: use snd_soc_xxx_active()
        commit: b3dea624b52e8b18cd49f804ce70fe50374aa5db
[08/21] ASoC: atomel: use snd_soc_xxx_active()
        commit: e1c7e1faa404df564e64785c0b5cb7f1ee2d785d
[09/21] ASoC: bcm: use snd_soc_xxx_active()
        commit: 8ca4602d38c5140ae2cbeec9f1dd7803b0c4d61d
[10/21] ASoC: cirrus: use snd_soc_xxx_active()
        commit: 90a61a549df10082463c1ec37bc378799febe8a9
[11/21] ASoC: codecs: use snd_soc_xxx_active()
        commit: 5e518eddd11e8f71aaffc954dc7ee9572fc59808
[12/21] ASoC: fsl: use snd_soc_xxx_active()
        commit: 1d9fb19d8f644bfa17c79660b823b7ad07b0b046
[13/21] ASoC: intel: use snd_soc_xxx_active()
        commit: 846d0a17a8042ea753387b7571731d8265b87868
[14/21] ASoC: jz4740: use snd_soc_xxx_active()
        commit: 48afb287853effb07253bb2ccad2123f37770a8f
[15/21] ASoC: mediatek: use snd_soc_xxx_active()
        commit: 7995981bcfbc150902395af4191a77c9f4b842cd
[16/21] ASoC: meson: use snd_soc_xxx_active()
        commit: 1f79aab5a44871286d414eb2a289aaeea4236fd1
[17/21] ASoC: pxa: use snd_soc_xxx_active()
        commit: aaeb5fb59965217789258486080105337483a9e7
[18/21] ASoC: ti: use snd_soc_xxx_active()
        commit: 36ad1a87104e4a54f6acaffbe2d9533f80179e74
[19/21] ASoC: uniphier: use snd_soc_xxx_active()
        commit: 25d6755213f42ecf0c89f8619747be45e71382ac
[20/21] ASoC: dwc: use snd_soc_xxx_active()
        commit: 8db4f94fb3088528a8a64e2c39c8bf764a9433b0
[21/21] ASoC: cleanup dai / component active code
        commit: 0812a08ac8d054efc6cf2895d3b0e82c8731f8e9

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark