[v5,0/2] ASoC: simple-audio-mux: add state-labels

Message

Kuninori Morimoto July 1, 2024, 12:38 a.m. UTC

Hi Mark

simple-audio-mux is designed to be used generally, thus "Input 1" or
"Input 2" are used to selecting MUX input. This numbered inputs would work,
but might be not user friendly in some case, for example in case of system
hardware design has some clear labels.
Adds new "state-labels" property and enable to select MUX by own state names.

Original
	> amixer set "MUX" "Input 1"
	> amixer set "MUX" "Input 2"

Use mux-names
	sound_mux: mux {
		compatible = "simple-audio-mux";
		mux-gpios = <...>;
=>		state-labels = "Label_A", "Label_B";
	};

	> amixer set "MUX" "Label_A"
	> amixer set "MUX" "Label_B"

v4 -> v5
	- add maxItems
	- don't use "|" for description
	- tidyup patch Subject

v3 -> v4
	- add missing property type

v2 -> v3
	- expand example on Doc

v1 -> v2
	- update git-log explanation
	- update property description
	- change property name "mux-names" -> "state-labels"

Link: https://lore.kernel.org/r/[e-mail]
Link: https://lore.kernel.org/r/[e-mail]
Link: https://lore.kernel.org/r/[e-mail]
Link: https://lore.kernel.org/r/[e-mail]

Kuninori Morimoto (2):
  ASoC: simple-audio-mux: enable to select MUX names
  ASoC: dt-bindings: simple-audio-mux: add state-labels property

 .../bindings/sound/simple-audio-mux.yaml      |  6 ++
 sound/soc/codecs/simple-mux.c                 | 55 ++++++++++++++-----
 2 files changed, 46 insertions(+), 15 deletions(-)

Comments

Mark Brown July 2, 2024, 6:03 p.m. UTC | #1

On Mon, 01 Jul 2024 00:38:31 +0000, Kuninori Morimoto wrote:
> simple-audio-mux is designed to be used generally, thus "Input 1" or
> "Input 2" are used to selecting MUX input. This numbered inputs would work,
> but might be not user friendly in some case, for example in case of system
> hardware design has some clear labels.
> Adds new "state-labels" property and enable to select MUX by own state names.
> 
> Original
> 	> amixer set "MUX" "Input 1"
> 	> amixer set "MUX" "Input 2"
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: simple-audio-mux: enable to select MUX names
      commit: 3913ecb38833e8926467a17f1f1679ccd25a7230
[2/2] ASoC: dt-bindings: simple-audio-mux: add state-labels property
      commit: 9337f15f4fd6ebd35d911225c4a88ec82d27b2a2

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark