[00/12] ALSA/ASoC: use snd_pcm_direction_name()

Message

Kuninori Morimoto July 30, 2024, 2:04 a.m. UTC

Hi Tatasi, Mark

Many drivers are selecting strings "playback" / "capture" by own
handling, but we have snd_pcm_direction_name() function for it.
This patch use it.

One note is that snd_pcm_direction_name() will select
"Playback" and "Capture", instead of "playback" / "capture".
Almost all drivers are using it as dev_dbg() or dev_err()
so no problem. But some other drivers are using it as other
purpose. It might be issue (?). For example ASoC debugfs dir name
will be changed by this patch.

Kuninori Morimoto (12):
  ALSA: pci: pcxhr: use snd_pcm_direction_name()
  ALSA: pci: rme9652: use snd_pcm_direction_name()
  ALSA: trace: use snd_pcm_direction_name()
  ALSA: aloop: use snd_pcm_direction_name()
  ALSA: pcm_timer: use snd_pcm_direction_name()
  ASoC: stm: use snd_pcm_direction_name()
  ASoC: sof: pcm: use snd_pcm_direction_name()
  ASoC: sof: intel: use snd_pcm_direction_name()
  ASoC: fsl: lpc3xxx-i2s: use snd_pcm_direction_name()
  ASoC: tegra: use snd_pcm_direction_name()
  ASoC: soc-pcm: use snd_pcm_direction_name()
  ASoC: soc-dapm: use snd_pcm_direction_name()

 include/trace/events/asoc.h      |  3 ++-
 sound/core/pcm_timer.c           |  3 +--
 sound/drivers/aloop.c            |  3 +--
 sound/pci/pcxhr/pcxhr_mix22.c    |  2 +-
 sound/pci/rme9652/hdspm.c        |  6 ++----
 sound/soc/fsl/lpc3xxx-i2s.c      |  3 +--
 sound/soc/soc-dapm.c             |  3 +--
 sound/soc/soc-pcm.c              | 30 +++++++++++++++---------------
 sound/soc/sof/intel/hda-stream.c |  4 +---
 sound/soc/sof/pcm.c              |  2 +-
 sound/soc/stm/stm32_i2s.c        |  4 ++--
 sound/soc/tegra/tegra210_i2s.c   | 16 ++++++++--------
 12 files changed, 36 insertions(+), 43 deletions(-)

Comments

Takashi Iwai Aug. 1, 2024, 10:48 a.m. UTC | #1

On Tue, 30 Jul 2024 04:04:43 +0200,
Kuninori Morimoto wrote:
> 
> 
> Hi Tatasi, Mark
> 
> Many drivers are selecting strings "playback" / "capture" by own
> handling, but we have snd_pcm_direction_name() function for it.
> This patch use it.
> 
> One note is that snd_pcm_direction_name() will select
> "Playback" and "Capture", instead of "playback" / "capture".
> Almost all drivers are using it as dev_dbg() or dev_err()
> so no problem. But some other drivers are using it as other
> purpose. It might be issue (?). For example ASoC debugfs dir name
> will be changed by this patch.
> 
> Kuninori Morimoto (12):
>   ALSA: pci: pcxhr: use snd_pcm_direction_name()
>   ALSA: pci: rme9652: use snd_pcm_direction_name()
>   ALSA: trace: use snd_pcm_direction_name()
>   ALSA: aloop: use snd_pcm_direction_name()
>   ALSA: pcm_timer: use snd_pcm_direction_name()
>   ASoC: stm: use snd_pcm_direction_name()
>   ASoC: sof: pcm: use snd_pcm_direction_name()
>   ASoC: sof: intel: use snd_pcm_direction_name()
>   ASoC: fsl: lpc3xxx-i2s: use snd_pcm_direction_name()
>   ASoC: tegra: use snd_pcm_direction_name()
>   ASoC: soc-pcm: use snd_pcm_direction_name()
>   ASoC: soc-dapm: use snd_pcm_direction_name()

Applied from patch 1 to 5 to for-next branch.
I leave the rest for ASoC to Mark.


thanks,

Takashi

Mark Brown Aug. 2, 2024, 5:35 p.m. UTC | #2

On Tue, 30 Jul 2024 02:04:43 +0000, Kuninori Morimoto wrote:
> Many drivers are selecting strings "playback" / "capture" by own
> handling, but we have snd_pcm_direction_name() function for it.
> This patch use it.
> 
> One note is that snd_pcm_direction_name() will select
> "Playback" and "Capture", instead of "playback" / "capture".
> Almost all drivers are using it as dev_dbg() or dev_err()
> so no problem. But some other drivers are using it as other
> purpose. It might be issue (?). For example ASoC debugfs dir name
> will be changed by this patch.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[06/12] ASoC: stm: use snd_pcm_direction_name()
        commit: 7dfdcde20179383d4acfee61692a22955d5a8217
[07/12] ASoC: sof: pcm: use snd_pcm_direction_name()
        commit: cda4aa0069b73e3404ee61864b4814ccc7b7a6ad
[08/12] ASoC: sof: intel: use snd_pcm_direction_name()
        commit: baa779902020d8921cf652944309d1284a63811c
[09/12] ASoC: fsl: lpc3xxx-i2s: use snd_pcm_direction_name()
        commit: 8156921e620827319460e8daa9831d731b0d75fd
[10/12] ASoC: tegra: use snd_pcm_direction_name()
        commit: d6db65bc62fd19915a9926e08b9cbcfbadd64291
[11/12] ASoC: soc-pcm: use snd_pcm_direction_name()
        commit: ebbd6703d4635d36b35f12a1365dfd7894c0ff12
[12/12] ASoC: soc-dapm: use snd_pcm_direction_name()
        commit: bb660132868b5208d6a5f2bd184425cf788f4ef9

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark