[0/5] ASoC: minor cleanup for soc_get_playback_capture()

Message

Kuninori Morimoto May 30, 2023, 12:49 a.m. UTC

Hi Mark

This is minor cleanup patches for soc_get_playback_capture().

Link: https://lore.kernel.org/r/[e-mail]
Link: https://lore.kernel.org/r/[e-mail]
Link: https://lore.kernel.org/r/[e-mail]

Kuninori Morimoto (5):
  ASoC: soc-pcm.c: indicate error if stream has no playback no capture
  ASoC: soc-pcm.c: use dai_link on soc_get_playback_capture()
  ASoC: soc-pcm.c: cleanup soc_get_playback_capture() error
  ASoC: soc-pcm.c: use temporary variable at soc_get_playback_capture()
  ASoC: soc-pcm.c: tidyup playback/capture_only at soc_get_playback_capture()

 sound/soc/soc-pcm.c | 58 ++++++++++++++++++++++++++-------------------
 1 file changed, 33 insertions(+), 25 deletions(-)

Comments

Pierre-Louis Bossart May 30, 2023, 7:50 p.m. UTC | #1

> This is minor cleanup patches for soc_get_playback_capture().
> 
> Link: https://lore.kernel.org/r/[e-mail]
> Link: https://lore.kernel.org/r/[e-mail]
> Link: https://lore.kernel.org/r/[e-mail]
> 
> Kuninori Morimoto (5):
>   ASoC: soc-pcm.c: indicate error if stream has no playback no capture
>   ASoC: soc-pcm.c: use dai_link on soc_get_playback_capture()
>   ASoC: soc-pcm.c: cleanup soc_get_playback_capture() error
>   ASoC: soc-pcm.c: use temporary variable at soc_get_playback_capture()
>   ASoC: soc-pcm.c: tidyup playback/capture_only at soc_get_playback_capture()

Very nice cleanup, thank you Morimoto-san for splitting the steps in
different patches to make the changes simple to identify.

Reviewed-by: Pierre-Louis Bossart <[e-mail]>

FWIW test results can be found at the following link (no new issues
found) https://github.com/thesofproject/linux/pull/4392

Mark Brown May 31, 2023, 3:38 p.m. UTC | #2

On Tue, 30 May 2023 00:49:27 +0000, Kuninori Morimoto wrote:
> This is minor cleanup patches for soc_get_playback_capture().
> 
> Link: https://lore.kernel.org/r/[e-mail]
> Link: https://lore.kernel.org/r/[e-mail]
> Link: https://lore.kernel.org/r/[e-mail]
> 
> Kuninori Morimoto (5):
>   ASoC: soc-pcm.c: indicate error if stream has no playback no capture
>   ASoC: soc-pcm.c: use dai_link on soc_get_playback_capture()
>   ASoC: soc-pcm.c: cleanup soc_get_playback_capture() error
>   ASoC: soc-pcm.c: use temporary variable at soc_get_playback_capture()
>   ASoC: soc-pcm.c: tidyup playback/capture_only at soc_get_playback_capture()
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/5] ASoC: soc-pcm.c: indicate error if stream has no playback no capture
      commit: 092830cf550667d5fa6286605167d232f2c1f61e
[2/5] ASoC: soc-pcm.c: use dai_link on soc_get_playback_capture()
      commit: cfcb31c456b15e298f88fb5ebedf7b32b009d32d
[3/5] ASoC: soc-pcm.c: cleanup soc_get_playback_capture() error
      commit: a1c0221fa5baeae6c9dc30294c2c6d01f1f4379b
[4/5] ASoC: soc-pcm.c: use temporary variable at soc_get_playback_capture()
      commit: c3e9b6d6ef5a0a3e841c3aa29e7afc48a0b73806
[5/5] ASoC: soc-pcm.c: tidyup playback/capture_only at soc_get_playback_capture()
      commit: e1f653ce847bab7285dd135cabe3ce544e574c75

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark