| Message ID | cover.1703284359.git.u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | irqchip: Convert to platform remove callback returning void | expand |
Hello Thomas, On Fri, Dec 22, 2023 at 11:50:31PM +0100, Uwe Kleine-König wrote: > this series converts all drivers below drivers/irqchip to use > .remove_new(). See commit 5c5a7680e67b ("platform: Provide a remove > callback that returns no value") for an extended explanation and the > eventual goal. The TL;DR; is to make it harder for driver authors to > leak resources. > > The drivers touched here are all fine though and don't return early in > .remove(). So all conversions in this series are trivial. I'm still waiting for this series to go in (or get review feedback). Is this still on your radar? You're the right maintainer to take this series, aren't you? The series still applies to today's next. Best regards Uwe
On Thu, Feb 15 2024 at 22:03, Uwe Kleine-König wrote: > On Fri, Dec 22, 2023 at 11:50:31PM +0100, Uwe Kleine-König wrote: >> this series converts all drivers below drivers/irqchip to use >> .remove_new(). See commit 5c5a7680e67b ("platform: Provide a remove >> callback that returns no value") for an extended explanation and the >> eventual goal. The TL;DR; is to make it harder for driver authors to >> leak resources. >> >> The drivers touched here are all fine though and don't return early in >> .remove(). So all conversions in this series are trivial. > > I'm still waiting for this series to go in (or get review feedback). Is > this still on your radar? You're the right maintainer to take this > series, aren't you? I am and it fell through my christmas crack. I don't even try to catch up with email after being almost 3 weeks AFK. For two decades I rely on submitters to ping me after a couple of weeks or month in this case :) Thanks, tglx
this series converts all drivers below drivers/irqchip to use .remove_new(). See commit 5c5a7680e67b ("platform: Provide a remove callback that returns no value") for an extended explanation and the eventual goal. The TL;DR; is to make it harder for driver authors to leak resources. The drivers touched here are all fine though and don't return early in .remove(). So all conversions in this series are trivial. Best regards Uwe Uwe Kleine-König (13): irqchip/imgpdc: Convert to platform remove callback returning void irqchip/imx-intmux: Convert to platform remove callback returning void irqchip/imx-irqsteer: Convert to platform remove callback returning void irqchip/keystone: Convert to platform remove callback returning void irqchip/ls-scfg-msi: Convert to platform remove callback returning void irqchip/madera: Convert to platform remove callback returning void irqchip/mvebu-pic: Convert to platform remove callback returning void irqchip/pruss-intc: Convert to platform remove callback returning void irqchip/renesas-intc-irqpin: Convert to platform remove callback returning void irqchip/renesas-irqc: Convert to platform remove callback returning void irqchip/renesas-rza1: Convert to platform remove callback returning void irqchip/stm32-exti: Convert to platform remove callback returning void irqchip/ts4800: Convert to platform remove callback returning void drivers/irqchip/irq-imgpdc.c | 5 ++--- drivers/irqchip/irq-imx-intmux.c | 6 ++---- drivers/irqchip/irq-imx-irqsteer.c | 6 ++---- drivers/irqchip/irq-keystone.c | 5 ++--- drivers/irqchip/irq-ls-scfg-msi.c | 6 ++---- drivers/irqchip/irq-madera.c | 6 ++---- drivers/irqchip/irq-mvebu-pic.c | 6 ++---- drivers/irqchip/irq-pruss-intc.c | 6 ++---- drivers/irqchip/irq-renesas-intc-irqpin.c | 5 ++--- drivers/irqchip/irq-renesas-irqc.c | 5 ++--- drivers/irqchip/irq-renesas-rza1.c | 5 ++--- drivers/irqchip/irq-stm32-exti.c | 5 ++--- drivers/irqchip/irq-ts4800.c | 6 ++---- 13 files changed, 26 insertions(+), 46 deletions(-) base-commit: 39676dfe52331dba909c617f213fdb21015c8d10