| Message ID | 08a882fa7a3145bc33bc02392df8319e95092dcf.1605896060.git.gustavoars@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fix fall-through warnings for Clang | expand |
On 20/11/2020 18:39, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of letting the code fall > through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > --- Applied thanks, srini > drivers/slimbus/messaging.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/slimbus/messaging.c b/drivers/slimbus/messaging.c > index d5879142dbef..f2b5d347d227 100644 > --- a/drivers/slimbus/messaging.c > +++ b/drivers/slimbus/messaging.c > @@ -258,6 +258,7 @@ int slim_xfer_msg(struct slim_device *sbdev, struct slim_val_inf *msg, > case SLIM_MSG_MC_REQUEST_CLEAR_INFORMATION: > case SLIM_MSG_MC_CLEAR_INFORMATION: > txn->rl += msg->num_bytes; > + break; > default: > break; > } >
On Tue, Nov 24, 2020 at 10:48:04AM +0000, Srinivas Kandagatla wrote: > > > On 20/11/2020 18:39, Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > > by explicitly adding a break statement instead of letting the code fall > > through to the next case. > > > > Link: https://github.com/KSPP/linux/issues/115 > > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > > --- > > > Applied thanks, Thank you, Srini. -- Gustavo
diff --git a/drivers/slimbus/messaging.c b/drivers/slimbus/messaging.c index d5879142dbef..f2b5d347d227 100644 --- a/drivers/slimbus/messaging.c +++ b/drivers/slimbus/messaging.c @@ -258,6 +258,7 @@ int slim_xfer_msg(struct slim_device *sbdev, struct slim_val_inf *msg, case SLIM_MSG_MC_REQUEST_CLEAR_INFORMATION: case SLIM_MSG_MC_CLEAR_INFORMATION: txn->rl += msg->num_bytes; + break; default: break; }
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> --- drivers/slimbus/messaging.c | 1 + 1 file changed, 1 insertion(+)