From patchwork Wed Feb 12 16:09:23 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kepplinger-Novakovic X-Patchwork-Id: 3639091 X-Patchwork-Delegate: tiwai@suse.de Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 146379F334 for ; Wed, 12 Feb 2014 16:26:28 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1B15A201FA for ; Wed, 12 Feb 2014 16:26:27 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id E431B201ED for ; Wed, 12 Feb 2014 16:26:25 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 024E7265146; Wed, 12 Feb 2014 17:26:24 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 995B126109E; Wed, 12 Feb 2014 17:25:47 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id DFD3326506D; Wed, 12 Feb 2014 17:10:07 +0100 (CET) Received: from mx02a.posteo.de (mx02a.posteo.de [89.146.194.168]) by alsa0.perex.cz (Postfix) with ESMTP id 373AD265010 for ; Wed, 12 Feb 2014 17:10:01 +0100 (CET) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.posteo.de (Postfix) with ESMTP id CBDAF25C0099; Wed, 12 Feb 2014 16:10:00 +0000 (UTC) X-Virus-Scanned: amavisd-new at posteo.de Received: from posteo.de ([10.125.125.134]) by localhost (amavis1.posteo.de [10.125.125.165]) (amavisd-new, port 10026) with ESMTP id OZI_7SGTbvSh; Wed, 12 Feb 2014 17:09:48 +0100 (CET) Received: from mail.posteo.de (localhost [127.0.0.1]) by mail.posteo.de (Postfix) with ESMTPSA id D3B9320477115; Wed, 12 Feb 2014 17:09:44 +0100 (CET) From: Martin Kepplinger To: perex@perex.cz Date: Wed, 12 Feb 2014 17:09:23 +0100 Message-Id: <1392221363-5447-1-git-send-email-martink@posteo.de> X-Mailer: git-send-email 1.7.10.4 X-Mailman-Approved-At: Wed, 12 Feb 2014 17:25:45 +0100 Cc: alsa-devel@alsa-project.org, tiwai@suse.de, linux-kernel@vger.kernel.org, hui.wang@canonical.com, Martin Kepplinger , david.henningsson@canonical.com Subject: [alsa-devel] [BUG]3.14-rc2 [PATCH] Revert "ALSA: hda/realtek - Avoid invalid COEFs for ALC271X" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP This reverts commit d3c56568f43807135f2c2a09582a69f809f0d8b7. The reverted commit breaks audio through headphone line out on the Acer TravelMate B113 (Type1Sku0) Notebook, my main work machine. I don't know much about it but this fixes my problem. Bisected and tested. Tested-by: Martin Kepplinger Signed-off-by: Martin Kepplinger --- sound/pci/hda/patch_realtek.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index d9693ca..0f5af34 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -4434,9 +4434,6 @@ static void alc269_fill_coef(struct hda_codec *codec) if (spec->codec_variant != ALC269_TYPE_ALC269VB) return; - /* ALC271X doesn't seem to support these COEFs (bko#52181) */ - if (!strcmp(codec->chip_name, "ALC271X")) - return; if ((alc_get_coef0(codec) & 0x00ff) < 0x015) { alc_write_coef_idx(codec, 0xf, 0x960b);