| Message ID | 1396029905-6807-1-git-send-email-zonque@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2ad76541026ba5c6c93b5a5a6f1418aa89fa5f34 |
| Headers | show |
On Fri, Mar 28, 2014 at 07:05:04PM +0100, Daniel Mack wrote: > Document the newly added regulators to the DT binding document. > > Also, "static const char const *x" is not identical to "static const > char * const x", which sparse now complains about. Fix it. Applied, though this should really have been two patches as there's no overlap.
On 03/29/2014 11:17 AM, Mark Brown wrote: > On Fri, Mar 28, 2014 at 07:05:04PM +0100, Daniel Mack wrote: >> Document the newly added regulators to the DT binding document. >> >> Also, "static const char const *x" is not identical to "static const >> char * const x", which sparse now complains about. Fix it. > > Applied, though this should really have been two patches as there's no > overlap. > Hmm, for some reason, this patch didn't make it to mainline yet. Same for another one that patches the same file which I sent the same day. Want me to resend? Thanks, Daniel
On Wed, Jun 18, 2014 at 05:12:49PM +0200, Daniel Mack wrote: > Hmm, for some reason, this patch didn't make it to mainline yet. Same > for another one that patches the same file which I sent the same day. > Want me to resend? It's probably poor network connectivity to kernel.org at the time I applied them but I can't tell any more. They should be there now.
diff --git a/Documentation/devicetree/bindings/sound/ak5386.txt b/Documentation/devicetree/bindings/sound/ak5386.txt index dc3914f..ec3df3a 100644 --- a/Documentation/devicetree/bindings/sound/ak5386.txt +++ b/Documentation/devicetree/bindings/sound/ak5386.txt @@ -10,10 +10,14 @@ Optional properties: - reset-gpio : a GPIO spec for the reset/power down pin. If specified, it will be deasserted at probe time. + - va-supply : a regulator spec, providing 5.0V + - vd-supply : a regulator spec, providing 3.3V Example: spdif: ak5386@0 { compatible = "asahi-kasei,ak5386"; reset-gpio = <&gpio0 23>; + va-supply = <&vdd_5v0_reg>; + vd-supply = <&vdd_3v3_reg>; }; diff --git a/sound/soc/codecs/ak5386.c b/sound/soc/codecs/ak5386.c index a30be5c..8107a1c 100644 --- a/sound/soc/codecs/ak5386.c +++ b/sound/soc/codecs/ak5386.c @@ -19,7 +19,7 @@ #include <sound/pcm.h> #include <sound/initval.h> -static const char const *supply_names[] = { +static const char * const supply_names[] = { "va", "vd" };
Document the newly added regulators to the DT binding document. Also, "static const char const *x" is not identical to "static const char * const x", which sparse now complains about. Fix it. Signed-off-by: Daniel Mack <zonque@gmail.com> --- Documentation/devicetree/bindings/sound/ak5386.txt | 4 ++++ sound/soc/codecs/ak5386.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-)