| Message ID | 1396713875.9878.0.camel@phoenix (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a14bf88749c5b54bb9c636bcd47c26ea79560ce5 |
| Headers | show |
On Sun, Apr 06, 2014 at 12:04:35AM +0800, Axel Lin wrote: > BIT[0:2] of register 01h is REVID, so the mask for REVID should be 0x7. > Also updates the code to use CS42L52_CHIP_REV_MASK. Applied, thanks.
diff --git a/sound/soc/codecs/cs42l52.c b/sound/soc/codecs/cs42l52.c index f0ca6be..460d355 100644 --- a/sound/soc/codecs/cs42l52.c +++ b/sound/soc/codecs/cs42l52.c @@ -1259,7 +1259,7 @@ static int cs42l52_i2c_probe(struct i2c_client *i2c_client, } dev_info(&i2c_client->dev, "Cirrus Logic CS42L52, Revision: %02X\n", - reg & 0xFF); + reg & CS42L52_CHIP_REV_MASK); /* Set Platform Data */ if (cs42l52->pdata.mica_diff_cfg) diff --git a/sound/soc/codecs/cs42l52.h b/sound/soc/codecs/cs42l52.h index 6fb8f00..ac445993 100644 --- a/sound/soc/codecs/cs42l52.h +++ b/sound/soc/codecs/cs42l52.h @@ -37,7 +37,7 @@ #define CS42L52_CHIP_REV_A0 0x00 #define CS42L52_CHIP_REV_A1 0x01 #define CS42L52_CHIP_REV_B0 0x02 -#define CS42L52_CHIP_REV_MASK 0x03 +#define CS42L52_CHIP_REV_MASK 0x07 #define CS42L52_PWRCTL1 0x02 #define CS42L52_PWRCTL1_PDN_ALL 0x9F
BIT[0:2] of register 01h is REVID, so the mask for REVID should be 0x7. Also updates the code to use CS42L52_CHIP_REV_MASK. Signed-off-by: Axel Lin <axel.lin@ingics.com> --- sound/soc/codecs/cs42l52.c | 2 +- sound/soc/codecs/cs42l52.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)