diff mbox

[2/2] ASoC: cs42l73: Convert to use devm_gpio_request_one

Message ID 1396966300.14167.2.camel@phoenix (mailing list archive)
State Accepted
Commit 2b21694f153a0df88dca7fb4ce04614ea7ff9dc2
Headers show

Commit Message

Axel Lin April 8, 2014, 2:11 p.m. UTC 
Current code missed a gpio_free() call in cs42l73_i2c_remove().
Convert to use devm_gpio_request_one() to fix it.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 sound/soc/codecs/cs42l73.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Mark Brown April 18, 2014, 2:38 p.m. UTC | #1 
On Tue, Apr 08, 2014 at 10:11:40PM +0800, Axel Lin wrote:
> Current code missed a gpio_free() call in cs42l73_i2c_remove().
> Convert to use devm_gpio_request_one() to fix it.

Applied, thanks.
diff mbox

Patch

diff --git a/sound/soc/codecs/cs42l73.c b/sound/soc/codecs/cs42l73.c
index 0ee60a1..ae37179 100644
--- a/sound/soc/codecs/cs42l73.c
+++ b/sound/soc/codecs/cs42l73.c
@@ -1443,8 +1443,10 @@  static int cs42l73_i2c_probe(struct i2c_client *i2c_client,
 	i2c_set_clientdata(i2c_client, cs42l73);
 
 	if (cs42l73->pdata.reset_gpio) {
-		ret = gpio_request_one(cs42l73->pdata.reset_gpio,
-				       GPIOF_OUT_INIT_HIGH, "CS42L73 /RST");
+		ret = devm_gpio_request_one(&i2c_client->dev,
+					    cs42l73->pdata.reset_gpio,
+					    GPIOF_OUT_INIT_HIGH,
+					    "CS42L73 /RST");
 		if (ret < 0) {
 			dev_err(&i2c_client->dev, "Failed to request /RST %d: %d\n",
 				cs42l73->pdata.reset_gpio, ret);