From patchwork Thu Apr 10 16:45:08 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tim Gardner X-Patchwork-Id: 3971831 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 66FBB9F370 for ; Fri, 11 Apr 2014 18:50:46 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5BFE6202F0 for ; Fri, 11 Apr 2014 18:50:45 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 36C14202E9 for ; Fri, 11 Apr 2014 18:50:44 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id AFF1126513F; Fri, 11 Apr 2014 20:50:42 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_DNS_FOR_FROM, UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 8A24B2655DE; Fri, 11 Apr 2014 12:42:34 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id EEE1B2655DE; Fri, 11 Apr 2014 12:42:33 +0200 (CEST) Received: from mail.tpi.com (mail.tpi.com [74.45.170.26]) by alsa0.perex.cz (Postfix) with ESMTP id 0A241267B35 for ; Thu, 10 Apr 2014 20:02:42 +0200 (CEST) Received: from salmon.rtg.net (mail.tpi.com [10.0.0.205]) by mail.tpi.com (Postfix) with ESMTP id EFE28353080; Thu, 10 Apr 2014 11:02:40 -0700 (PDT) Received: by salmon.rtg.net (Postfix, from userid 1000) id F0C79246A0; Thu, 10 Apr 2014 10:45:48 -0600 (MDT) From: Tim Gardner To: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Date: Thu, 10 Apr 2014 10:45:08 -0600 Message-Id: <1397148308-43791-1-git-send-email-tim.gardner@canonical.com> X-Mailer: git-send-email 1.7.9.5 Cc: Lars-Peter Clausen , Mark Brown , Takashi Iwai , JongHo Kim , Tim Gardner Subject: [alsa-devel] [PATCH] ALSA: pcm: 'BUG:' message unnecessarily triggers kerneloops X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP BugLink: http://bugs.launchpad.net/bugs/1305480 The kerneloops-daemon scans dmesg for common crash signatures, among which is 'BUG:'. The message emitted by the PCM library is really a warning, so the most expedient thing to do seems to be to change the string. Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Mark Brown Cc: Lars-Peter Clausen Cc: JongHo Kim Signed-off-by: Tim Gardner --- sound/core/pcm_lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c index ce83def..2a0563d 100644 --- a/sound/core/pcm_lib.c +++ b/sound/core/pcm_lib.c @@ -345,7 +345,7 @@ static int snd_pcm_update_hw_ptr0(struct snd_pcm_substream *substream, snd_pcm_debug_name(substream, name, sizeof(name)); xrun_log_show(substream); pcm_err(substream->pcm, - "BUG: %s, pos = %ld, buffer size = %ld, period size = %ld\n", + "OVER RUN: %s, pos = %ld, buffer size = %ld, period size = %ld\n", name, pos, runtime->buffer_size, runtime->period_size); }