From patchwork Fri Jun 13 04:27:45 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 4348981 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id B5600BEEAA for ; Fri, 13 Jun 2014 12:54:25 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DC1692022A for ; Fri, 13 Jun 2014 12:54:24 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id F084320211 for ; Fri, 13 Jun 2014 12:54:22 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id F2349264F23; Fri, 13 Jun 2014 14:54:21 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, NO_DNS_FOR_FROM, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 38CCB2610B9; Fri, 13 Jun 2014 14:49:46 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id B24D32610B7; Fri, 13 Jun 2014 06:30:48 +0200 (CEST) Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53]) by alsa0.perex.cz (Postfix) with ESMTP id 7811C2610A7 for ; Fri, 13 Jun 2014 06:30:40 +0200 (CEST) Received: by mail-pa0-f53.google.com with SMTP id kx10so1691015pab.40 for ; Thu, 12 Jun 2014 21:30:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id; bh=p3e69OtionUph1Xjh0FecNvzc0XDU0tDKzfhtsazfkA=; b=LRfF0xB2u3egQp4HWWn5vvD516XOvv+6QF4AU9jxZXfsbRLHDF0DaMV+OZvxpHyTdS ezWL87LzeR8Jwj3lnOvBP0dofswr/35t+CyoO6o6iy4sg5AGJ4/2TL+1XoOLJBt1Ay/D E9NYqLWfNXew4VvZ7rSlq45PMjsI9f0qMoOtNkQzcJtYroRY0L2IJZhsyLTe0kHE7gIw 9sfPXuvrD/RFQ6dLlu7Mttth5vmmhptpL3jWsdu457fEZ70qLXXybIys66zkfyWJAREE Pp8xLzJrstEmvffFmUPk68j7bU5vzaD45ooXS7q+zwQuLunn4YPBJA6N6hHYbwD8egww xGYw== X-Received: by 10.66.233.101 with SMTP id tv5mr345404pac.92.1402633839000; Thu, 12 Jun 2014 21:30:39 -0700 (PDT) Received: from linaro.sisodomain.com ([14.140.216.146]) by mx.google.com with ESMTPSA id av2sm1003533pbc.16.2014.06.12.21.30.35 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 12 Jun 2014 21:30:38 -0700 (PDT) From: Sachin Kamat To: alsa-devel@alsa-project.org Date: Fri, 13 Jun 2014 09:57:45 +0530 Message-Id: <1402633665-17071-1-git-send-email-sachin.kamat@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Mailman-Approved-At: Fri, 13 Jun 2014 14:49:43 +0200 Cc: s.hauer@pengutronix.de, broonie@kernel.org, spk.linux@gmail.com, lgirdwood@gmail.com Subject: [alsa-devel] [PATCH 1/1] ASoC: mc13783: Add missing of_node_put X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP of_get_child_by_name expects of_node_put be called when done. Signed-off-by: Sachin Kamat --- sound/soc/codecs/mc13783.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/mc13783.c b/sound/soc/codecs/mc13783.c index 9965277b595a..388f90a597fa 100644 --- a/sound/soc/codecs/mc13783.c +++ b/sound/soc/codecs/mc13783.c @@ -766,11 +766,11 @@ static int __init mc13783_codec_probe(struct platform_device *pdev) ret = of_property_read_u32(np, "adc-port", &priv->adc_ssi_port); if (ret) - return ret; + goto out; ret = of_property_read_u32(np, "dac-port", &priv->dac_ssi_port); if (ret) - return ret; + goto out; } dev_set_drvdata(&pdev->dev, priv); @@ -783,6 +783,8 @@ static int __init mc13783_codec_probe(struct platform_device *pdev) ret = snd_soc_register_codec(&pdev->dev, &soc_codec_dev_mc13783, mc13783_dai_async, ARRAY_SIZE(mc13783_dai_async)); +out: + of_node_put(np); return ret; }