From patchwork Sun Jun 15 23:39:45 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anssi Hannula X-Patchwork-Id: 4355541 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id F1395BEEAA for ; Sun, 15 Jun 2014 23:40:31 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 13E682022D for ; Sun, 15 Jun 2014 23:40:30 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id B08682020E for ; Sun, 15 Jun 2014 23:40:28 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id EFBC2265310; Mon, 16 Jun 2014 01:40:26 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_DNS_FOR_FROM, UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id C22272652E3; Mon, 16 Jun 2014 01:40:15 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 6C2672652E6; Mon, 16 Jun 2014 01:40:14 +0200 (CEST) Received: from mail3.ippnet.fi (mail3.ippnet.fi [62.197.168.3]) by alsa0.perex.cz (Postfix) with ESMTP id 6CAC32652DA for ; Mon, 16 Jun 2014 01:40:06 +0200 (CEST) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail3.ippnet.fi (Postfix) with ESMTP id 34E355D808; Mon, 16 Jun 2014 02:41:46 +0300 (EEST) X-Virus-Scanned: amavisd-new at kemia.fi Received: from mail3.ippnet.fi ([127.0.0.1]) by localhost (kone16815.ippnet.fi [127.0.0.1]) (amavisd-new, port 10030) with ESMTP id LAo6ywv2URyZ; Mon, 16 Jun 2014 02:41:42 +0300 (EEST) Received: from webmail.tpnet.fi (webmail.tpnet.fi [62.106.63.33]) by mail3.ippnet.fi (Postfix) with ESMTP id C86E35D790; Mon, 16 Jun 2014 02:41:39 +0300 (EEST) Received: from mail.onse.fi (host-109-204-178-176.tp-fne.tampereenpuhelin.net [109.204.178.176]) by webmail.tpnet.fi (Postfix) with ESMTP id D6BBB2073E; Mon, 16 Jun 2014 02:39:58 +0300 (EEST) Received: by mail.onse.fi (Postfix, from userid 501) id 95C3F40219; Mon, 16 Jun 2014 02:39:58 +0300 (EEST) From: Anssi Hannula To: Shawn Guo Date: Mon, 16 Jun 2014 02:39:45 +0300 Message-Id: <1402875585-29025-2-git-send-email-anssi.hannula@iki.fi> X-Mailer: git-send-email 1.8.4.5 In-Reply-To: <1402875585-29025-1-git-send-email-anssi.hannula@iki.fi> References: <1402875585-29025-1-git-send-email-anssi.hannula@iki.fi> Cc: alsa-devel@alsa-project.org, Mark Brown , linux-arm-kernel@lists.infradead.org, Nicolin Chen Subject: [alsa-devel] [PATCH 2/2] ARM: dts: imx6: remove non-working spdif rxtx4 and rxtx6 clocks X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP The S/PDIF rxtx4 and rxtx6 clock inputs are "ESAI_HCKT" and "MLB clock", respectively, according to the SoC documentation, and they are currently mapped to clocks "esai" and "mlb". However, they do not seem to actually work correctly. Testing on a Cubox-i system with fsl_spdif driver forced to select one of those as input will result in I/O errors on audio playback, which I believe means missing clock signal. Possibly the "ESAI_HCKT" and "MLB clock" refer to some other clocks related to ESAI and MLB, or we are missing something else. Since audio playback will not work if fsl_spdif selects these clocks (which happens rarely), set the inputs do dummy clocks, at least for now. Signed-off-by: Anssi Hannula Cc: Nicolin Chen Cc: Mark Brown --- Does anyone know what is wrong here? i.e. are the clocks actually wrong or are we maybe doing something wrong with their setup? Also, is this the correct way to "fix" the issue, or should we rather modify the driver to not select rxtx4/rxtx6 for now (assuming no one knows how to fix this properly, of course)? (I haven't been involved with device trees before) arch/arm/boot/dts/imx6qdl.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index 3aef9a2f5fda..f0d1c2334952 100644 --- a/arch/arm/boot/dts/imx6qdl.dtsi +++ b/arch/arm/boot/dts/imx6qdl.dtsi @@ -182,8 +182,8 @@ dma-names = "rx", "tx"; clocks = <&clks 197>, <&clks 3>, <&clks 197>, <&clks 0>, - <&clks 0>, <&clks 118>, - <&clks 0>, <&clks 139>, + <&clks 0>, <&clks 0>, + <&clks 0>, <&clks 0>, <&clks 0>; clock-names = "core", "rxtx0", "rxtx1", "rxtx2",