diff mbox

[2/5] ASoC: cs42xx8: Make of match table static

Message ID 1403163631-26215-3-git-send-email-lars@metafoo.de (mailing list archive)
State Accepted
Commit afb7bb45bb904da3704aad47adc4615a81f515c5
Headers show

Commit Message

Lars-Peter Clausen June 19, 2014, 7:40 a.m. UTC 
The cs42xx8_of_match table is not used outside of the driver, hence it can and
should be made static.

Fixes the following warning from sparse:
	sound/soc/codecs/cs42xx8.c:425:27: warning: symbol 'cs42xx8_of_match' was
	not declared. Should it be static?

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
 sound/soc/codecs/cs42xx8.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Austin, Brian June 19, 2014, 1:50 p.m. UTC | #1 
On Thu, 19 Jun 2014, Lars-Peter Clausen wrote:

> The cs42xx8_of_match table is not used outside of the driver, hence it can and
> should be made static.
>
> Fixes the following warning from sparse:
> 	sound/soc/codecs/cs42xx8.c:425:27: warning: symbol 'cs42xx8_of_match' was
> 	not declared. Should it be static?
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Brian Austin <brian.austin@cirrus.com>

Thanks,
Mark Brown June 21, 2014, 7:58 p.m. UTC | #2 
On Thu, Jun 19, 2014 at 09:40:28AM +0200, Lars-Peter Clausen wrote:
> The cs42xx8_of_match table is not used outside of the driver, hence it can and
> should be made static.

Applied, thanks.
diff mbox

Patch

diff --git a/sound/soc/codecs/cs42xx8.c b/sound/soc/codecs/cs42xx8.c
index a25bc60..ec53ffc 100644
--- a/sound/soc/codecs/cs42xx8.c
+++ b/sound/soc/codecs/cs42xx8.c
@@ -422,7 +422,7 @@  const struct cs42xx8_driver_data cs42888_data = {
 };
 EXPORT_SYMBOL_GPL(cs42888_data);
 
-const struct of_device_id cs42xx8_of_match[] = {
+static const struct of_device_id cs42xx8_of_match[] = {
 	{ .compatible = "cirrus,cs42448", .data = &cs42448_data, },
 	{ .compatible = "cirrus,cs42888", .data = &cs42888_data, },
 	{ /* sentinel */ }