| Message ID | 1403163631-26215-4-git-send-email-lars@metafoo.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 76a77f47123945f6e5a4dd167e54768012ef9669 |
| Headers | show |
On Thu, Jun 19, 2014 at 09:40:29AM +0200, Lars-Peter Clausen wrote: > omap_pcm_platform_register() is declared in omap-pcm.h and defined in > omap-pcm.c. To make sure that the function signature matches for both omap-pcm.c > should include omap-pcm.h Applied, thanks.
On 06/21/2014 10:00 PM, Mark Brown wrote: > On Thu, Jun 19, 2014 at 09:40:29AM +0200, Lars-Peter Clausen wrote: >> omap_pcm_platform_register() is declared in omap-pcm.h and defined in >> omap-pcm.c. To make sure that the function signature matches for both omap-pcm.c >> should include omap-pcm.h > > Applied, thanks. This patch somehow did not make it, the patch is not in asoc/next, nor is there a asoc/topic/omap or similar. Shall I resend? Thanks, - Lars
On Mon, Jun 30, 2014 at 06:48:33PM +0200, Lars-Peter Clausen wrote: > On 06/21/2014 10:00 PM, Mark Brown wrote: > >Applied, thanks. > This patch somehow did not make it, the patch is not in asoc/next, nor is > there a asoc/topic/omap or similar. Shall I resend? It seems to be there?
On 06/30/2014 11:54 PM, Mark Brown wrote: > On Mon, Jun 30, 2014 at 06:48:33PM +0200, Lars-Peter Clausen wrote: >> On 06/21/2014 10:00 PM, Mark Brown wrote: > >>> Applied, thanks. > >> This patch somehow did not make it, the patch is not in asoc/next, nor is >> there a asoc/topic/omap or similar. Shall I resend? > > It seems to be there? > Now it is. Thanks, - Lars
diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c index 8d809f8..f4b05bc 100644 --- a/sound/soc/omap/omap-pcm.c +++ b/sound/soc/omap/omap-pcm.c @@ -31,6 +31,7 @@ #include <sound/pcm_params.h> #include <sound/dmaengine_pcm.h> #include <sound/soc.h> +#include <sound/omap-pcm.h> #ifdef CONFIG_ARCH_OMAP1 #define pcm_omap1510() cpu_is_omap1510()
omap_pcm_platform_register() is declared in omap-pcm.h and defined in omap-pcm.c. To make sure that the function signature matches for both omap-pcm.c should include omap-pcm.h Fixes the following warning from sparse: sound/soc/omap/omap-pcm.c:235:5: warning: symbol 'omap_pcm_platform_register' was not declared. Should it be static? Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> --- sound/soc/omap/omap-pcm.c | 1 + 1 file changed, 1 insertion(+)