From patchwork Fri Jun 20 09:59:12 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 4387841 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 7123CBEEAA for ; Fri, 20 Jun 2014 10:15:42 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BB391203B6 for ; Fri, 20 Jun 2014 10:15:41 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 99CDF203AF for ; Fri, 20 Jun 2014 10:15:40 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 5E09A26571B; Fri, 20 Jun 2014 12:15:32 +0200 (CEST) Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 285B226525B; Fri, 20 Jun 2014 12:05:39 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 5E131265167; Fri, 20 Jun 2014 12:05:32 +0200 (CEST) Received: from mail-pd0-f169.google.com (mail-pd0-f169.google.com [209.85.192.169]) by alsa0.perex.cz (Postfix) with ESMTP id C29D52650BD for ; Fri, 20 Jun 2014 12:03:13 +0200 (CEST) Received: by mail-pd0-f169.google.com with SMTP id g10so2830766pdj.28 for ; Fri, 20 Jun 2014 03:03:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=/L17NvjjymSZ+33FdivLfPv0tQh8pKSlVYQoGrH1+fI=; b=DZ1f/ExM2VffcmV0vpncgKHaX+IFDIqavOl16LVI7y4hDrbfI4Hb8kDFTw4PH/72ys syxFX6RrtvNsiZu1yuP+xz47p21cMz721N2tl601Z4ev02BTXXKFEy7sOlLTWj031AQu naEdhfleKkOr5uwejbUaojW6yahqH40wCbU4ADJboSUE6BzmzY2VXFLbxM+526lkK1LS GPuHEr4GG9/ffqHO5G6GjRAEjFKFvrNrzjIEdPWBjKv9VWvOxXum2s0knQpHoCkFmgLY zBvc0nMKZjjmguZu9nBI1fzypfHOIk4wtNjGbr1q9IbT/7cdNTAIKZn2goRLfR8cQQgx Vgfw== X-Received: by 10.68.130.38 with SMTP id ob6mr3117223pbb.141.1403258592817; Fri, 20 Jun 2014 03:03:12 -0700 (PDT) Received: from linaro.sisodomain.com ([14.140.216.146]) by mx.google.com with ESMTPSA id ha10sm12718305pbd.1.2014.06.20.03.03.09 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 20 Jun 2014 03:03:11 -0700 (PDT) From: Sachin Kamat To: alsa-devel@alsa-project.org Date: Fri, 20 Jun 2014 15:29:12 +0530 Message-Id: <1403258352-8210-16-git-send-email-sachin.kamat@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1403258352-8210-1-git-send-email-sachin.kamat@samsung.com> References: <1403258352-8210-1-git-send-email-sachin.kamat@samsung.com> Cc: broonie@kernel.org, spk.linux@gmail.com, lgirdwood@gmail.com Subject: [alsa-devel] [PATCH 16/16] ASoC: wm_hubs: Remove redundant OOM message X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Let memory subsystem handle the error logging. Signed-off-by: Sachin Kamat Acked-by: Charles Keepax --- sound/soc/codecs/wm_hubs.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/codecs/wm_hubs.c b/sound/soc/codecs/wm_hubs.c index 916817fe6632..374537d5e179 100644 --- a/sound/soc/codecs/wm_hubs.c +++ b/sound/soc/codecs/wm_hubs.c @@ -183,10 +183,8 @@ static void wm_hubs_dcs_cache_set(struct snd_soc_codec *codec, u16 dcs_cfg) return; cache = devm_kzalloc(codec->dev, sizeof(*cache), GFP_KERNEL); - if (!cache) { - dev_err(codec->dev, "Failed to allocate DCS cache entry\n"); + if (!cache) return; - } cache->left = snd_soc_read(codec, WM8993_LEFT_OUTPUT_VOLUME); cache->left &= WM8993_HPOUT1L_VOL_MASK;